Re: [libvirt] [PATCH 0/2] Forbid new-line char in name of domains and storagepools

Hello, Thanks a lot. I have no idea how I not checked it. I compiled it for sure (but maybe not after this one change :/) -- Best regards / Pozdrawiam Sławek Kapłoński sla...@kaplonski.pl On Tue, 22 Nov 2016, Michal Privoznik wrote: > On 11.11.2016 10:17, Sławek Kapłoński wrote: > >

Re: [libvirt] [PATCH 0/2] Forbid new-line char in name of domains and storagepools

Hello, Can someone review this patch maybe? Thx in advance :) -- Best regards / Pozdrawiam Sławek Kapłoński sla...@kaplonski.pl On Fri, 11 Nov 2016, Sławek Kapłoński wrote: > As https://bugzilla.redhat.com/show_bug.cgi?id=818064 is closed and new-line > char is now forbiden in name of n

[libvirt] [PATCH 1/2] Forbid new-line char in name of new domain

New line character in name of domain is now forbidden because it mess virsh output and can be confusing for users. Validation of name is done in drivers, after parsing XML to avoid problems with dissappeared domains which was already created with new-line char in name. ---

[libvirt] [PATCH 0/2] Forbid new-line char in name of domains and storagepools

As https://bugzilla.redhat.com/show_bug.cgi?id=818064 is closed and new-line char is now forbiden in name of network, this patch forbids it also in names of domains and storage pools. Sławek Kapłoński (2): Forbid new-line char in name of new domain Forbid new-line char in name of new

[libvirt] [PATCH 2/2] Forbid new-line char in name of new storagepool

New line character in name of storagepool is now forbidden because it mess virsh output and can be confusing for users. Validation of name is done in driver, after parsing XML to avoid problems with dissappeared pools which was already created with new-line char in name. ---

Re: [libvirt] [PATCH] Resuming running domain raise error message

Hello, Thx a lot but strictly speaking it's my second patch to libvirt :) -- Best regards / Pozdrawiam Sławek Kapłoński sla...@kaplonski.pl On Wed, 26 Oct 2016, Martin Kletzander wrote: > On Sat, Oct 22, 2016 at 12:30:01PM +0200, Sławek Kapłoński wrote: > > When user tries to resum

Re: [libvirt] [PATCH] Resuming running domain raise error message

Hello, Can someone take a look at this patch? Thx in advance :) -- Best regards / Pozdrawiam Sławek Kapłoński sla...@kaplonski.pl On Sat, 22 Oct 2016, Sławek Kapłoński wrote: > When user tries to resume already running domain (Qemu or LXC) > there is VIR_ERR_OPERATION_INVALID error rais

[libvirt] [PATCH] Resuming running domain raise error message

When user tries to resume already running domain (Qemu or LXC) there is VIR_ERR_OPERATION_INVALID error raised now with message that domain is already running. Closes-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1009008 --- src/lxc/lxc_driver.c | 8 +++- src/qemu/qemu_driver.c | 4

[libvirt] [PATCH] Resuming running domain raise error message now

This patch introduce raising XML error when user tries to resume domain (Qemu or LXC) which is already running. Closes bug: https://bugzilla.redhat.com/show_bug.cgi?id=1009008 Sławek Kapłoński (1): Resuming running domain raise error message src/lxc/lxc_driver.c | 8 +++- src/qemu

Re: [libvirt] [RFC] Toward a better NEWS file

solution for You also :) -- Best regards / Pozdrawiam Sławek Kapłoński sla...@kaplonski.pl On Fri, 21 Oct 2016, Michal Privoznik wrote: > On 19.10.2016 19:58, Daniel P. Berrange wrote: > > On Wed, Oct 19, 2016 at 01:53:41PM +0200, Andrea Bolognani wrote: > >> Hi, > >>

Re: [libvirt] [PATCH v4 0/3] Forbid new-line char in name of networks

Hello, -- Best regards / Pozdrawiam Sławek Kapłoński sla...@kaplonski.pl On Thu, 20 Oct 2016, Michal Privoznik wrote: > On 20.10.2016 04:57, Sławek Kapłoński wrote: > > v3: http://www.redhat.com/archives/libvir-list/2016-October/msg00627.html > > > > Differences in v4: &g

[libvirt] [PATCH 2/3] Use new util function to check network name

New util function virXMLNodeHasIllegalChars is now used to test if parsed network contains illegal char '/' in it's name. --- src/conf/network_conf.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index aa39776..bd934f1

[libvirt] [PATCH 1/3] util: Add function to check if string contains some illegal chars

This new function can be used to check if e.g. name of XML node don't contains forbidden chars like "/" or "\n". --- src/libvirt_private.syms | 1 + src/util/virxml.c| 28 src/util/virxml.h| 3 +++ 3 files changed, 32 insertions(+) diff --git

[libvirt] [PATCH 3/3] Forbid new-line char in name of new networks

New line character in name of network is now forbidden because it mess virsh output and can be confusing for users. Validation of name is done in network driver, after parsing XML to avoid problems with dissappeared network which was already created with new-line char in name. Closes-Bug:

[libvirt] [PATCH v4 0/3] Forbid new-line char in name of networks

v3: http://www.redhat.com/archives/libvir-list/2016-October/msg00627.html Differences in v4: * function to check string moved from src/util/virstring to src/util/virxml Sławek Kapłoński (3): util: Add function to check if string contains some illegal chars Use new util function to check

Re: [libvirt] [PATCH 1/2] util: Add function to check if string contains some chars

Hello, -- Best regards / Pozdrawiam Sławek Kapłoński sla...@kaplonski.pl On Wed, 19 Oct 2016, Michal Privoznik wrote: > On 19.10.2016 03:55, Sławek Kapłoński wrote: > > Tue, 18 Oct 2016, Michal Privoznik wrote: > >> > On 14.10.2016 04:53, Sławek Kapłoński wrote: > &

Re: [libvirt] [PATCH 1/2] util: Add function to check if string contains some chars

Hello, Thx for review. Please read my answear inline. -- Best regards / Pozdrawiam Sławek Kapłoński sla...@kaplonski.pl On Tue, 18 Oct 2016, Michal Privoznik wrote: > On 14.10.2016 04:53, Sławek Kapłoński wrote: > > This new function can be used to check if e.g. name of XML node

[libvirt] [PATCH 1/2] util: Add function to check if string contains some chars

This new function can be used to check if e.g. name of XML node don't contains forbidden chars like "/" or new-line. --- src/conf/network_conf.c | 2 +- src/libvirt_private.syms | 1 + src/util/virstring.c | 9 + src/util/virstring.h | 1 + 4 files changed, 12 insertions(+), 1

[libvirt] [PATCH 2/2] Forbid new-line char in name of new networks

New line character in name of network is now forbidden because it mess virsh output and can be confusing for users. Validation of name is done in network driver, after parsing XML to avoid problems with dissappeared network which was already created with new-line char in name. Closes-Bug:

[libvirt] [PATCH v3 0/2] Forbid new-line char in name of networks

networks Sławek Kapłoński (2): util: Add function to check if string contains some chars Forbid new-line char in name of new networks src/conf/network_conf.c | 2 +- src/libvirt_private.syms| 1 + src/network/bridge_driver.c | 6 ++ src/util/virstring.c| 9 + src/util

[libvirt] [PATCH 0/2] Forbid new-line char in name of networks

*** BLURB HERE *** Sławek Kapłoński (2): util: Add function to check if string contains some chars Forbid new-line char in name of networks src/conf/network_conf.c | 5 + src/util/virxml.c | 18 ++ src/util/virxml.h | 4 3 files changed, 23 insertions

[libvirt] [PATCH 2/2] Forbid new-line char in name of networks

New line character in name of network is now forbidden because it mess virsh output and can be confusing for users. Closes-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=818064 --- src/conf/network_conf.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[libvirt] [PATCH 1/2] util: Add function to check if string contains some chars

This new function can be used to check if e.g. name of XML node don't contains forbidden chars like "/" or new-line. --- src/util/virxml.c | 18 ++ src/util/virxml.h | 4 2 files changed, 22 insertions(+) diff --git a/src/util/virxml.c b/src/util/virxml.c index

Re: [libvirt] [PATCH] Forbid new-line char in name of networks

Hello, Ok. Thx for review. I will try today make new function for it and also will look for how arguments should be splitted in multiple lines. -- Best regards / Pozdrawiam Sławek Kapłoński sla...@kaplonski.pl On Mon, 10 Oct 2016, Peter Krempa wrote: > On Mon, Oct 10, 2016 at 04:53:15 +0

[libvirt] [PATCH] Forbid new-line char in name of networks

New line character in name of network is now forbidden because it mess virsh output and can be confusing for users. Closes-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=818064 --- src/conf/network_conf.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/conf/network_conf.c