Re: [libvirt] [PATCH] add the check whether the domain has alreadyused a disk which attach

attach-disk does not give an error, when the domain which is attached has already used the source which attach. This has danger of the data corruption. I make the patch to add the check of this. This patch outputs an error, when the domain which is

Re: [libvirt] [PATCH] add the check whether the domain has already used a disk which attach

attach-disk does not give an error, when the domain which is attached has already used the source which attach. This has danger of the data corruption. I make the patch to add the check of this. This patch outputs an error, when the domain which is attached has

Re: [libvirt] [PATCH] add the check whether the domain has already used a disk which attach

On Wed, Nov 05, 2008 at 10:05:14AM +0900, S.Sakamoto wrote: Hi, attach-disk does not give an error, when the domain which is attached has already used the source which attach. This has danger of the data corruption. I make the patch to add the check of this. This patch outputs

[libvirt] [PATCH] add the check whether the domain has already used a disk which attach

Hi, attach-disk does not give an error, when the domain which is attached has already used the source which attach. This has danger of the data corruption. I make the patch to add the check of this. This patch outputs an error, when the domain which is attached has already used the source which

[libvirt] [PATCH] add the check of memory size in xenXMDriver for setmem of Xen domain

, xs_internal.c do the right thing. The problem is error handling on libvirt.c(Xen Store error is not handled properly). Do you investigate it? Thanks Atsushi SAKAI S.Sakamoto [EMAIL PROTECTED] wrote: Hi, I have a question. Why does libvirt check size of memory

[libvirt] [Q]Why does libvirt check size of memory in xenStoreDriver?

Hi, I have a question. Why does libvirt check size of memory in xenStoreDomainSetMemory of xs_internal.c? In the xen not exclude lifecycle, when I do the following command for the domain that is shutoff, error message is output and return value is 0 and the definition file(=/etc/xen/XXX) is

[libvirt] [RFC][PATCH] virt-manager calls migration API

Hi, I just make the proto patch that calls migration API from virt-manager. Form unity point of view, This proto patch adds Migrate in as same layer as operations for the Domain. Fisrt, this patch adds Migrate to the right-click menu when selected a domain. Run Run Pause

Re: [libvirt] [PATCH] Implement autostart commands for xen

The attached patch implements the domain autostart commands for xen. The xen sexpr (since at least 3.0.4 = 1.5 years) has a on_xend_start field which can be used to autostart a domain. It is a good patch for me. It moved without a problem when I tested it. By the way, I have

Re: [libvirt] [PATCH] Implement autostart commands for xen

The attached patch implements the domain autostart commands for xen. The xen sexpr (since at least 3.0.4 = 1.5 years) has a on_xend_start field which can be used to autostart a domain. It is a good patch for me. It moved without a problem when I tested it. By the way, I have a question.

Re: [Libvir] [PATCH] Another Report error in virsh.c code.

Would you give me a comment on my opinion ? If not, I make a patch that is suitable for my opinion. I forgot to attach a patch... I attach it. If not, please apply it. Shigeki Sakamoto. virsh.patch Description: Binary data -- Libvir-list mailing list Libvir-list@redhat.com

Re: [Libvir] [PATCH] Another Report error in virsh.c code.

Hi, Would you give me a comment on my opinion ? If not, I make a patch that is suitable for my opinion. Shigeki Sakamoto. $ virsh vcpupin error: command 'vcpupin' requires domain option error: command 'vcpupin' requires vcpu option error: command 'vcpupin' requires cpulist

Re: [Libvir] [PATCH] Another Report error in virsh.c code.

$ virsh vcpupin error: command 'vcpupin' requires domain option error: command 'vcpupin' requires vcpu option error: command 'vcpupin' requires cpulist option These messages that vshCommandCheckOpts outputs is no problem. What I meant to say was that I want to apply following rules of

Re: [Libvir] [PATCH] Another Report error in virsh.c code.

On Tue, Mar 11, 2008 at 05:09:45PM +0900, S.Sakamoto wrote: BTW, I think another message is needed here to inform the internal error to user. For example, the migrate command shows the following message when desturi is missing: migrate: Missing desturi But it does not show

[Libvir] [PATCH] Another Report error in virsh.c code.

Hi, I am watching through the virsh code for same type bug check. http://git.et.redhat.com/?p=libvirt.git;a=commit;h=c857ace66df5a5068ed561aad913b29fd36160f9 And I found another point it should report error. Thanks, Shigeki Sakamoto. Index: src/virsh.c

[Libvir] [PATCH] add error message for the case of the vcpupin command fails.

Hi, I try follow, # virsh vcpupin guest_dom AAA 0,1 [no error messages] # echo $? 1 There is no processing to output an error-message, when vshCommandOptInt become an error. I make the patch to solve this problem. Thanks, Shigeki Sakamoto. Index: src/virsh.c

Re: [Libvir] [PATCH] add error message for the case of the vcpupincommand fails.

On Tue, Mar 04, 2008 at 11:03:25AM +, Richard W.M. Jones wrote: OK, I'm going to qualify that a bit. Is it always safe to access arg-data? I think probably it is, but I'm not sure so I modified the patch slightly just to print an error message like this: $ src/virsh -c

[Libvir] [PATCH]check NULL of mac

Hi, attach-device become the segmentation fault, when it uses following xml. (There is no address='xx') ++ |interface type='bridge' | | source bridge='xenbr0'/ | | mac/

[Libvir] [PATCH]Change MAC address to case insensitive

Hi, xenXMDomainAttachDevice and xenXMDomainDetachDevice treats case sensitve for MAC address of stopping domain. This patch changes from case sensitive to case insensitive. Thanks, Shigeki Sakamoto. Index: src/xm_internal.c ===

Re: [Libvir] [PATCH]Change MAC address to case insensitive

OK, try this patch. I tried this patch. It works fine to me. Shigeki Sakamoto. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [Libvir] [PATCH] change a Disk/Nic of inactive domain

These struct definitions *intentionally* private. Oops, I did not notice it... I revised a patch not to access the struct data directly. In principle this patch looks good. If no one else objects, I'll commit this, with a few of my own fixes (below). Rich. +

[Libvir] [PATCH] change a Disk/Nic of inactive domain

Hi The libvirt on Xen-3.03 does not have the function that add/change/delete a Disk/NIC of inactive domain. So, I made a patch which enabled add/change/delete of Disk/NIC of inactive domain. This patch will be able to change disk or vif parameter in configuration file with

Re: [Libvir] [Q]Will virConnectNumOfNetworks and virConnectNumOfDefinedNetworks be supported by Xen ?

Hi, Rich Because log is pressed, I want to the breakage is revised if possible... If it will be revised, when is it ? Thanks, Shigeki Sakamoto. On Thu, Jun 28, 2007 at 10:21:17AM +0100, Richard W.M. Jones wrote: S.Sakamoto wrote: Hi, When I use virt-manager that is connected by xen

[Libvir] [Q]Will virConnectNumOfNetworks and virConnectNumOfDefinedNetworks be supported by Xen ?

Hi, When I use virt-manager that is connected by xen, the following error is given at every monitoring. libvir: Error : this function is not supported by the hypervisor: virConnectNumOfNetworks libvir: Error : this function is not supported by the hypervisor: virConnectNumOfDefinedNetworks

[Libvir] Re: [PATCH] allocate virBuffer* routines

Hi, Daniel I can't help thinking this method would be better off using the dyn allocated virBuffer* routines instead of a static string snprintf. Oops, sorry, virBuffer* routines had entirely slipped my mind. Buffer is allocated dynamically when I use this. therefore, I make the patch

[Libvir] [PATCH] increase storage domains of a definition file

Hi, When I install by virt-intall with long command (e.g.# /usr/sbin/virt-install --name testvm --ram 350 --vcpus 2 --file /root/test.img --file-size 1 --file /root/tmp02.img -- file-size 1 --file /root/tmp03.img --file-size 1 --file /root/tmp04.img --file-size 1 --file /root/tmp05.img

Re: [Libvir] [PATCH] About remote operation restrictions of a general user

Hi, Daniel 1)in general user # virsh destroy domain operation virDomainCreate forbidden for read only access-- I agree with this behavior # virsh --conexct xen destory domain operation virDomainCreate forbidden for read only access-- I

[Libvir] [PATCH] Check ReadOnly-flag

Hi When a general user uses command # virsh --connect xen start domain, don't become an error, and domain start. Because ReadOnly-flag is not 1 when a general user uses it. So, here's the patch adds to check ReadOnly-flag. Signed-off-by: Shigeki Sakamoto [EMAIL PROTECTED] Thanks, Shigeki

[Libvir] [Q] about virsh-connect

Hi, I have a question. 　Previously(libvirt 0.2.1) We can do remote connection via URI successfully.. (virsh --connect http://127.0.0.1:8000 list) But Current version(libvirt-current) cannot connect remotely. This event occurs in both general user and administrator. I investigate the code and

Re: [Libvir] [PATCH] About remote operation restrictions of a general user

Hi, Daniel Sorry, I think that explanation was not enough... About virsh connect of Xen: When a general user has access to remote, he can't carry out a command of virsh --connect xen start domain, but, he can carry out a command of virsh --connect http://10.xx.xx.xx:8000 start domain. (What

[Libvir] [PATCH] About remote operation restrictions of a general user

Hi When I use virt-connect in a general user, and a general user can perform operation system such as start. So, here's the patch adds to can't use operation system in connect in a general user. Signed-off-by: Shigeki Sakamoto [EMAIL PROTECTED] Thanks, Shigeki Sakamoto. Index: src/virsh.c