e ago to expose another
file so that we can distinguish between the user specified settings vs the
actual scenario underneath. But the conclusion in the ensuing discussion
was that the existing kernel behaviour is good as is, and trying to "fix"
it would break kernel semantics. (However
ar
CPU hotplug. It is an expected behaviour.
[Note that, technically the kernel can be "fixed" for this case as well. But
this
would break kernel semantics for CPU hotplug. Hence we have chosen not to do it.
The suspend/resume case was inevitable (as long as it depends on CPU hotplug).]
n.
>>
>> ACK with that wording change.
>>
>
> Sorry, "at least 60 seconds" means the 60 is permissible minimun
> value.
> but actually according to the code, the 61 seconds is the minimun
> value.
> Or we change the code from "<=" to "<"?
>
> if (alarmTime <= MIN_TIME_REQ_FOR_SUSPEND) {
> virReportError(VIR_ERR_INVALID_ARG, "%s",
>_("Suspend duration is too short"));
> return -1;
> }
>
You could change the code, to accept 60 seconds or more as a valid value.
60 seconds is not a hard-and-fast rule anyway.. Its just a good estimate
that aims to be on the safer side, that's all.
Regards,
Srivatsa S. Bhat
IBM Linux Technology Center
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
irsh
> +
> +
> +
> + A normal configuration of libvirt will build hypervisor drivers
> + as loadable modules. When runnning from a non-installed source
s/runnning/running
> + tree, libvirtd will attempt to find the modules from the same
> + sou
On 04/17/2012 03:02 PM, Daniel P. Berrange wrote:
> On Tue, Apr 17, 2012 at 11:09:33AM +0530, Srivatsa S. Bhat wrote:
>> On 04/16/2012 09:43 PM, Daniel P. Berrange wrote:
>>
>>> On Mon, Apr 16, 2012 at 06:00:22PM +0200, Marc-André Lureau wrote:
>>>> Hi
>&
On 04/16/2012 09:43 PM, Daniel P. Berrange wrote:
> On Mon, Apr 16, 2012 at 06:00:22PM +0200, Marc-André Lureau wrote:
>> Hi
>>
>> On Mon, Apr 16, 2012 at 2:32 PM, Srivatsa S. Bhat
>> wrote:
>>> On 04/16/2012 05:34 PM, Marc-André Lureau wrote:
>>> Di
e or a hibernation/restore
on your computer? (Or did you do CPU hotplug manually?)
If yes, you might be seeing the problem reported at:
https://bugzilla.redhat.com/show_bug.cgi?id=714271
Unfortunately, as of now the kernel still doesn't handle this
properly.. IOW, we don't have a kernel
ams);
>
> /* Power Management Capabilities of the host system */
>
> -int virDiscoverHostPMFeature(unsigned int *bitmask, unsigned int feature);
> +int virDiscoverHostPMFeature(unsigned int feature, bool *supported);
> int virGetPMCapabilities(unsigned int *bitmask);
>
> #endif /* __VIR_UTIL_H__ */
--
Regards,
Srivatsa S. Bhat
IBM Linux Technology Center
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
d.h
> nodeSuspendForDuration;
> virNodeSuspendInit;
> +virNodeSuspendGetTargetMask;
> +virNodeSuspendSupportsTarget;
And we need not export virNodeSuspendSupportsTarget here, if
we mark it as static in patch 7/14.
--
Regards,
Srivatsa S. Bhat
IBM Linux Technology Center
--
libvir-list mailing list
libvi
rn 0;
> +}
> diff --git a/src/util/virnodesuspend.h b/src/util/virnodesuspend.h
> index 66e3214..1e23ce8 100644
> --- a/src/util/virnodesuspend.h
> +++ b/src/util/virnodesuspend.h
> @@ -32,5 +32,7 @@ int nodeSuspendForDuration(virConnectPtr conn,
>
> int virNodeSuspendInit(void);
>
> +int virNodeSuspendSupportsTarget(unsigned int target, bool *supported);
> +int virNodeSuspendGetTargetMask(unsigned int *bitmask);
>
> #endif /* __VIR_NODE_SUSPEND_H__ */
--
Regards,
Srivatsa S. Bhat
IBM Linux Technology Center
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
gt;host.powerMgmt;
> +virBufferAddLit(&xml, "\n");
> +while (pm) {
> +int bit = ffs(pm) - 1;
> +virBufferAsprintf(&xml, " <%s/>\n",
> + virCapsHostPMTargetTypeToString(bit));
> +
_SUSPEND_TARGET_HYBRID
where VIR_NODE_SUSPEND_TARGET_HYBRID etc were like 1 << 0, 1 << 1 etc
Thus, this was ugly, but not broken. Otherwise, it would have surely
failed my suspend tests which I ran every time before submitting the
patches :-)
--
Regards,
Srivatsa S. Bhat
IBM Linux Technology Center
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 11/29/2011 09:53 PM, Eric Blake wrote:
> On 11/29/2011 09:19 AM, Srivatsa S. Bhat wrote:
>>> /**
>>> - * virGetPMCapabilities:
>>> + * virNodeSuspendGetTargetMask:
>>> *
>>> * Get the Power Management Capabilities that the host system suppor
+2675,19 @@ cleanup:
> }
>
> /**
> - * virGetPMCapabilities:
> + * virNodeSuspendGetTargetMask:
> *
> * Get the Power Management Capabilities that the host system supports,
> * such as Suspend-to-RAM (S3), Suspend-to-Disk (S4) and Hybrid-Suspend
> * (a combination of S3 and S4).
> *
You might want to remove the terminology "S3", "S4" etc from here, perhaps?
--
Regards,
Srivatsa S. Bhat
IBM Linux Technology Center
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 11/29/2011 03:12 PM, Daniel Veillard wrote:
> On Tue, Nov 29, 2011 at 03:12:07AM +0530, Srivatsa S. Bhat wrote:
>> This patchset adds a new API to put a host to a suspended state
>> (Suspend-to-RAM, Suspend-to-Disk or Hybrid-Suspend) and setup a timed resume
>> to get
On 11/29/2011 12:37 PM, Daniel Veillard wrote:
> On Thu, Nov 24, 2011 at 02:22:41PM +0530, Srivatsa S. Bhat wrote:
>> Some systems support a feature known as 'Hybrid-Suspend', apart from the
>> usual system-wide sleep states such as Suspend-to-RAM (S3) or Suspend
Add a new command 'nodesuspend' to perform a timed suspend on the host.
Signed-off-by: Srivatsa S. Bhat
---
tools/virsh.c | 64 +++
tools/virsh.pod |7 ++
2 files changed, 71 insertions(+), 0 deletions(-)
diff --g
it to disk etc.
So, we do not allow the user to specify a suspend duration of less than 60
seconds, to be on the safer side, since we don't want to prematurely declare
failure when we only had to wait for some more time.
Signed-off-by: Srivatsa S. Bhat
---
src/Makefile.am |1
Implement the remote protocol for virNodeSuspendForDuration() API.
Signed-off-by: Srivatsa S. Bhat
---
src/remote/remote_driver.c |1 +
src/remote/remote_protocol.x | 10 +-
2 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/src/remote/remote_driver.c b/src/remote
Implement the public definitions for the new API
virNodeSuspendForDuration() which will be subsequently used to
do a timed suspend on the host.
Signed-off-by: Srivatsa S. Bhat
---
include/libvirt/libvirt.h.in | 16 +++
src/driver.h |6
src/libvirt.c
/archives/libvir-list/2011-November/msg01407.html
[2]. http://thread.gmane.org/gmane.comp.emulators.libvirt/47950
[3]. http://thread.gmane.org/gmane.comp.emulators.libvirt/49054
Srivatsa S. Bhat (4):
Add a public API to invoke suspend/resume on the host
Add the remote protocol implementation
On 11/28/2011 11:26 PM, Eric Blake wrote:
> On 11/28/2011 10:46 AM, Srivatsa S. Bhat wrote:
>
>>>> +/* Check if the host supports the requested suspend state */
>>>> +switch (state) {
>>>> +case VIR_NODE_S3:
>
On 11/28/2011 05:50 PM, Daniel P. Berrange wrote:
> On Mon, Nov 28, 2011 at 05:33:22PM +0530, Srivatsa S. Bhat wrote:
>> Add the core functions that implement the functionality of the API.
>> Suspend is done by using an asynchronous mechanism so that we can return
>> the
Hi Daniel,
On 11/28/2011 05:50 PM, Daniel P. Berrange wrote:
> On Mon, Nov 28, 2011 at 05:33:22PM +0530, Srivatsa S. Bhat wrote:
>> Add the core functions that implement the functionality of the API.
>> Suspend is done by using an asynchronous mechanism so that we can return
>&
Implement the public definitions for the new API
virNodeSuspendForDuration() which will be subsequently used to
do a timed suspend on the host.
Signed-off-by: Srivatsa S. Bhat
---
include/libvirt/libvirt.h.in | 17 +++-
src/driver.h |6
src/libvirt.c
Implement the remote protocol for virNodeSuspendForDuration() API.
Signed-off-by: Srivatsa S. Bhat
---
src/remote/remote_driver.c |1 +
src/remote/remote_protocol.x | 10 +-
2 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/src/remote/remote_driver.c b/src/remote
Add a new command 'nodesuspend' to perform a timed suspend on the host.
Signed-off-by: Srivatsa S. Bhat
---
tools/virsh.c | 64 +++
tools/virsh.pod |7 ++
2 files changed, 71 insertions(+), 0 deletions(-)
diff --g
/2011-November/msg01407.html
[5]. http://thread.gmane.org/gmane.comp.emulators.libvirt/47950
Srivatsa S. Bhat (4):
Add a public API to invoke suspend/resume on the host
Add the remote protocol implementation for virNodeSuspendForDuration
Implement the core API to suspend/resume the
. However, returning the status to the caller is only best-effort,
but not guaranteed.
To resume the host, an RTC alarm is set up (based on how long we want to
suspend) before suspending the host. When this alarm fires, the host gets
woken up.
Signed-off-by: Srivatsa S. Bhat
---
src
dition was suggested in [1].
References:
1. http://www.redhat.com/archives/libvir-list/2011-November/msg01298.html
Signed-off-by: Srivatsa S. Bhat
---
docs/formatcaps.html.in | 12 +++--
docs/schemas/capability.rng |5 ++
src/conf/capabilities.c |2 -
src/util/util.c
On 11/23/2011 06:55 PM, Eric Blake wrote:
> On 11/23/2011 05:33 AM, Srivatsa S. Bhat wrote:
>>> Perhaps, I'll send a companion patch to add the hybrid-suspend discovery
>>> to that, and then base the next version of this patchset on that.
>>>
>>
>> A
On 11/23/2011 04:10 PM, Srivatsa S. Bhat wrote:
> On 11/22/2011 11:56 PM, Eric Blake wrote:
>> On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote:
>>> Define the required interfaces to export the API.
>>>
>>> Signed-off-by: Srivatsa S. Bhat
>>> ---
On 11/22/2011 11:56 PM, Eric Blake wrote:
> On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote:
>> Define the required interfaces to export the API.
>>
>> Signed-off-by: Srivatsa S. Bhat
>> ---
>>
>> include/libvirt/libvirt.h.in |4
>> src
On 11/22/2011 11:33 PM, Eric Blake wrote:
> On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote:
>> Add the core functions that implement the functionality of the API.
>> Suspend is done by using an asynchronous mechanism so that we can return
>> the status to the caller success
On 11/22/2011 08:59 AM, Daniel Veillard wrote:
> On Wed, Nov 09, 2011 at 04:38:02PM +0530, Srivatsa S. Bhat wrote:
>> This patch exports KVM Host Power Management capabilities as XML so that
>> higher-level systems management software can make use of these features
>>
On 11/22/2011 05:53 AM, Eric Blake wrote:
> On 11/13/2011 10:29 PM, Srivatsa S. Bhat wrote:
>> On 11/09/2011 04:38 PM, Srivatsa S. Bhat wrote:
>>> This patch exports KVM Host Power Management capabilities as XML so that
>>> higher-level systems management software can
On 11/22/2011 06:18 AM, Eric Blake wrote:
> On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote:
>> Add the core functions that implement the functionality of the API.
>> Suspend is done by using an asynchronous mechanism so that we can return
>> the status to the caller success
On 11/22/2011 03:48 PM, Alon Levy wrote:
> On Mon, Nov 21, 2011 at 05:26:55PM -0700, Eric Blake wrote:
>> On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote:
>>> (This patch is positioned to go in after the patch that exports the host
>>> power management capabilities as XM
On 11/22/2011 05:56 AM, Eric Blake wrote:
> On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote:
>> (This patch is positioned to go in after the patch that exports the host
>> power management capabilities as XML, posted in [4])
>
> I'm now reviewing that patch along wi
On 11/09/2011 04:38 PM, Srivatsa S. Bhat wrote:
> This patch exports KVM Host Power Management capabilities as XML so that
> higher-level systems management software can make use of these features
> available in the host.
>
> The script "pm-is-supported" (from pm-utils pa
/2011-November/msg00378.html
Srivatsa S. Bhat (2):
Implement the asynchronous suspend and RTC wakeup
Make the API public
include/libvirt/libvirt.h.in |9 ++
src/driver.h |5 +
src/libvirt.c| 48 +
src/libvirt_private.syms |7
Define the required interfaces to export the API.
Signed-off-by: Srivatsa S. Bhat
---
include/libvirt/libvirt.h.in |4
src/driver.h |5
src/libvirt.c| 48 ++
src/libvirt_public.syms |1 +
src
execution.
To resume the host, an RTC alarm is set up (based on how long we want
to suspend) before suspending the host. When this alarm fires, the host
gets woken up.
Signed-off-by: Srivatsa S. Bhat
---
include/libvirt/libvirt.h.in |5 +
src/libvirt_private.syms |7 +
src
: http://www.redhat.com/archives/libvir-list/2011-August/msg00238.html
v1: http://thread.gmane.org/gmane.comp.emulators.libvirt/40886
References:
--
[1] http://www.redhat.com/archives/libvir-list/2011-August/msg00248.html
[2] http://www.redhat.com/archives/libvir-list/2011-August/msg0030
gt; -if (ifaceGetIndex(true, physfndev, &ifindex) < 0) {
> -rc = 1;
> +rc = ifaceGetIndex(true, physfndev, &ifindex);
> +if (rc < 0)
> goto err_exit;
> -}
>
> switch (virtPortOp) {
> case PREASSOCIATE_RR:
> @@ -1059,7 +1053,7 @@ doPort
execution.
To resume the host, an RTC alarm is set up (based on how long we want
to suspend) before suspending the host. When this alarm fires, the host
gets woken up.
Signed-off-by: Srivatsa S. Bhat
---
include/libvirt/libvirt.h.in |5 +
src/libvirt_private.syms |7 +
src
/libvir-list/2011-September/msg00438.html
[4]. http://www.redhat.com/archives/libvir-list/2011-August/msg00324.html
Srivatsa S. Bhat (2):
Implement the asynchronous suspend and RTC wakeup
Make the API public
include/libvirt/libvirt.h.in |9 ++
src/driver.h |5
Define the required interfaces to make the API publicly
accessible.
Signed-off-by: Srivatsa S. Bhat
---
include/libvirt/libvirt.h.in |4
src/driver.h |5 +
src/libvirt.c| 46 ++
src/libvirt_public.syms
://www.redhat.com/archives/libvir-list/2011-September/msg00438.html
Signed-off-by: Srivatsa S. Bhat
---
include/libvirt/libvirt.h.in |9 +++
src/driver.h |5 ++
src/libvirt.c| 45 ++
src/libvirt_private.syms |4 +
src
bly large value.
Please let me know your suggestions.
--
Regards,
Srivatsa S. Bhat
Linux Technology Center,
IBM India Systems and Technology Lab
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
ww.redhat.com/archives/libvir-list/2011-August/msg00302.html
Signed-off-by: Srivatsa S. Bhat
---
docs/formatcaps.html.in | 19
docs/schemas/capability.rng | 18 +++
include/libvirt/virterror.h |1 +
libvirt.spec.in |2
at.com/archives/libvir-list/2011-August/msg00248.html
[4] http://www.redhat.com/archives/libvir-list/2011-August/msg00302.html
[5] http://www.redhat.com/archives/libvir-list/2011-August/msg00282.html
Signed-off-by: Srivatsa S. Bhat
---
docs/formatcaps.html.in | 19 +++-
[4] http://www.redhat.com/archives/libvir-list/2011-August/msg00248.html
Signed-off-by: Srivatsa S. Bhat
---
docs/formatcaps.html.in | 19 ++---
docs/schemas/capability.rng | 23
include/libvirt/virterror.h |1 +
src/conf/capabilities.c | 50
On 08/05/2011 09:21 PM, Eric Blake wrote:
> On 08/05/2011 05:54 AM, Srivatsa S. Bhat wrote:
>> This patch exports KVM Host Power Management capabilities as XML so that
>> higher-level systems management software can make use of these features
>> available in the host.
&g
g capabilities through libvirt
http://thread.gmane.org/gmane.comp.emulators.libvirt/40886
[2] http://article.gmane.org/gmane.comp.emulators.libvirt/41688
Signed-off-by: Srivatsa S. Bhat
---
src/conf/capabilities.c | 34 +++
src/conf/capabilities.h |7 ++
src/
55 matches
Mail list logo
