Re: [libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.

Hi Dan, Tatsuro Enokura wrote: I don't think that is neccessary. You'll only invoke virDomainGetSecurityLabel if virNodeGetSecurityModel() was asuccessfull and the returned secmodel is not the empty string. In such a scenario I'd expect the call to virDomainGetSecurityLabel

Re: [libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.

In such a scenario I'd expect the call to virDomainGetSecurityLabel() to always be successful and would want the user to see any error if it fail OK, I understood. I try your patch, works fine. Thanks Tatsuro Enokura -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.

*/ if (secmodel.model[0] != '\0') { Don't check last_error->code of virDomainGetSecurityLabel()? should check the same as virNodeGetSecurityModel(). Thanks Tatsuro Enokura -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.

rted these operations. - In CmdDominfo(), it is no operation when virNodeGetSecurityModel() and virNodeGetSecurityModel() return -2. Signed-off-by: Tatsuro Enokura Thanks Tatsuro Enokura Index: src/libvirt.c === RCS file: /data/c

Re: [libvirt] [PATCH] Fix the style of argument("cpumap") in op_pincpu()

the change only for version of xend>= 3 which won't >> cover the full range but should still protect some of the older setups, > >Urgh, I wasn't fully awake, that one does compile :-\ ! Thank you! this patch works fine for xend-unstable. Thanks, Tatsuro Enokura -

Re: [libvirt] [PATCH] Fix the style of argument("cpumap") in op_pincpu()

xendConfigVersion isn't appropriate for tracing the xend's version. We should request to the xen community for new interface of to get the xend's version. On other hand, the new xend and libvirt without the cpumap patch occur error(NG2). Behavior of the old xend and libvirt with the cp

Re: [libvirt] [PATCH] Fix the style of argument("cpumap") in op_pincpu()

t set cpu affinity. NG2: virsh command end with show error msg. Result (1),(2) is the same as result (3),(4). # The each command log is attached. Thakns, Tatsuro Enokura (1) command end normaly but can't set cpu affnity. [r...@vmx07 .libs]# xm vcpu-list vm1 Name

[libvirt] [PATCH] Fix the style of argument("cpumap") in op_pincpu()

pumap argument. "[0,1,2]"---> "0,1,2" Signed-off-by: Tatsuro Enokura # my e-mail address has changed. Thanks Tatsuro Enokura Index: src/xend_internal.c === RCS file: /data/cvs/libvirt/src/xend_internal.c

Re: [Libvir] [PATCH] Xen: Support cpu_weight and cpu_cap for Xen.

o that: > > virsh save foo foo.img --save-tuning foo-tuning.xml > > This captures the tuning information into the XML file, and is the same > as doing an ordinary 'save' followed by 'virsh savetuning'. Sounds good to me. Thanks, Tatsuro Enokura -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [Libvir] The problem of the definition of tuning informations

API can be used > to change those informations, it is better to keep them separate. > However I got objections from David Lutterkort [1], Jim Fehlig [2], > and John Levon [3] plus of course the initial request for it from > Tatsuro Enokura (and the Fujistu people in general) [4] > The pro

Re: [Libvir] [PATCH] Xen: Support cpu_weight and cpu_cap for Xen.

the libvirt API > > to make the scheduler tuning. > > > > Can you explain why you absolutely want to have that tuning information > > in the XML itself ? In xentool case, weight/cap set by user to configuration file/sxp is seting at starting the domain. The user may not do a

[Libvir] [PATCH] Xen: Support cpu_weight and cpu_cap for Xen.

i?id=337591 I make a patch to add weight/cap attributes as vcpus element (eg. 4) c.f. the thread at: https://www.redhat.com/archives/libvir-list/2007-October/msg00044.html Signed-off-by: Tatsuro Enokura <[EMAIL PROTECTED]> Thanks, Tatsuro Enokura Index: libvir

[Libvir] [PATCH] fix negative value handling of virConfParseLong()

Hi, I found a bug about negative value at virConfParseLong() in conf.c. This patch fixes it. Signed-off-by: Tatsuro Enokura <[EMAIL PROTECTED]> Thanks, Tatsuro Enokura. -- Index: libvirt/src/

Re: [Libvir] libvirt.py has the two functions that names are the same.

e, but the defineXML() method still have the same problem. The attached patch adds to solve the problem. Signed-off-by: Tatsuro Enokura <[EMAIL PROTECTED]> Thanks, Tatsuro Enokura Index: python/generator.py === RCS file

[Libvir] libvirt.py has the two functions that names are the same.

in libvirt.py. The lookupByUUIDstring() function is similar. I think that generator of libvirt.py's function is incorrect. Thanks, Tatsuro Enokura --- cat /usr/lib/python2.5/site-packages/libvirt.py .. snip .. def lookupByName(self, name): """Tr

Re: [Libvir] [PATCH] patch for virsh domname command error

e one we wanted. This is obviously horribly slow, > but the only option we had on Xen < 3.0.4 > > Now, that XenD does allow lookups based on UUID, I am changing your patch > so that it *always* does the lookup based on UUID, so that we avoid the > slow path completely on Xen >

Re: [Libvir] [PATCH] patch for virsh domname command error

Hi, Dan Daniel P. Berrange wrote: >> and shut-off domain's information is got from xend. >> I make a patch for xend_internal.c >> >> The attached patch resolve this issue in the following way: >> >> 1) If the domain's name can't be pulled out from >> the running domains list by uuid, reque

[Libvir] [PATCH] patch for virsh domname command error

ch resolve this issue in the following way: 1) If the domain's name can't be pulled out from the running domains list by uuid, request xend by "/xend/domains/". 2) If the domain's data can be teken from xend, pull out the domain's name. Sig