Re: [libvirt PATCH] docs: expand clangd instructions

2023-07-17 Thread Tim Small
On 14/07/2023 16:44, Jonathon Jongsma wrote: Add some additional information about running clangd for LSP when clang is not your normal compiler. Signed-off-by: Jonathon Jongsma --- docs/clangd.rst | 17 + 1 file changed, 17 insertions(+) Reviewed-By: Tim Small Tim

[libvirt PATCH 03/10] docs: Link main "contributing" from programming-specific guide

2023-07-13 Thread Tim Small
There are two guides to contributing: `hacking.rst` is focused on code contributions, and `contributing.rst` is more general. Clarify scope of `hacking.rst` and link to the general guide in its references. Signed-off-by: Tim Small --- docs/hacking.rst | 3 ++- 1 file changed, 2 insertions(+), 1

[libvirt PATCH 01/10] docs: Link to main docs directory from Quick Links

2023-07-13 Thread Tim Small
Whilst the "docs" documentation map is linked in the navigation bar, users may scroll down and lose sight of this, so also place at the bottom of the "Quick Links" section. Signed-off-by: Tim Small --- docs/index.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/d

[libvirt PATCH 10/10] docs: Reword ninja invocation note to clarify build directory

2023-07-13 Thread Tim Small
Minor rewording to clarify purpose of the -C flag in the ninja invocation, whilst retaining previous meaning. Signed-off-by: Tim Small --- docs/compiling.rst | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/compiling.rst b/docs/compiling.rst index c03238b114

[libvirt PATCH 00/10] A set of minor doc updates for new contributors

2023-07-13 Thread Tim Small
clangd will work with the libvirt code, and I thought these were worth documenting. Tim Small (10): docs: Link to main docs directory from Quick Links docs: Missing "full-stop"/"period" on some bullet items docs: Link main "contributing" from programmin

[libvirt PATCH 05/10] docs: Add config instructions for clangd with libvirt

2023-07-13 Thread Tim Small
In build environments which use gcc as the default compiler, use of the clangd LSP server (for enhanced code editing and navigation etc.) with libvirt requires some additional configuration. Detail this and link from `hacking.rst`. Signed-off-by: Tim Small --- docs/clangd.rst | 51

[libvirt PATCH 09/10] docs: Fix deprecated use of implicit meson "setup" command

2023-07-13 Thread Tim Small
ditionally the implicit command is likely to be confusing to those unfamiliar with Meson - the `build` argument in `meson build` resembles an action rather than an arbitrary path. Signed-off-by: Tim Small --- docs/compiling.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --

[libvirt PATCH 06/10] docs: Reword "Preparing Patches" to clarify

2023-07-13 Thread Tim Small
Clarify that patches should apply cleanly to the master branch. Give guidance for typical bug fix process for existing releases. Signed-off-by: Tim Small --- docs/hacking.rst | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/hacking.rst b/docs/hacking.rst index

[libvirt PATCH 02/10] docs: Missing "full-stop"/"period" on some bullet items

2023-07-13 Thread Tim Small
Signed-off-by: Tim Small --- docs/contribute.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/contribute.rst b/docs/contribute.rst index 6ed5426b8a..c1d57a8584 100644 --- a/docs/contribute.rst +++ b/docs/contribute.rst @@ -25,19 +25,19 @@ to libvirt. If you have

[libvirt PATCH 07/10] docs: Advise running CI tests prior to submission

2023-07-13 Thread Tim Small
In the preparing patches section, note that it is possible to run CI tests via gitlab prior to submitting patches. Signed-off-by: Tim Small --- docs/hacking.rst | 8 1 file changed, 8 insertions(+) diff --git a/docs/hacking.rst b/docs/hacking.rst index 85918c9176..c2e79e4501 100644

[libvirt PATCH 04/10] docs: Point to compiling guide from code contribution guide

2023-07-13 Thread Tim Small
The "hacking" doc details where to find the code, but not how to compile it - link to the instructions contained in `compiling.rst`. Signed-off-by: Tim Small --- docs/hacking.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/hacking.rst b/docs/hacking.rst index

[libvirt PATCH 08/10] docs: Point to mailing list archives from submitting-patches

2023-07-13 Thread Tim Small
Suggest that new contributors should review past patch submissions for typical style, feedback etc. prior to submitting. Link to archives. Signed-off-by: Tim Small --- docs/submitting-patches.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/submitting-patches.rst b/docs

[libvirt] virsh blockresize syntax is inconsistent with vol-resize and somewhat dangerous

2019-10-24 Thread Tim Small
Hello, virsh has two commands which can be used to resize block devices - "blockresize" for volumes in use by and active guest, and "vol-resize" for volumes which are not in use. The vol-resize syntax allows to specify the size as a delta (increase or decrease vs. the current size), and also