Hi,
On Thu, May 05, 2022 at 08:57:04AM +0100, Daniel P. Berrangé wrote:
> On Thu, May 05, 2022 at 09:48:54AM +0200, Victor Toso wrote:
> > Hi,
> >
> > On Wed, May 04, 2022 at 07:02:48PM +0100, Daniel P. Berrangé wrote:
> > > On Wed, May 04, 2022 at 07:30:08PM
Hi,
On Wed, May 04, 2022 at 07:02:48PM +0100, Daniel P. Berrangé wrote:
> On Wed, May 04, 2022 at 07:30:08PM +0200, Andrea Bolognani wrote:
> > Due to hystorical reasons, it needs to be possible to pass values
hystorical -> historical ?
> > from the virTypedParameterFlags and
Hi,
On Wed, Apr 27, 2022 at 02:17:01AM -0700, Andrea Bolognani wrote:
> On Tue, Apr 26, 2022 at 06:26:26PM +0200, Victor Toso wrote:
> > On Tue, Apr 26, 2022 at 04:06:08PM +, Andrea Bolognani wrote:
> > > Ideas for follow-up work:
> > >
> > > * impr
This makes madatory to *not* add 'v' to version number.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index ddc611ec58..2a343208c5 100755
--- a/scripts/apibuild.py
+++ b
Hi,
On Tue, Apr 26, 2022 at 04:06:08PM +, Andrea Bolognani wrote:
> On Fri, Apr 22, 2022 at 09:23:25PM +0200, Victor Toso wrote:
> > - For exported version of functions, the syms file are the source of
> > truth apart from 4 functions (Peter)
> > https://listman.redha
Either create or append to existing docstring, the version (git tag)
that a given typedef was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/include/libvirt
to highlight this.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 31 ---
1 file changed, 24 insertions(+), 7 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index 40ee0a3c63..c2920d811c 100755
--- a/scripts/apibuild.py
+++ b/scripts/apibuild.py
So we can use for comments that are being hold in helper variables.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index b86d20e364..40ee0a3c63 100755
--- a/scripts
as there is a
proper field for it in the XML.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index 24ca98bd1c..b77eea0624 100755
--- a/scripts/apibuild.py
+++ b/scripts/apibuild.py
for keeping both. For now, I've added a
warning in case there is a mismatch between the version provided by
.syms and docstring.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 70 -
1 file changed, 57 insertions(+), 13 deletions(-)
diff --git
Removed the TODO as we can rely to the serialize_typedef() the job to
report missing comments.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index 19e897b1ba..ddc2fff7af
as there is a
proper field for it in the XML.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index ddc2fff7af..24ca98bd1c 100755
--- a/scripts/apibuild.py
+++ b
Either create or append to existing docstring, the version (git tag)
that a given function was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 2 ++
src/admin/libvirt-admin.c | 62 +
2 files
This patch adds 'version' parameter to the generated XML API for
enums.
It'll require, for new additions, to add a comment with the version
that the enum value was added.
Note that the Since tag is removed from the comment as there is a
proper field for it in the XML.
Signed-off-by: Victor Toso
Either create or append to existing docstring, the version (git tag)
that a given macro was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 40 +
1 file changed, 40 insertions(+)
diff --git a/include
Either create or append to existing docstring, the version (git tag)
that a given enum value was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include
Follow up patch will add Since metadata to enum values of
virStorageVolWipeAlgorithm.
This patch is necessary to avoid breaking the build with
syntax-check.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-storage.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
This was a mistake on my side in the v3 iteration of the series. I've
introduced the wrong version number in v3 10/30 and fixed later in v3
21/30. Apologies.
Fixes: 034432e47b
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion
scripts/apibuild.py does not handle well enum's with comments between
values. The outcome depends on whether the enum value has its own
docstring or not and if there is spaces between the enum values or
not.
This commit removes some generic comments that I have spotted.
Signed-off-by: Victor
st/2022-April/230352.html
- Removed an extra line in the block of comments (Andrea)
https://listman.redhat.com/archives/libvir-list/2022-April/230291.html
The CI run for this series:
https://gitlab.com/victortoso/libvirt/-/pipelines/522757286
Have a great weekend,
Victor
Victor Toso (19):
This was a mistake on my side in the v3 iteration of the series. I've
introduced the wrong version number in v3 10/30 and fixed later in v3
20/30. Apologies.
Fixes: 034432e47b
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion
This was a mistake on my side in the v3 iteration of the series. I've
introduced the wrong version number in v3 10/30 and fixed later in v3
22/30. Apologies.
Fixes: 034432e47b
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion
This was a mistake on my side in the v3 iteration of the series. I've
introduced the wrong version number in v3 10/30 and fixed later in v3
19/30. Apologies.
Fixes: 034432e47b
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-storage.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On Fri, Apr 22, 2022 at 10:05:41AM -0700, Andrea Bolognani wrote:
> On Fri, Apr 22, 2022 at 06:54:25PM +0200, Victor Toso wrote:
> > The itching to change the code all around is still here. I
> > actually created another (local) branch to put some fixes and
> > removing de
Hi,
On Fri, Apr 22, 2022 at 09:36:30AM -0700, Andrea Bolognani wrote:
> On Wed, Apr 20, 2022 at 09:08:18PM +0200, Victor Toso wrote:
> > def serialize_variable(self, output, name):
> > id = self.idx.variables[name]
> > -if id.info is not None:
> >
On Fri, Apr 22, 2022 at 07:21:11AM -0700, Andrea Bolognani wrote:
> On Fri, Apr 22, 2022 at 10:20:11AM +0200, Peter Krempa wrote:
> > Based on discussions on individual patches I've applied the feedback I
> > had including Andrea's request to remove the extra empty line on the
> > following
Hi,
On Fri, Apr 22, 2022 at 02:13:50AM -0700, Andrea Bolognani wrote:
> On Thu, Apr 21, 2022 at 08:24:39PM +0200, Victor Toso wrote:
> > On Thu, Apr 21, 2022 at 03:48:51PM +0200, Peter Krempa wrote:
> > > Actually, this paragraph is inaccurate since the commits were rename
Hi,
On Fri, Apr 22, 2022 at 01:29:07AM -0700, Andrea Bolognani wrote:
> On Thu, Apr 21, 2022 at 09:12:10PM +0200, Victor Toso wrote:
> > On Thu, Apr 21, 2022 at 11:45:05AM -0700, Andrea Bolognani wrote:
> > > On Thu, Apr 21, 2022 at 08:34:10PM +0200, Victor Toso wrote:
>
Hi,
On Fri, Apr 22, 2022 at 10:20:11AM +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:07:49 +0200, Victor Toso wrote:
> > Hi,
> >
>
> Based on discussions on individual patches I've applied the feedback I
> had including Andrea's request to remove the extra empty
Hi,
On Thu, Apr 21, 2022 at 03:13:05PM +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:07:57 +0200, Victor Toso wrote:
> > Either create or append to existing docstring, the version (git tag)
> > that a given macro was introduced in the format:
> >
> > Si
Hi,
On Thu, Apr 21, 2022 at 11:45:05AM -0700, Andrea Bolognani wrote:
> On Thu, Apr 21, 2022 at 08:34:10PM +0200, Victor Toso wrote:
> > Not sure I understood what is preferable. For all functions and
> > typdefs and macros, it should be:
> >
> > Line
> > 1
Hi,
On Thu, Apr 21, 2022 at 03:52:58PM +0200, Peter Krempa wrote:
> On Thu, Apr 21, 2022 at 15:51:25 +0200, Peter Krempa wrote:
> > On Wed, Apr 20, 2022 at 21:08:09 +0200, Victor Toso wrote:
> > > This commit is similar to "docs: Fix
Hi,
On Thu, Apr 21, 2022 at 06:21:06AM -0700, Andrea Bolognani wrote:
> On Wed, Apr 20, 2022 at 09:08:02PM +0200, Victor Toso wrote:
> > @@ -4815,6 +4821,9 @@ typedef void
> > (*virConnectDomainEventGenericCallback)(virConnectPtr conn,
> > *
> > * The cal
Hi,
On Thu, Apr 21, 2022 at 03:48:51PM +0200, Peter Krempa wrote:
> On Thu, Apr 21, 2022 at 15:43:55 +0200, Peter Krempa wrote:
> > On Wed, Apr 20, 2022 at 21:08:07 +0200, Victor Toso wrote:
> > > This commit is similar to "docs: Fix
Hi,
On Thu, Apr 21, 2022 at 03:14:05PM +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:07:58 +0200, Victor Toso wrote:
> > Either create or append to existing docstring, the version (git tag)
> > that a given macro was introduced in the format:
> >
> > Si
Hi,
On Thu, Apr 21, 2022 at 06:43:56PM +0200, Peter Krempa wrote:
> On Thu, Apr 21, 2022 at 15:05:06 +0200, Peter Krempa wrote:
> > On Wed, Apr 20, 2022 at 21:07:56 +0200, Victor Toso wrote:
> > > Either create or append to existing docstring, the version (git tag)
> > &
Hi,
On Thu, Apr 21, 2022 at 02:02:25PM +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:07:51 +0200, Victor Toso wrote:
> > We should allow strings (not the functions) in the format of
> > "virDomainFree" and friends.
> >
> > This fixes an error in la
On Thu, Apr 21, 2022 at 02:11:03PM +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:07:50 +0200, Victor Toso wrote:
> > It doesn't need to fail the test if a reentrant function is found in
> > a comment.
>
> That is true, but your patch doesn't do exactly that.
>
On Thu, Apr 21, 2022 at 01:56:19PM +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:08:16 +0200, Victor Toso wrote:
> > This patch adds 'version' parameter to generated XML API for functions
> > and functypes.
> >
> > The 'version' metadata has been added with
Hi,
On Wed, Apr 20, 2022 at 09:07:49PM +0200, Victor Toso wrote:
> Gitlab run of this series (fails with codestyle of do-not-commit
> script).
Actually, I fixed before sending.
> https://gitlab.com/victortoso/libvirt/-/pipelines/520901763
Cheers,
Victor
signature.asc
Descrip
Removed the TODO as we can rely to the serialize_typedef() the job to
report missing comments.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index 19e897b1ba..ddc2fff7af
Either create or append to existing docstring, the version (git tag)
that a given typedef was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain-checkpoint.h | 34 +-
include/libvirt/libvirt-domain-snapshot.h | 40 +-
include/libvirt
This commit is similar to "docs: Fix generated documentation of
virConnectListAllNodeDeviceFlags", check it out for more info.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/inclu
./build/docs/
| # libvirt has 2101 symbols
| # libvirt-qemu has 19 symbols
| # libvirt-lxc has 4 symbols
| # libvirt-admin has 63 symbols
| # Total of 2187 symbols checked
Signed-off-by: Victor Toso
---
scripts/version-quest.py | 190 +++
1 file changed
for keeping both. For now, I've added a
warning in case there is a mismatch between the version provided by
.syms and docstring.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 126 +++-
1 file changed, 113 insertions(+), 13 deletions(-)
diff --git
Either create or append to existing docstring, the version (git tag)
that a given function was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 3 ++
src/admin/libvirt-admin.c | 93 +
2 files
to highlight this.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index 151eba37e6..9bdea648d4 100755
--- a/scripts/apibuild.py
+++ b/scripts/apibuild.py
So we can use for comments that are being hold in helper variables.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index ec10931151..151eba37e6 100755
--- a/scripts
as there is a
proper field for it in the XML.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index 24ca98bd1c..b77eea0624 100755
--- a/scripts/apibuild.py
+++ b/scripts/apibuild.py
as there is a
proper field for it in the XML.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index ddc2fff7af..24ca98bd1c 100755
--- a/scripts/apibuild.py
+++ b
This patch adds 'version' parameter to the generated XML API for
enums.
It'll require, for new additions, to add a comment with the version
that the enum value was added.
Note that the Since tag is removed from the comment as there is a
proper field for it in the XML.
Signed-off-by: Victor Toso
This commit is similar to "docs: Fix generated documentation of
virConnectListAllNodeDeviceFlags", check it out for more info.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/inclu
Either create or append to existing docstring, the version (git tag)
that a given function was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
src/libvirt-lxc.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/libvirt-lxc.c b/src/libvirt-lxc.c
This commit is similar to "docs: Fix generated documentation of
virConnectListAllNodeDeviceFlags", check it out for more info.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/inclu
Either create or append to existing docstring, the version (git tag)
that a given typedef was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 24
1 file changed, 24 insertions(+)
diff --git a/include/libvirt
Similarly to previous commits but with the targeting libvirt-common
in a batch.
Either create or append to existing docstring, the version (git tag)
that a given typedef, enum value, macro or function was introduced
in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include
This commit is similar to "docs: Fix generated documentation of
virConnectListAllNodeDeviceFlags", check it out for more info.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-storage.h | 49 +++
1 file changed, 24 insertions(+), 25 deletions(-)
ical
size in allocation'/>+}
...
-]
{+version='3.0.0'/>+}
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-storage.h | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/include/libvirt/libvirt-storage.h
b/include/libvirt/libvirt-storage.h
index 434454f455..8
Either create or append to existing docstring, the version (git tag)
that a given typedef was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-qemu.h | 18 ++
1 file changed, 18 insertions(+)
diff --git a/include/libvirt
Either create or append to existing docstring, the version (git tag)
that a given function was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-qemu.h | 3 +++
src/libvirt-qemu.c | 18 ++
2 files changed, 21
Either create or append to existing docstring, the version (git tag)
that a given macro was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 60 +
1 file changed, 60 insertions(+)
diff --git a/include
Either create or append to existing docstring, the version (git tag)
that a given enum value was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include
Either create or append to existing docstring, the version (git tag)
that a given macro was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 663 +-
include/libvirt/libvirt-host.h| 123 ++
include
Either create or append to existing docstring, the version (git tag)
that a given enum value was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-qemu.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git
reasonable to
move the docstring to the header file instead.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-host.h | 13 +
src/libvirt.c | 11 +--
2 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/include/libvirt/libvirt-host.h b/include
+}
-]{+Target'/>+}
-]{+info='System capability'/>+}
-]{+interface'/>+}
-]{+info='Device with VPD'/>+}
-]{+info='Capable of vport'/>+}
-]{+info='Inactive devices'/>+}
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-nodedev.h | 5 ++---
1 file changed, 2 insert
) */
Signed-off-by: Victor Toso
---
build-aux/syntax-check.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index a6e3ada300..eb403f3d3f 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -300,7 +300,7
virXXXFree]
Error 1
Signed-off-by: Victor Toso
---
build-aux/syntax-check.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index eb403f3d3f..07e0295995 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check
irt/libvirt-go-module/-/merge_requests/7
Gitlab run of this series (fails with codestyle of do-not-commit
script).
https://gitlab.com/victortoso/libvirt/-/pipelines/520901763
Have a wonderful day,
Victor
Victor Toso (30):
syntax-check: sc_prohibit_nonreentrant: skip comments
syntax-ch
Hi,
On Tue, Apr 19, 2022 at 06:37:19AM -0700, Andrea Bolognani wrote:
> On Tue, Apr 19, 2022 at 03:30:12PM +0200, Peter Krempa wrote:
> > On Tue, Apr 19, 2022 at 15:17:07 +0200, Victor Toso wrote:
> > > On Tue, Apr 19, 2022 at 02:40:05PM +0200, Peter Krempa wrote:
> >
Hi,
On Tue, Apr 19, 2022 at 02:31:01PM +0200, Peter Krempa wrote:
> On Thu, Apr 14, 2022 at 22:47:11 +0200, Victor Toso wrote:
> > Hi,
>
> Couple of comments which I summarize on the top level rather than doing
> specifics since they might need a reorg of the series:
&g
Hi,
On Tue, Apr 19, 2022 at 02:40:05PM +0200, Peter Krempa wrote:
> On Thu, Apr 14, 2022 at 22:47:14 +0200, Victor Toso wrote:
> > Minor hand adjustments around syntax, not the metadata per se.
> >
> > Signed-off-by: Victor Toso
> > ---
> > include/libvirt/
Hi,
On Thu, Apr 14, 2022 at 10:47:11PM +0200, Victor Toso wrote:
> Hi,
>
> The goal of this patch series is to provide 'since' version to all
> exported types.
Forgot to add before/after diff... For 24h or so:
https://paste.centos.org/view/be5b5c78
Cheers,
> This is the n
So we can use for comments that are being hold in helper variables.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index d16beaa4ae..97f448f6bf 100755
--- a/scripts
to highlight this.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index 97f448f6bf..d1edfce3a6 100755
--- a/scripts/apibuild.py
+++ b/scripts/apibuild.py
irt-domain.h:int
virDomainSetBlockThreshold(virDomainPtr domain,
Signed-off-by: Victor Toso
---
src/libvirt_public.syms | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms
index f93692c427..84e608c7b0 100644
--- a/src/libvirt_publi
) */
Signed-off-by: Victor Toso
---
build-aux/syntax-check.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index a6e3ada300..eb403f3d3f 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -300,7 +300,7
for keeping both. For now, I've added a
warning in case there is a mismatch between the version provided by
.syms and docstring.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 50 ++---
1 file changed, 38 insertions(+), 12 deletions(-)
diff --git
as there is a
proper field for it in the XML.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index 5335670c1c..da70d67fa6 100755
--- a/scripts/apibuild.py
+++ b
as there is a
proper field for it in the XML.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index da70d67fa6..c4ff733550 100755
--- a/scripts/apibuild.py
+++ b/scripts/apibuild.py
This patch adds 'version' parameter to the generated XML API for
enums.
It'll require, for new additions, to add a comment with the version
that the enum value was added.
Note that the Since tag is removed from the comment as there is a
proper field for it in the XML.
Signed-off-by: Victor Toso
Discover this mismatch with the docstring work.
scripts/apibuild.py complained.
Signed-off-by: Victor Toso
---
src/admin/libvirt_admin_public.syms | 58 ++---
1 file changed, 45 insertions(+), 13 deletions(-)
diff --git a/src/admin/libvirt_admin_public.syms
b/src/admin
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index 015bc2faa4..451a398c42 100644
--- a/include/libvirt/libvirt-domain.h
+++ b
Removed the TODO as we can rely to the serialize_typedef() the job to
report missing comments.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index 4e9f802bde..5335670c1c
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index 8f9a3775f2..015bc2faa4 100644
--- a/include/libvirt/libvirt-domain.h
+++ b
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-qemu.h | 3 +++
src/libvirt-qemu.c | 18 ++
2 files changed, 21 insertions(+)
diff --git a/include/libvirt/libvirt-qemu.h b/include/libvirt/libvirt-qemu.h
index 838b6e9caf..b85e77f5b1 100644
--- a/include
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index 20a476412f..8f9a3775f2 100644
--- a/include/libvirt/libvirt-domain.h
+++ b
This commit adds Since metadata to the libvirt-common's macros,
enums and functions.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-common.h.in | 54 ---
src/util/virtypedparam-public.c | 57 +
2 files changed, 98 insertions(+), 13
This commit is similar to "docs: Fix generated documentation of
virConnectListAllNodeDeviceFlags", check it out for more info.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-storage.h | 47 +++
1 file changed, 23 insertions(+), 24 deletions(-)
ical
size in allocation'/>+}
...
-]
{+version='3.0.0'/>+}
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-storage.h | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/include/libvirt/libvirt-storage.h
b/include/libvirt/libvirt-storage.h
index 9a0439f348..9
This commit finishes the script work and adds docstring to types that
are not documented.
>From this commit onwards, all exported macros are versioned.
Further commits will enforce that it stays like that with new
additions.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h |
This commit finishes the script work and adds docstring to types that
are not documented.
>From this commit onwards, all exported typedefs are versioned.
Further commits will enforce that it stays like that with new
additions.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admi
This commit finishes the script work and adds docstring to types
that are not documented.
>From this commit onwards, all exported functions are versioned.
Further commits will enforce that it stays like that with new
additions.
Signed-off-by: Victor Toso
---
src/libvirt-domain.c |
This commit finishes the script work and adds docstring to types that
are not documented.
>From this commit onwards, all exported typedefs are versioned.
Further commits will enforce that it stays like that with new
additions.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-dom
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 3 ++
src/admin/libvirt-admin.c | 93 +
2 files changed, 96 insertions(+)
diff --git a/include/libvirt/libvirt-admin.h b/include/libvirt/libvirt-admin.h
index 2bfb45145d..f2cb528524 100644
Signed-off-by: Victor Toso
---
src/libvirt-lxc.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/libvirt-lxc.c b/src/libvirt-lxc.c
index 2a271b74f0..14a2f2a6ec 100644
--- a/src/libvirt-lxc.c
+++ b/src/libvirt-lxc.c
@@ -59,6 +59,9 @@ VIR_LOG_INIT("libvir
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/libvirt/libvirt-admin.h b/include/libvirt/libvirt-admin.h
index e414f776e4..0f90ec8cdb 100644
--- a/include/libvirt/libvirt-admin.h
+++ b/include
With style fixes.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 24
1 file changed, 24 insertions(+)
diff --git a/include/libvirt/libvirt-admin.h b/include/libvirt/libvirt-admin.h
index f54aeb0c1d..2bfb45145d 100644
--- a/include/libvirt/libvirt
With style fixes.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-qemu.h | 12
1 file changed, 12 insertions(+)
diff --git a/include/libvirt/libvirt-qemu.h b/include/libvirt/libvirt-qemu.h
index 24bf67998b..838b6e9caf 100644
--- a/include/libvirt/libvirt-qemu.h
+++ b
typedef fixes that are related to appending
*Since* metadata.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain-checkpoint.h | 18 +-
include/libvirt/libvirt-domain-snapshot.h | 24 +-
include/libvirt/libvirt-domain.h| 583 +++-
include/libvirt/libvirt
1 - 100 of 118 matches
Mail list logo
