[libvirt] [PATCH] LXC: update comments of lxcDomainCreateXMLWithFiles() and lxcDomainCreateXML()

2014-06-24 Thread Wangrui (K)
update comments of lxcDomainCreateXMLWithFiles() and lxcDomainCreateXML() Signed-off-by: Yue wenyuan yueweny...@huawei.com Signed-off-by: Wang Rui moon.wang...@huawei.com --- src/lxc/lxc_driver.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git

Re: [libvirt] [PATCH] LXC: update comments of lxcDomainCreateXMLWithFiles() and lxcDomainCreateXML()

2014-06-24 Thread Wangrui (K)
-Original Message- From: Michal Privoznik [mailto:mpriv...@redhat.com] Sent: Tuesday, June 24, 2014 9:38 PM To: Wangrui (K); libvir-list@redhat.com Subject: Re: [libvirt] [PATCH] LXC: update comments of lxcDomainCreateXMLWithFiles() and lxcDomainCreateXML() One does

Re: [libvirt] [PATCH RFC 0/3] allow setting video ram size for graphics

2014-06-13 Thread Wangrui (K)
-Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Thursday, June 12, 2014 4:16 PM To: Wangrui (K) Cc: libvir-list@redhat.com; Zengjunliang; ebl...@redhat.com Subject: Re: [PATCH RFC 0/3] allow setting video ram size for graphics On Do, 2014-06-12 at 07:22

[libvirt] [PATCH RFC 0/3] allow setting video ram size for graphics

2014-06-12 Thread Wangrui (K)
https://bugzilla.redhat.com/show_bug.cgi?id=1076098 Zeng Junliang (3): For vga/cirrus/vmvga/qxl device, qemu supports commandline parameter vgamem_mb to specifie the size of the framebuffer portion of the ram region. As the vram attribute in libvirt is only valid for qxl device in

[libvirt] [PATCH RFC 1/3] qemu: Introduce vgamem attribute for video model

2014-06-12 Thread Wangrui (K)
This patch introduces vgamem attribute for video model, and sets its default value as qemu used. Parse it in two ways accroding to qemu startup parameters supported: -device or -vga. Signed-off-by: Zeng Junliang zengjunli...@huawei.com Signed-off-by: Wang Rui moon.wang...@huawei.com --- For KVM,

[libvirt] [PATCH RFC 2/3] tests: modify test case related to vgamem attribute

2014-06-12 Thread Wangrui (K)
This patch modify test case related to vgamem attribute. Signed-off-by: Zeng Junliang zengjunli...@huawei.com Signed-off-by: Wang Rui moon.wang...@huawei.com --- tests/domainschemadata/domain-parallels-ct-simple.xml| 2 +- tests/domainschemadata/domain-parallels-vm-simple.xml

[libvirt] [PATCH RFC 3/3] docs: add description for vgamem attribute

2014-06-12 Thread Wangrui (K)
Enhance schema and add description for vgamem attribute. Signed-off-by: Zeng Junliang zengjunli...@huawei.com Signed-off-by: Wang Rui moon.wang...@huawei.com --- docs/formatdomain.html.in | 24 ++-- docs/schemas/domaincommon.rng | 5 + 2 files changed, 23

[libvirt] [PATCH] docs: fix a typo in hacking.html.in

2014-06-10 Thread Wangrui (K)
Signed-off-by: Wang Rui moon.wang...@huawei.com --- docs/hacking.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index b2ef85a..9c6dd26 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@ -122,7 +122,7 @@

Re: [libvirt] [PATCH v4] util: new function virTimeLocalOffsetFromUTC

2014-05-28 Thread Wangrui (K)
And don't forget to update comments if localtime_r is removed :) + * This function is threadsafe, but is *not* async signal safe (due to + * localtime_r()). -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Laine Stump

Re: [libvirt] [PATCH 2/3] qemu: Send migrate_cancel when aborting migration

2014-05-22 Thread Wangrui (K)
-Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Jiri Denemark Sent: Thursday, May 22, 2014 7:55 PM To: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/3] qemu: Send migrate_cancel when aborting migration When QEMU

Re: [libvirt] [PATCH] virlog: Add stack trace log when libvirt receives fatal signal

2014-05-21 Thread Wangrui (K)
-Original Message- From: Daniel P. Berrange [mailto:berra...@redhat.com] Sent: Tuesday, May 20, 2014 5:05 PM To: Wangrui (K) Cc: libvir-list@redhat.com; zhouyimin Zhou(Yimin); Yanqiangjun Subject: Re: [PATCH] virlog: Add stack trace log when libvirt receives fatal signal On Tue

Re: [libvirt] [RFC] require for suggestions on support for ivshmem device

2014-05-21 Thread Wangrui (K)
Thank you for reply -Original Message- From: Martin Kletzander [mailto:mklet...@redhat.com] Sent: Tuesday, May 20, 2014 5:18 PM To: Wangrui (K) Cc: libvir-list@redhat.com; Zhangbo (Oscar); Yanqiangjun; Zengjunliang; Moyuxiang; jdene...@redhat.com Subject: Re: [libvirt] [RFC

[libvirt] [PATCH] virlog: Add stack trace log when libvirt receives fatal signal

2014-05-20 Thread Wangrui (K)
An earlier commit(c0c8c1) Dan removed global log buffer feature entirely because of duplicate log messages. An improvement is introduced. That is dumping stack trace instead of log buffer upon libvirt crash. Signed-off-by: Zhou Yimin zhouyi...@huawei.com Signed-off-by: Wang Rui

[libvirt] [RFC] require for suggestions on support for ivshmem device

2014-05-14 Thread Wangrui (K)
Hi, Libvirt does not support ivshmem(Inter-VM Shared Memory) device recently, thus, I would like to know if there's any plan to support it in the future? If not, I would like to contribute a serial of patches to do so. On Jan 28, Wangyufei (James) asked about this question, and Daniel replied

[libvirt] [Question] (python API) setMemoryParameters doesn't support flags CONFIG | LIVE

2014-05-13 Thread Wangrui (K)
Hi, all when I use (python API) setMemoryParameters with flags= VIR_DOMAIN_AFFECT_CONFIG|VIR_DOMAIN_AFFECT_LIVE , an error occurs as follow: (libvirt 1.2.4) libvirt: error : flags 'affect live' and 'affect config' in virDomainGetMemoryParameters are mutually exclusive I check the function

Re: [libvirt] [PATCH] util: refactor virNetlinkCommand to fix several bugs / style problems

2014-05-13 Thread Wangrui (K)
Good improvement especially in coding style from which I learned difference between rc and ret. :) -Original Message- From: Laine Stump [mailto:la...@laine.org] Sent: Tuesday, May 13, 2014 7:52 PM To: libvir-list@redhat.com; Wangrui (K); Yanqiangjun; Zhangbo (Oscar) Subject: [PATCH

Re: [libvirt] [PATCH] network: Defer online of macvtap during qemu migration

2014-05-13 Thread Wangrui (K)
-Original Message- From: sendmail [mailto:justsendmailnothinge...@gmail.com] On Behalf Of Laine Stump Sent: Tuesday, May 13, 2014 10:11 PM To: Matthew Rosato; libvir-list@redhat.com Cc: Wangrui (K) Subject: Re: [libvirt] [PATCH] network: Defer online of macvtap during qemu

[libvirt] [PATCH] util: Fix return type mismatch for nl_recv

2014-05-12 Thread Wangrui (K)
1. As shown in the definition of nl_recv, its return value is of INT type. int nl_recv(struct nl_handle *handle, struct sockaddr_nl *nla, unsigned char **buf, struct ucred **creds) However, in function virNetlinkCommand, it uses an unsigned int param, respbuflen, to receive its

[libvirt] [PATCH 0/2] *** replace error with cleanup in virNetlinkCommand ***

2014-05-12 Thread Wangrui (K)
Zhang Bo (2): util: replace error with cleanup in virNetlinkCommand util: do not set resp to NULL after VIR_FREE src/util/virnetlink.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) -- 1.7.12.4 -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH 1/2] util: replace error with cleanup in virNetlinkCommand

2014-05-12 Thread Wangrui (K)
In funtcion virNetlinkCommand, it uses the word error as the goto out keyword, but it's not an error-handling branch, so, use cleanup instead. Signed-off-by: Zhang Bo oscar.zhan...@huawei.com --- src/util/virnetlink.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[libvirt] [PATCH 2/2] util: do not set resp to NULL after VIR_FREE

2014-05-12 Thread Wangrui (K)
Signed-off-by: Zhang Bo oscar.zhan...@huawei.com --- src/util/virnetlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 4f4dedc..40912f5 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -271,7 +271,6 @@ int

Re: [libvirt] [patch v3 1/2] Add support for migration URI configuration

2014-05-07 Thread Wangrui (K)
I think *cfg* should be unref by virObjectUnref(cfg) . And so does patch 2/2. -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Chen Fan Sent: Wednesday, May 07, 2014 6:12 PM To: libvir-list@redhat.com Subject: [libvirt]

[libvirt] [question]qemu: migrate and destory vm immediately on destination causes libvirt deadlock or segment fault

2014-05-06 Thread Wangrui (K)
Hi everyone, I do ram migration operation in KVM environment(libvirt1.2.4 qemu1.5.1). I encountered libvirtd deadlock or segmentfault when I destroy the migration VM on destination. I got the problem by flowing steps: step 1: migrate VM. step 2: execute virsh destroy [VMName] to destroy the

[libvirt] [PATCH] virnetdev: Fix Memory Leak in virNetDevReplaceMacAddress() and virNetDevRestoreMacAddress()

2014-04-07 Thread Wangrui (K)
function virNetDevRestoreMacAddress() and virNetDevRestoreMacAddress() alloc memory for variable 'path' using virAsprintf(), but they havn't free that memory before returning out. Signed-off-by: Zhang bo oscar.zhan...@huawei.com --- src/util/virnetdev.c | 22 ++ 1 file

[libvirt] question for qemu migrate fail by virDomainMigrate API

2014-03-27 Thread Wangrui (K)
Hi everyone, when I use the API virDomainMigrate to do migration operation in KVM environment(libvirt1.1.0 qemu1.5.1), I encountered with some problems. I found that If the connection to source side is disconnected in the BEGIN phase of a migration, the migration job would fail. Further more,

[libvirt] question for interface in ethernet type and multiple queues in KVM (start VM failed)

2014-03-26 Thread Wangrui (K)
Hi, I use ethernet vif for VM (libvirt 1.1.0 qemu 1.5.1). xml as such interface type='ethernet' script path='' / target dev='tap_mq'/ mac address='52:54:00:19:9e:4e'/ model type='virtio' / driver name='vhost'

Re: [libvirt] [RFC] VM which uses macvtap will not respond ping request when being migrated

2014-03-25 Thread Wangrui (K)
dev='eth4' mode='bridge'/ model type='virtio'/ /interface -Original Message- From: sendmail [mailto:justsendmailnothinge...@gmail.com] On Behalf Of Laine Stump Sent: Saturday, March 22, 2014 2:39 AM To: libvir-list@redhat.com Cc: Wangrui (K); chenliang (T); Zhaoyanbin (A); Michael S

Re: [libvirt] [PATCH] virlog: Modify virLogParseDefaultPriority's comment of return value

2014-03-21 Thread Wangrui (K)
*priority) -- 1.7.12.4 -Original Message- From: Michal Privoznik [mailto:mpriv...@redhat.com] Sent: Thursday, March 20, 2014 10:56 PM To: Wangrui (K); libvir-list@redhat.com Cc: zhouyimin Zhou(Yimin); Yanqiangjun; Zhaoyanbin (A) Subject: Re: [libvirt] [PATCH] virlog: Modify

[libvirt] [RFC] VM which uses macvtap will not respond ping request when being migrated

2014-03-18 Thread Wangrui (K)
A vm which uses macvtap will not respond ping request, when the vm is being migrated. I found that on the destination side the macvtap will send a IPv6 packet at the begin of migration to update the route table in switch, however VM is still on the src. In this case , what can I do to avoid

[libvirt] [PATCH] virlog: add log lock in virLogSetDefaultPriority

2014-03-17 Thread Wangrui (K)
When the global variable virLogDefaultPriority is modified, it will be better to have a lock. Signed-off-by: Zhou Yimin zhouyi...@huawei.com --- src/util/virlog.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/util/virlog.c b/src/util/virlog.c index 68af0f3..ba370e2 100644 ---

[libvirt] [PATCH] virlog: Modify virLogParseDefaultPriority's comment of return value

2014-03-17 Thread Wangrui (K)
virLogParseDefaultPriority's successful return value is the same as virLogSetDefaultPriority's successful return value. So it should be 0 rather than the parsed log level. Signed-off-by: Zhou Yimin zhouyi...@huawei.com --- src/util/virlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt] [PATCH] hotplug:Fix log mistake in qemuMonitorAddNetdev

2014-03-13 Thread Wangrui (K)
From 81de0ce710bad91a2df18247e681b5a83872b8d5 Mon Sep 17 00:00:00 2001 From: Wang Rui moon.wang...@huawei.com Date: Thu, 13 Mar 2014 17:05:03 + Subject: [PATCH] hotplug:Fix log mistake in qemuMonitorAddNetdev VIR_DEBUG in qemuMonitorAddNetdev should print vhostfdSize Signed-off-by: Wang Rui

[libvirt] libvirt xml can't specify USB physical port when passthrough USB device to VM

2014-03-05 Thread Wangrui (K)
Hello, I passthrough a host usb device to a guest with a bus number and device number in the xml to identify the usb device. When I unplug and then plug back into the same USB physical port, the guest identifies the usb device failed. Because on the host ,the usb device number increases. So ,