Re: [libvirt] [PATCH 1/8] Add new API virDomain{Set, Get}BlockIoTune

2011-11-09 Thread Xu He Jie
于 2011年11月10日 13:41, Lei Li 写道: On 11/10/2011 04:43 AM, Eric Blake wrote: On 11/09/2011 01:32 PM, Lei Li wrote: This patch add new pulic API virDomainSetBlockIoTune and virDomainGetBlockIoTune. Signed-off-by: Zhi Yong Wu Signed-off-by: Lei Li --- include/libvirt/libvirt.h.in | 26 + sr

Re: [libvirt] [PATCH] qemu: Fix improper error message for disk detaching

2011-11-08 Thread Xu He Jie
于 2011年11月09日 12:27, Osier Yang 写道: s/virDomainDeviceTypeToString/virDomainDiskDeviceTypeToString/ Report by Xu He Jie --- src/qemu/qemu_driver.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 118197a..cee689b

Re: [libvirt] [PATCH] virsh: Add VSH_OFLAG_EMPTY_OK for attach-disk command

2011-11-08 Thread Xu He Jie
于 2011年11月09日 11:05, Osier Yang 写道: On 11/09/2011 10:34 AM, Xu He Jie wrote: 于 2011年11月09日 07:08, Eric Blake 写道: On 11/08/2011 12:16 AM, Xu He Jie wrote: As the description of removing CDROM media from http://wiki.libvirt.org/page/QEMUSwitchToLibvirt#eject_DEV Hmm. virsh attach-disk --type

Re: [libvirt] [PATCH] virsh: Add VSH_OFLAG_EMPTY_OK for attach-disk command

2011-11-08 Thread Xu He Jie
于 2011年11月09日 07:08, Eric Blake 写道: On 11/08/2011 12:16 AM, Xu He Jie wrote: As the description of removing CDROM media from http://wiki.libvirt.org/page/QEMUSwitchToLibvirt#eject_DEV Hmm. virsh attach-disk --type cdrom --mode readonly myguest "" hdc might look a bit nicer as: vi

[libvirt] [PATCH] virsh: Add VSH_OFLAG_EMPTY_OK for attach-disk command

2011-11-07 Thread Xu He Jie
As the description of removing CDROM media from http://wiki.libvirt.org/page/QEMUSwitchToLibvirt#eject_DEV Add flag 'VSH_OFLAG_EMPTY_OK' to the option 'source' of attach-disk Signed-off-by: Xu He Jie --- tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deleti

Re: [libvirt] [PATCHv6 5/5] blkiotune: add qemu support for blkiotune.device_weight

2011-11-06 Thread Xu He Jie
于 2011年11月04日 02:06, Eric Blake 写道: From: Hu Tao Implement setting/getting per-device blkio weights in qemu, using the cgroups blkio.weight_device tunable. --- v5: did not include this patch v6: split v4 2/2 into two parts; this part covers just the qemu. Rebase to accomodate 'device_weight' na

Re: [libvirt] [PATCH v4] pci address conflict when virtio disk with drive type

2011-10-30 Thread Xu He Jie
于 2011年10月29日 03:46, Eric Blake 写道: On 10/28/2011 03:57 AM, Xu He Jie wrote: Then can't startup qemu, the error message as below: virsh # start test-vm error: Failed to start domain test-vm error: internal error process exited while connecting to monitor: qemu-system-x86_64: -device v

[libvirt] [PATCH v4] pci address conflict when virtio disk with drive type

2011-10-28 Thread Xu He Jie
lloon-pci, in use by virtio-blk-pci qemu-system-x86_64: -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3: Device 'virtio-balloon-pci' could not be initialized So adding check for bus type and address type. Only the address of pci type support by virtio bus. Signed-off-by: Xu H

Re: [libvirt] [PATCH v3] pci address conflict when virtio disk with drive type

2011-10-28 Thread Xu He Jie
于 2011年10月28日 06:28, Eric Blake 写道: On 10/23/2011 05:31 AM, Xu He Jie wrote: When using the xml as below: -- /home/soulxu/data/work-code/qemu-kvm/x86_64-softmmu/qemu-system-x86_64 function='0x0'/> function='0

[libvirt] [PATCH v3] pci address conflict when virtio disk with drive type

2011-10-23 Thread Xu He Jie
86_64: -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3: Device 'virtio-balloon-pci' could not be initialized So adding check for bus type and address type. Only the address of pci type support by virtio bus. Signed-off-by: Xu He Jie --- src/qemu/qemu_command.c | 10

Re: [libvirt] [PATCH v2] pci address conflict when virtio disk with drive type

2011-10-23 Thread Xu He Jie
于 2011年10月20日 10:09, Xu He Jie 写道: > When using the xml as below: > -- > > /home/soulxu/data/work-code/qemu-kvm/x86_64-softmmu/qemu-s

[libvirt] [PATCH v2] pci address conflict when virtio disk with drive type

2011-10-19 Thread Xu He Jie
86_64: -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3: Device 'virtio-balloon-pci' could not be initialized So adding check for bus type and address type. Only the address of pci type support by virtio bus. Signed-off-by: Xu He Jie --- src/qemu/qemu_command.c | 10

Re: [libvirt] [PATCH] pci address conflict when virtio disk with drive type address

2011-10-19 Thread Xu He Jie
于 2011年10月19日 21:55, Eric Blake 写道: On 10/18/2011 11:32 PM, Xu He Jie wrote: Hmm, you are right. domain_conf didn't separate with different layer. So I found another place that in the qemu layer for the fix. The patch as below: Signed-off-by: Xu He Jie --- src/qemu/qemu_command.c

Re: [libvirt] [PATCH] compile: fix undefined reference to gnutls_x509_crt_get_dn with gcc-4.6.1

2011-10-19 Thread Xu He Jie
于 2011年10月19日 21:08, Eric Blake 写道: On 10/18/2011 08:06 PM, Xu He Jie wrote: More likely, the difference is not in gcc, but in ld policy - Ubuntu recently changed policy to no longer allow implicit link dependencies by default (that is, if A links against B, and B links against C, older distros

Re: [libvirt] [PATCH] pci address conflict when virtio disk with drive type address

2011-10-18 Thread Xu He Jie
于 2011年10月18日 22:52, Eric Blake 写道: On 10/18/2011 03:30 AM, Xu He Jie wrote: When using the xml as below: function='0x0'/> - Then can't statup qemu, the error message as below: qemu-system-x86_64: -device virtio-balloon-pci,id=

Re: [libvirt] [PATCH] compile: fix undefined reference to gnutls_x509_crt_get_dn with gcc-4.6.1

2011-10-18 Thread Xu He Jie
于 2011年10月18日 22:45, Eric Blake 写道: On 10/18/2011 02:06 AM, Xu He Jie wrote: From: soulxu When I compile libvirt with gcc-4.6.1 in ubuntu 11.10, got error as below: CCLD libvirtd /usr/bin/ld: ../src/.libs/libvirt_driver_qemu.a(libvirt_driver_qemu_la-qemu_migration.o): undefined reference

[libvirt] [PATCH] pci address conflict when virtio disk with drive type address

2011-10-18 Thread Xu He Jie
0,bus=pci.0,multifunction=on,addr=0x3.0x0: Device 'virtio-balloon-pci' could not be initialized Adding check for bus type and address type. Only the address of pci type support by virtio bus. Signed-off-by: Xu He Jie --- src/conf/domain_conf.c |8 1 files changed, 8 i

[libvirt] [PATCH] compile: fix undefined reference to gnutls_x509_crt_get_dn with gcc-4.6.1

2011-10-18 Thread Xu He Jie
From: soulxu When I compile libvirt with gcc-4.6.1 in ubuntu 11.10, got error as below: CCLD libvirtd /usr/bin/ld: ../src/.libs/libvirt_driver_qemu.a(libvirt_driver_qemu_la-qemu_migration.o): undefined reference to symbol 'gnutls_x509_crt_get_dn@@GNUTLS_1_4' /usr/bin/ld: note: 'gnutls_x509

Re: [libvirt] [PATCH] compile: Add a missing function 'pciDeviceListFind' to libvirt_private.syms

2011-10-17 Thread Xu He Jie
于 2011年10月18日 11:12, Wen Congyang 写道: At 10/18/2011 10:46 AM, Xu He Jie Write: compile error: ../src/.libs/libvirt_driver_qemu.a(libvirt_driver_qemu_la-qemu_hostdev.o): In function `qemuPrepareHostdevPCIDevices': /home/soulxu/data/work-code/libvirt/src/qemu/qemu_hostdev.c:183: unde

[libvirt] [PATCH] compile: Add a missing function 'pciDeviceListFind' to libvirt_private.syms

2011-10-17 Thread Xu He Jie
stFind' ../src/.libs/libvirt_driver_qemu.a(libvirt_driver_qemu_la-qemu_hostdev.o): In function `qemuDomainReAttachHostdevDevices': /home/soulxu/data/work-code/libvirt/src/qemu/qemu_hostdev.c:370: undefined reference to `pciDeviceListFind' Signed-off-by: Xu He Jie --- src/lib

Re: [libvirt] [PATCH] add a default event handle, to passthough the new events come from qemu

2011-10-11 Thread Xu, He Jie
On 2011?10?10? 23:54, shao...@linux.vnet.ibm.com wrote: From: Shaohe Feng Basically, this feature can go along with qemu monitor passthrough. That way, if we use new commands in the monitor that generate new events, we want some way to receive those new events too. In order to test this patc

Re: [libvirt] [PATCH v2 1/4] api: Add public api for 'reset'

2011-09-29 Thread Xu He Jie
Thanks a lot! On 2011年09月29日 20:52, Eric Blake wrote: On 09/29/2011 02:53 AM, Xu He Jie wrote: Add new public api for 'reset'. It can reset domain immediately without any guest shutdown. /** + * virDomainReset: + * @domain: a domain object + * @flags: extra flags for the reboot

Re: [libvirt] [PATCH v2 1/4] api: Add public api for 'reset'

2011-09-29 Thread Xu He Jie
On 2011年09月29日 18:44, Daniel P. Berrange wrote: On Thu, Sep 29, 2011 at 04:53:29PM +0800, Xu He Jie wrote: Add new public api for 'reset'. It can reset domain immediately without any guest shutdown. Signed-off-by: Xu He Jie --- include/libvirt/libvirt.h.in |3 ++ sr

[libvirt] [PATCH v2 3/4] remote: Implement 'reset' for remote driver

2011-09-29 Thread Xu He Jie
Signed-off-by: Xu He Jie --- src/remote/remote_driver.c |1 + src/remote/remote_protocol.x |8 +++- 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 740dd75..83f4f3c 100644 --- a/src/remote/remote_driver.c

[libvirt] [PATCH v2 4/4] virsh: Add 'reset' command for virsh

2011-09-29 Thread Xu He Jie
Signed-off-by: Xu He Jie --- tools/virsh.c | 46 ++ tools/virsh.pod |8 2 files changed, 54 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 807324b..a7d0559 100644 --- a/tools/virsh.c +++ b/tools

[libvirt] [PATCH v2 1/4] api: Add public api for 'reset'

2011-09-29 Thread Xu He Jie
Add new public api for 'reset'. It can reset domain immediately without any guest shutdown. Signed-off-by: Xu He Jie --- include/libvirt/libvirt.h.in |3 ++ src/driver.h |4 +++ src/libvirt.c| 50 +

[libvirt] [PATCH v2 2/4] qemu: Implement 'reset' for qemu driver

2011-09-29 Thread Xu He Jie
Signed-off-by: Xu He Jie --- src/qemu/qemu_driver.c | 48 1 files changed, 48 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ffa8b4c..3f89c62 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu

Re: [libvirt] [PATCH 4/4] virsh: Add 'reset' command for virsh

2011-09-28 Thread Xu He Jie
On 2011年09月28日 22:49, Michal Privoznik wrote: On 28.09.2011 11:06, Xu He Jie wrote: Signed-off-by: Xu He Jie --- tools/virsh.c | 39 +++ 1 files changed, 39 insertions(+), 0 deletions(-) I think this needs to be documented in man-page as well. Michal

Re: [libvirt] [PATCH 1/4] api: Add new public api for 'reset'

2011-09-28 Thread Xu He Jie
On 2011年09月28日 17:46, Daniel Veillard wrote: On Wed, Sep 28, 2011 at 05:03:05PM +0800, Xu He Jie wrote: Add new public api for 'reset'. It can reset domain immediately without any guest shutdown. Signed-off-by: Xu He Jie --- include/libvirt/libvirt.h.in |2 + sr

[libvirt] [PATCH 2/4] qemu: Implement 'reset' for qemu driver

2011-09-28 Thread Xu He Jie
Signed-off-by: Xu He Jie --- src/qemu/qemu_driver.c | 46 ++ 1 files changed, 46 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 0d0bea2..dc719ac 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu

[libvirt] [PATCH 3/4] remote: Implement 'reset' for remote driver

2011-09-28 Thread Xu He Jie
Signed-off-by: Xu He Jie --- src/remote/remote_driver.c |1 + src/remote/remote_protocol.x |7 ++- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 1217d94..372341c 100644 --- a/src/remote/remote_driver.c

[libvirt] [PATCH 4/4] virsh: Add 'reset' command for virsh

2011-09-28 Thread Xu He Jie
Signed-off-by: Xu He Jie --- tools/virsh.c | 39 +++ 1 files changed, 39 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 13be03b..13b10cd 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -3188,6 +3188,44 @@ cmdReboot

[libvirt] [PATCH 1/4] api: Add new public api for 'reset'

2011-09-28 Thread Xu He Jie
Add new public api for 'reset'. It can reset domain immediately without any guest shutdown. Signed-off-by: Xu He Jie --- include/libvirt/libvirt.h.in |2 + src/driver.h |3 ++ src/libvirt.c| 44 +

Re: [libvirt] [PATCH 1/2] qemu: using correct function to reboot guest.

2011-09-21 Thread Xu He Jie
I got that mean. Thanks for your reply! On 2011年09月21日 18:27, Daniel P. Berrange wrote: On Wed, Sep 21, 2011 at 05:53:31PM +0800, x...@linux.vnet.ibm.com wrote: From: Xu He Jie Signed-off-by: Xu He Jie --- src/qemu/qemu_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [libvirt] [PATCH] libvirtd: create run dir when running at non-root user

2011-09-04 Thread Xu He Jie
Thanks again! It will be better next time. :) On 2011年09月02日 10:37, Eric Blake wrote: On 08/28/2011 08:52 PM, x...@linux.vnet.ibm.com wrote: From: Xu He Jie Signed-off-by: Xu He Jie Usually this line goes on the bottom, not the top, of a commit message. When libvirtd is running at non

Re: [libvirt] [PATCH] libvirtd: create run dir when running at non-root user

2011-08-30 Thread Xu He Jie
Hi, Eric This patch is second version, but I forgot adding patch version at mail's title. Should I send this patch with correct title again? :) And thanks for your patch review and reply. 于 2011年08月29日 10:52, x...@linux.vnet.ibm.com 写道: > From: Xu He Jie > > > Signed-off-by: Xu