Re: [PATCH Libvirt 0/4] Support for dirty-limit live migration

2023-10-17 Thread Yong Huang
ping1 On Thu, Oct 12, 2023 at 10:39 AM ~hyman wrote: > In qemu>=8.1, the dirty-limit functionality for live > migration was included. In the live migration > scenario, it implements the force convergence > using the dirty-limit approach, which results in > better reliable read performance. A

Re: [PATCH Libvirt v3 00/10] Support dirty page rate upper limit

2023-09-06 Thread Yong Huang
On Wed, Sep 6, 2023 at 9:16 PM Martin Kletzander wrote: > On Wed, Sep 06, 2023 at 03:27:10AM +, ~hyman wrote: > >Hyman Huang(黄勇) (10): > > qemu_capabilities: Introduce QEMU_CAPS_VCPU_DIRTY_LIMIT capability > > conf: Introduce XML for dirty limit configuration > > libvirt: Add

Re: [PATCH Libvirt v3 02/10] conf: Introduce XML for dirty limit configuration

2023-09-06 Thread Yong Huang
On Wed, Sep 6, 2023 at 7:24 PM Daniel P. Berrangé wrote: > On Wed, Sep 06, 2023 at 06:54:29PM +0800, Yong Huang wrote: > > Thanks Daniel for the comments ! > > > > On Wed, Sep 6, 2023 at 4:48 PM Daniel P. Berrangé > > wrote: > > > > > On Tue, Aug

Re: [PATCH Libvirt v3 02/10] conf: Introduce XML for dirty limit configuration

2023-09-06 Thread Yong Huang
Thanks Daniel for the comments ! On Wed, Sep 6, 2023 at 4:48 PM Daniel P. Berrangé wrote: > On Tue, Aug 01, 2023 at 05:31:12PM +0800, ~hyman wrote: > > From: Hyman Huang(黄勇) > > > > The upper limit (megabyte/s) of the dirty page rate configured > > by the user can be tracked by the XML. To

Re: [PATCH Libvirt v2 00/10] Support dirty page rate upper limit

2023-09-05 Thread Yong Huang
ewhere on my part. > > Would you mind resending the second version again, ideally rebased? > Sure yes, I'll rebase the master and resend in the near future Thanks, Yong > > Thanks, > Martin > > On Mon, Sep 04, 2023 at 09:32:08PM +0800, Yong Huang wrote: > >Ping2

Re: [PATCH Libvirt v2 00/10] Support dirty page rate upper limit

2023-09-04 Thread Yong Huang
Ping2, I'm hoping for comments about the series. Thanks, Yong On Sun, Aug 27, 2023 at 11:11 AM Yong Huang wrote: > Ping1 > > On Tue, Aug 15, 2023 at 9:48 AM Yong Huang wrote: > >> Ping. >> >> On Mon, Aug 7, 2023 at 11:56 PM ~hyman wrote: >> >>>

Re: [PATCH Libvirt v2 00/10] Support dirty page rate upper limit

2023-08-26 Thread Yong Huang
Ping1 On Tue, Aug 15, 2023 at 9:48 AM Yong Huang wrote: > Ping. > > On Mon, Aug 7, 2023 at 11:56 PM ~hyman wrote: > >> Hi, This is the latest version for the series, comparing with version >> 1, there are some key modifications has made inspired and >> suggested

Re: [PATCH Libvirt v2 00/10] Support dirty page rate upper limit

2023-08-14 Thread Yong Huang
Ping. On Mon, Aug 7, 2023 at 11:56 PM ~hyman wrote: > Hi, This is the latest version for the series, comparing with version > 1, there are some key modifications has made inspired and > suggested by Peter, see as follows: > 1. Introduce XML for dirty limit persistent configuration > 2. Merge

Re: [PATCH Libvirt 02/11] libvirt: Add virDomainSetVcpuDirtyLimit API

2023-07-31 Thread Yong Huang
Sorry for the late reply. On Mon, Jul 31, 2023 at 4:11 PM Peter Krempa wrote: > On Tue, Aug 02, 2022 at 22:13:40 +0800, ~hyman wrote: > > From: Hyman Huang(黄勇) > > > > Introduce virDomainSetVcpuDirtyLimit API to set upper limit > > of dirty page rate. > > > > Signed-off-by: Hyman Huang(黄勇) >

Re: [PATCH Libvirt v2 1/3] conf: Add 'virtio_discard' and 'virtio_write_zeroes' attributes

2023-07-20 Thread Yong Huang
Peter Krempa wrote: > On Wed, Jul 19, 2023 at 11:52:45 +0800, Yong Huang wrote: > > On Tue, Jul 18, 2023 at 9:31 PM Peter Krempa wrote: > > > > > On Sun, Jul 16, 2023 at 22:36:21 +0800, ~hyman wrote: > > > > From: Hyman Huang(黄勇) > > > > >

Re: [PATCH Libvirt v2 1/3] conf: Add 'virtio_discard' and 'virtio_write_zeroes' attributes

2023-07-19 Thread Yong Huang
On Tue, Jul 18, 2023 at 9:31 PM Peter Krempa wrote: > On Sun, Jul 16, 2023 at 22:36:21 +0800, ~hyman wrote: > > From: Hyman Huang(黄勇) > > > > Add 'virtio_discard' and 'virtio_write_zeroes' attribute to control > > whether discard and write-zeroes requests are handled by the > > virtio-blk