>
> The series is now pushed without any adjustment from the patch3 followup
> (Peter and I hashed it out over the much faster internal IRC channel -
> mail list delivery is still brutally slow/behind).
>
> Tks -
>
> John
>
>
Thank you, John! Couldn't have done it without your help!
And thanks to
Hi Peter,
Do let me know if there's anything else I can help with on setting up the
VxHS devices for testing.
Thanks,
Ashish
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Thank you!
Do let me know if there's any thing else I can help with on the remaining
VxHS patches.
Regards,
Ashish
On Thu, Sep 21, 2017 at 4:28 PM, John Ferlan <jfer...@redhat.com> wrote:
>
>
> On 09/21/2017 03:57 PM, Ashish Mittal wrote:
> > Passing a NULL value for
Passing a NULL value for the argument secAlias to the function
qemuDomainGetTLSObjects can cause a segmentation fault in
libvirtd.
Fixed two possibile places where we could dereference a NULL secAlias.
Signed-off-by: Ashish Mittal <ashmit...@gmail.com>
---
src/qemu/qemu_hotplug.c | 6 +++
On Thu, Sep 21, 2017 at 12:21 AM, Erik Skultety <eskul...@redhat.com> wrote:
> On Wed, Sep 20, 2017 at 12:19:16PM -0700, ashish mittal wrote:
> > On Wed, Sep 20, 2017 at 6:11 AM, Erik Skultety <eskul...@redhat.com>
> wrote:
> >
> > > On Wed, Sep 20, 2017 a
On Thu, Sep 21, 2017 at 12:58 AM, Peter Krempa <pkre...@redhat.com> wrote:
> On Wed, Sep 20, 2017 at 16:32:45 -0700, ashish mittal wrote:
> > Hi,
> >
> > I have done TLS testing with this patch series and the tests passed fine
> > with the secAlias fix in plac
On Thu, Sep 21, 2017 at 1:35 AM, ashish mittal <ashmit...@gmail.com> wrote:
>
>
> On Thu, Sep 21, 2017 at 12:58 AM, Peter Krempa <pkre...@redhat.com> wrote:
>
>> On Wed, Sep 20, 2017 at 16:32:45 -0700, ashish mittal wrote:
>> > Hi,
>> >
>
ibvirt] 2017-09-20 16:28:36# cat ../../hotplug_disk_2.xml
eb90327c-8302-4725-9e1b-4e85ed4dc253
IMHO, the patches are good to go :)
Thanks,
Ashish
On Tue, Sep 19, 2017 at 6:32 PM, John Ferlan <jfer...@redhat.com> wrote:
> From
On Wed, Sep 20, 2017 at 6:11 AM, Erik Skultety <eskul...@redhat.com> wrote:
> On Wed, Sep 20, 2017 at 05:32:29AM -0700, Ashish Mittal wrote:
> > Passing a NULL value for the argument secAlias to the function
> > qemuDomainGetTLSObjects would cause a segmentation
Passing a NULL value for the argument secAlias to the function
qemuDomainGetTLSObjects would cause a segmentation fault in
libvirtd.
Changed code to not dereference a NULL secAlias.
Signed-off-by: Ashish Mittal <ashmit...@gmail.com>
---
src/qemu/qemu_hotplug.c | 3 ++-
1 file chan
On Wed, Sep 20, 2017 at 12:52 AM, Erik Skultety <eskul...@redhat.com> wrote:
> On Wed, Sep 20, 2017 at 09:03:18AM +0200, Erik Skultety wrote:
> > On Tue, Sep 19, 2017 at 09:58:34PM -0700, Ashish Mittal wrote:
> > > Passing a NULL value for the argument
anged code to not dereference a NULL secAlias.
Signed-off-by: Ashish Mittal <ashmit...@gmail.com>
---
src/qemu/qemu_hotplug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 7dd6e5f..9ecdf0a 100644
--- a/src/qemu/qemu_hot
anged code to not dereference a NULL secAlias.
Signed-off-by: Ashish Mittal <ashmit...@gmail.com>
---
src/qemu/qemu_hotplug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 7dd6e5f..df58ecc 100644
--- a/src/qemu/qemu_hot
iles to both these TLS hot plugged disks from within the
guest without any problems. Will send detailed test logs in a separate
email.
Regards,
Ashish
On Fri, Sep 1, 2017 at 10:09 AM, John Ferlan <jfer...@redhat.com> wrote:
> From: Ashish Mittal <ashish.mit...@veritas.com>
>
bytes (999 kB, 976 KiB) copied, 0.001174 s, 851 MB/s
[root@camshaft ~] 2017-09-18 13:37:14#
Regards,
Ashish
On Fri, Sep 1, 2017 at 10:09 AM, John Ferlan <jfer...@redhat.com> wrote:
> From: Ashish Mittal <ashish.mit...@veritas.com>
>
> Alter qemu command line generation in or
the above adjustments are good to go.
Regards,
Ashish
On Fri, Sep 1, 2017 at 10:09 AM, John Ferlan <jfer...@redhat.com> wrote:
> From: Ashish Mittal <ashish.mit...@veritas.com>
>
> The VxHS block device will only use the newer formatting options and
> avoid the legac
On Wed, Aug 30, 2017 at 8:22 AM, John Ferlan <jfer...@redhat.com> wrote:
>
>
> On 08/29/2017 02:39 AM, Ashish Mittal wrote:
>> Verifies TLS args are auto generated if enabled in qemu.conf
>> Verifies TLS args are not generated if XML specifies tls='no'
>>
Thanks for all the reviews! I will work on each item and get back.
On Tue, Aug 29, 2017 at 4:00 PM, John Ferlan <jfer...@redhat.com> wrote:
>
> Probably need to beef this up a little bit... I can figure something out.
>
> On 08/29/2017 02:39 AM, Ashish Mittal wrote:
>> Sa
:39 -0700, Ashish Mittal wrote:
>> From: Ashish Mittal <ashish.mit...@veritas.com>
>>
>> Sample XML for a VxHS disk:
>>
>>
>>
>>
>>
>>
>>
>>
>> eb90327c-8302-4725-9e1b-4e85ed4dc251
>>
>>
ache=none \
-device virtio-blk-pci,bus=pci.0,addr=0x4,drive=drive-virtio-disk0,\
id=virtio-disk0
Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com>
---
v5 changelog:
(1) The v4 3/3 patch has been split into smaller chunks.
(2) Functionally there are no changes in TLS code yet.
TOD
incorporated.
(3) Patches have been broken into smaller chunks
TODO:
Changes in response to review comments on the TLS functionality are still
pending and will be addressed next.
Ashish Mittal (9):
Add support for Veritas HyperScale (VxHS) block device protocol
Add a test case to verify generation
Add a new TLS X.509 certificate type - "vxhs". This will handle the
creation of a TLS certificate capability for properly configured
VxHS network block device clients.
Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com>
---
v5 changelog:
(1) Fixed the release version for
Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com>
---
tests/virstoragetest.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c
index d83db78..f8444e1 100644
--- a/tests/virstoragetest.c
+++ b/tests/virstoragetest.c
@@ -
Add a test case to verify that if vxhs_tls is disabled in qemu.conf
then adding "tls=yes" in the domain XML generates an error.
Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com>
---
...ml2argv-disk-drive-network-tlsx509-err-vxhs.xml | 34 ++
tests/qe
Verifies TLS args are auto generated if enabled in qemu.conf
Verifies TLS args are not generated if XML specifies tls='no'
Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com>
---
...-disk-drive-network-tlsx509-multidisk-vxhs.args | 43 +
...v-disk-drive-network-t
Sample XML for a VxHS disk:
eb90327c-8302-4725-9e1b-4e85ed4dc251
Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com>
---
v5 changelog:
(1) Rebased to latest master.
(2) Review comments from Peter Krempa on patch v4 1/3 have been addressed
v4 changel
Enable TLS for VxHS disks in qemu.conf and ensure that TLS
arguments are added automatically on the qemu command line.
Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com>
---
...muxml2argv-disk-drive-network-tlsx509-vxhs.args | 30 +++
...emuxml2argv-disk-drive-n
Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com>
---
.../qemuxml2argv-disk-drive-network-vxhs.args | 27 +
.../qemuxml2argv-disk-drive-network-vxhs.xml | 34 ++
tests/qemuxml2argvtest.c | 1 +
3 files chang
Test case verifies that XML is generated correctly for a VxHS disk
having TLS enabled.
Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com>
---
tests/virstoragetest.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c
On Mon, Jul 17, 2017 at 4:50 PM, John Ferlan <jfer...@redhat.com> wrote:
>
>
> On 07/12/2017 06:09 PM, ashish mittal wrote:
>> On Fri, Jun 30, 2017 at 1:29 PM, John Ferlan <jfer...@redhat.com> wrote:
>>>
>>>
>>> On 06/29/2017 10:02 PM, Ash
On Fri, Jun 30, 2017 at 1:29 PM, John Ferlan <jfer...@redhat.com> wrote:
>
>
> On 06/29/2017 10:02 PM, Ashish Mittal wrote:
>> From: Ashish Mittal <ashish.mit...@veritas.com>
>>
>> Add a new TLS X.509 certificate type - "vxhs". This will handl
On Fri, Jun 30, 2017 at 2:21 PM, John Ferlan wrote:
> [...]
>
>>> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>>> index 8e00782..99bc94f 100644
>>> --- a/src/qemu/qemu_command.c
>>> +++ b/src/qemu/qemu_command.c
>>> @@ -931,6 +931,68 @@
On Fri, Jun 30, 2017 at 2:58 PM, ashish mittal <ashmit...@gmail.com> wrote:
> On Fri, Jun 30, 2017 at 2:21 PM, John Ferlan <jfer...@redhat.com> wrote:
>> [...]
>>
>>>> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>>>>
On Fri, Jun 30, 2017 at 2:21 PM, John Ferlan wrote:
> [...]
>
>>> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>>> index 8e00782..99bc94f 100644
>>> --- a/src/qemu/qemu_command.c
>>> +++ b/src/qemu/qemu_command.c
>>> @@ -931,6 +931,68 @@
On Fri, Jun 30, 2017 at 1:29 PM, John Ferlan <jfer...@redhat.com> wrote:
>
>
> On 06/29/2017 10:02 PM, Ashish Mittal wrote:
>> From: Ashish Mittal <ashish.mit...@veritas.com>
>>
>> Add a new TLS X.509 certificate type - "vxhs". This will handl
On Fri, Jun 30, 2017 at 1:07 PM, John Ferlan <jfer...@redhat.com> wrote:
>
>
> On 06/30/2017 11:30 AM, ashish mittal wrote:
>> Hi,
>>
>> Thanks for the review!
>>
>> On Fri, Jun 30, 2017 at 12:41 AM, Peter Krempa <pkre...@redhat.com> wrote:
>&g
Hi,
Thanks for the review!
On Fri, Jun 30, 2017 at 12:41 AM, Peter Krempa <pkre...@redhat.com> wrote:
> On Thu, Jun 29, 2017 at 19:02:38 -0700, Ashish Mittal wrote:
>> From: Ashish Mittal <ashish.mit...@veritas.com>
>>
>> QEMU changes for VxHS (including
From: Ashish Mittal <ashish.mit...@veritas.com>
The following describes the behavior of TLS for VxHS block device:
(1) Two new options have been added in /etc/libvirt/qemu.conf
to control TLS behavior with VxHS block devices
"vxhs_tls" and "vxhs_tls_x509_cert_dir&qu
From: Ashish Mittal <ashish.mit...@veritas.com>
QEMU changes for VxHS (including TLS support) are already upstream.
This series of patches adds support for VxHS block devices in libvirt.
Patch 1 adds the base functionality for supporting VxHS protocol.
Patch 2 adds two new configuration o
From: Ashish Mittal <ashish.mit...@veritas.com>
Sample XML for a VxHS disk:
eb90327c-8302-4725-9e1b-4e85ed4dc251
Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com>
---
v2 changelog:
(1) Added code for JSON parsing of a VxHS vdisk.
(2) Add
From: Ashish Mittal <ashish.mit...@veritas.com>
Add a new TLS X.509 certificate type - "vxhs". This will handle the
creation of a TLS certificate capability for properly configured
VxHS network block device clients.
Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com>
-
On Tue, Apr 25, 2017 at 8:22 PM, ashish mittal <ashmit...@gmail.com> wrote:
> On Mon, Apr 17, 2017 at 9:19 AM, John Ferlan <jfer...@redhat.com> wrote:
>>
>>
>> On 04/14/2017 07:26 PM, ashish mittal wrote:
>>> Looking at the code, I suspect significant cha
On Mon, Apr 17, 2017 at 9:19 AM, John Ferlan <jfer...@redhat.com> wrote:
>
>
> On 04/14/2017 07:26 PM, ashish mittal wrote:
>> Looking at the code, I suspect significant changes will be needed to
>> support passing TLS arguments for disk devices. Here's what I have
On Mon, Apr 24, 2017 at 2:10 PM, ashish mittal <ashmit...@gmail.com> wrote:
> On Tue, Apr 11, 2017 at 3:47 PM, John Ferlan <jfer...@redhat.com> wrote:
>>
>>
>> On 04/10/2017 07:32 PM, ashish mittal wrote:
>>> Hi,
>>>
>>> I'm tryi
On Tue, Apr 11, 2017 at 3:47 PM, John Ferlan <jfer...@redhat.com> wrote:
>
>
> On 04/10/2017 07:32 PM, ashish mittal wrote:
>> Hi,
>>
>> I'm trying to figure out what changes are needed in the libvirt vxhs
>> patch to support passing TLS X509 argumen
Thanks!
On Mon, Apr 17, 2017 at 9:19 AM, John Ferlan <jfer...@redhat.com> wrote:
>
>
> On 04/14/2017 07:26 PM, ashish mittal wrote:
>> Looking at the code, I suspect significant changes will be needed to
>> support passing TLS arguments for disk devices. Here
OR ---
struct _qemuDomainDiskPrivate {
}
Given that adding TLS support for VxHS (and disk devices in general)
will not be trivial, I want to check if this can be taken up at a
later time?
Thanks,
Ashish
On Tue, Apr 11, 2017 at 4:26 PM, ashish mittal <ashmit...@gmail.com> wrote:
> Thanks f
the qemuBuildTLSx509CommandLine(), but got confused when I did not
find that...
On Tue, Apr 11, 2017 at 3:47 PM, John Ferlan <jfer...@redhat.com> wrote:
>
>
> On 04/10/2017 07:32 PM, ashish mittal wrote:
>> Hi,
>>
>> I'm trying to figure out what changes are needed in the
Hi,
I'm trying to figure out what changes are needed in the libvirt vxhs
patch to support passing TLS X509 arguments to qemu, similar to the
following -
Sample QEMU command line passing TLS credentials to the VxHS block
device (run in secure mode):
./qemu-io --object
Thanks for the review!
My inputs on some of the comments -
On Wed, Jan 25, 2017 at 7:59 AM, John Ferlan <jfer...@redhat.com> wrote:
>
>
> On 01/19/2017 09:21 PM, Ashish Mittal wrote:
>> Sample XML for a vxhs vdisk is as follows:
>>
>>
>>
>>
Sample XML for a vxhs vdisk is as follows:
eb90327c-8302-4725-9e1b-4e85ed4dc251
Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com>
---
v2 changelog:
(1) Added code for JSON parsing of a VxHS vdisk.
(2) Added test case to verify JSON parsing.
(3) Added m
On Mon, Jan 16, 2017 at 1:10 AM, Daniel P. Berrange wrote:
> On Sat, Jan 14, 2017 at 10:31:05AM -0500, John Ferlan wrote:
>> [...]
>>
>> >> diff --git
>> >> a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args
>> >>
On Mon, Jan 16, 2017 at 5:48 AM, John Ferlan wrote:
>
>
> On 01/16/2017 04:07 AM, Peter Krempa wrote:
>> On Sat, Jan 14, 2017 at 10:31:05 -0500, John Ferlan wrote:
>>> [...]
>>>
> diff --git
> a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args
>
Sample XML for a vxhs vdisk is as follows:
eb90327c-8302-4725-9e1b-4e85ed4dc251
Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com>
---
v2 changelog:
(1) Added code for JSON parsing of a VxHS vdisk.
(2) Added test case to verify JSON parsing.
(3) Added m
On Wed, Jan 4, 2017 at 7:00 AM, John Ferlan wrote:
>
> [...]
>
We don't anticipate a need for this.
> 4. There's no VxHS Storage Pool support in this patch (OK actually an
> additional set of patches in order to support). That would be expected
>
On Mon, Dec 19, 2016 at 4:13 PM, John Ferlan <jfer...@redhat.com> wrote:
>
>
> On 12/16/2016 10:26 PM, ashish mittal wrote:
>> Hi John,
>>
>> Thanks for the review and your comments. Sorry about the delay in
>> reply. Our qemu patch has been undergoing
;
> $SUBJ
>
> s/Change to support/Add support for
>
> s/ with qemu-kvm//
>
> On 11/12/2016 01:19 AM, Ashish Mittal wrote:
>> Sample XML for a vxhs vdisk is as follows:
>>
>>
>>
>>
>>
>>
>>
>>
>>
Sample XML for a vxhs vdisk is as follows:
eb90327c-8302-4725-9e1b-4e85ed4dc251
Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com>
---
docs/formatdomain.html.in | 12 ++--
docs/schemas/domaincommon.rng
>From 9036f749f12d3bf4bf08e7e55b6d98109dd5e5c0 Mon Sep 17 00:00:00 2001
From: Ashish Mittal <ashish.mit...@veritas.com>
Date: Mon, 18 Jul 2016 16:21:37 -0700
Subject: [PATCH] Changes to support Veritas HyperScale (VxHS) block device
protocol with qemu-kvm.
Changes to support Veritas H
05 AM, "Daniel P. Berrange" <berra...@redhat.com> wrote:
>On Wed, Jun 08, 2016 at 02:55:24PM +, Ashish Mittal wrote:
>> Thanks Daniel!
>>
>> I also sent a path on top of libvirt master using "git send-email" as
>> directed on libvirt.org. Tha
if you so suggest.
Thanks,
Ashish
On 6/8/16, 7:32 AM, "Daniel P. Berrange" <berra...@redhat.com> wrote:
>On Tue, Jun 07, 2016 at 08:54:56PM +, Ashish Mittal wrote:
>> Hi,
>>
>> This is a patch review request in response to the following bugzilla:
>>
Hi,
This is a patch review request in response to the following bugzilla:
Bug 1341866 RFE: Request to upstream libvirt dependencies for qemu
based network block driver from Veritas
(1) This patch is required to enable Veritas OpenFlame functionality on RedHat
OSP8 platform.
(2) Patch
62 matches
Mail list logo