Re: [libvirt] [PATCH v2 RESEND 00/17] Introduce RDT memory bandwidth allocation support

2018-08-13 Thread bing.niu
On 2018年08月14日 02:33, John Ferlan wrote: On 07/30/2018 11:54 PM, bing.niu wrote: On 2018年07月31日 06:14, John Ferlan wrote: On 07/29/2018 11:12 PM, bing@intel.com wrote: From: Bing Niu This series is to introduce RDT memory bandwidth allocation support by extending current

Re: [libvirt] [PATCH v2 RESEND 00/17] Introduce RDT memory bandwidth allocation support

2018-07-30 Thread bing.niu
On 2018年07月31日 06:14, John Ferlan wrote: On 07/29/2018 11:12 PM, bing@intel.com wrote: From: Bing Niu This series is to introduce RDT memory bandwidth allocation support by extending current virresctrl implementation. [] Bing Niu (17): util: Rename some functions of

Re: [libvirt] [PATCH v2 RESEND 07/17] util: Add MBA schemata parse and format methods

2018-07-30 Thread bing.niu
On 2018年07月31日 06:09, John Ferlan wrote: On 07/29/2018 11:12 PM, bing@intel.com wrote: From: Bing Niu Introduce virResctrlAllocMemoryBandwidthFormat and virResctrlAllocParseMemoryBandwidthLine which will format and parse an entry in the schemata file for MBA. Signed-off-by: Bing Niu

Re: [libvirt] [PATCH 7/9] conf: Refactor virDomainCachetuneDefParse

2018-07-27 Thread bing.niu
On 2018年07月28日 00:58, John Ferlan wrote: [...] Secondary to that you've added a new error related to identical vcpus in the parsing logic. Unfortunately that could make a domain disappear on a libvirtd restart if for some reason it was already defined in that manner. If there's a parsing

Re: [libvirt] [PATCH 9/9] conf: Add memory bandwidth allocation capability of host

2018-07-26 Thread bing.niu
On 2018年07月27日 05:04, John Ferlan wrote: On 07/18/2018 03:57 AM, bing@intel.com wrote: From: Bing Niu Add new XML section to report host's memory bandwidth allocation capability. The format as below example: . granularity granularity

Re: [libvirt] [PATCH 8/9] conf: Introduce cputune/memorytune to support memory bandwidth allocation

2018-07-26 Thread bing.niu
On 2018年07月27日 04:36, John Ferlan wrote: subj: Add support for memorytune XML processing for resctrl MBA OK! On 07/18/2018 03:57 AM, bing@intel.com wrote: From: Bing Niu Introduce a new section memorytune to support memory bandwidth allocation. This is consistent with existing

Re: [libvirt] [PATCH 7/9] conf: Refactor virDomainCachetuneDefParse

2018-07-26 Thread bing.niu
On 2018年07月27日 01:48, John Ferlan wrote: On 07/18/2018 03:57 AM, bing@intel.com wrote: From: Bing Niu Refactoring virDomainCachetuneDefParse, extracting vcpus extracting, overlapping detecting and new resctrl allocation creating logic. Those two logic is common among different

Re: [libvirt] [PATCH 6/9] conf: Rename cachetune to restune

2018-07-26 Thread bing.niu
On 2018年07月27日 00:32, John Ferlan wrote: On 07/18/2018 03:57 AM, bing@intel.com wrote: From: Bing Niu Resctrl not only supports cache tuning, but also memory bandwidth tuning. Renaming cachetune to restune(resource tuning) to reflect that. With restune, all allocation for different

Re: [libvirt] [PATCH 5/9] util: Add MBA allocation to virresctrl

2018-07-26 Thread bing.niu
On 2018年07月26日 06:37, John Ferlan wrote: On 07/18/2018 03:57 AM, bing@intel.com wrote: From: Bing Niu Add memory bandwidth allocation support to virresctrl class. Introducing virResctrlAllocMemBW which is used for allocating memory bandwidth. Following virResctrlAllocPerType, it also

Re: [libvirt] [PATCH 4/9] util: Add MBA capability information query to resctrl

2018-07-25 Thread bing.niu
On 2018年07月26日 06:31, John Ferlan wrote: On 07/25/2018 12:28 AM, bing.niu wrote: On 2018年07月25日 06:08, John Ferlan wrote: [...] + * fatal in this case (errors out in next condition) - the + * kernel interface might've changed too much or something else

Re: [libvirt] [PATCH 4/9] util: Add MBA capability information query to resctrl

2018-07-24 Thread bing.niu
On 2018年07月25日 06:08, John Ferlan wrote: On 07/18/2018 03:57 AM, bing@intel.com wrote: From: Bing Niu Introducing virResctrlInfoMemBW for the information memory bandwidth allocation information. Those information is used for memory bandwidth allocating. Last sentence is duplicitous.

Re: [libvirt] [PATCH 3/9] util: Refactor virResctrlAllocFormat of virresctrl

2018-07-24 Thread bing.niu
On 2018年07月25日 06:03, John Ferlan wrote: On 07/18/2018 03:57 AM, bing@intel.com wrote: From: Bing Niu Refactor virResctrlAllocFormat so that it is easy to support other resource allocation technologies. Signed-off-by: Bing Niu --- src/util/virresctrl.c | 43

Re: [libvirt] [PATCH 2/9] util: Refactor virResctrlGetInfo in virresctrl

2018-07-24 Thread bing.niu
On 2018年07月25日 06:02, John Ferlan wrote: On 07/18/2018 03:57 AM, bing@intel.com wrote: From: Bing Niu Separate resctrl common information parts from CAT specific parts, so that common information parts can be reused among different resource allocation technologies. Signed-off-by:

Re: [libvirt] [RFCv2 PATCH 4/5] conf: Introduce cputune/memorytune to support memory bandwidth allocation

2018-07-06 Thread bing.niu
On 2018年06月30日 06:47, John Ferlan wrote: On 06/15/2018 05:29 AM, bing@intel.com wrote: From: Bing Niu Introduce a new section memorytune to support memory bandwidth allocation. This is consistent with existing cachetune . As the example below:

Re: [libvirt] [RFCv2 PATCH 2/5] util: Add memory bandwidth support to resctrl

2018-07-06 Thread bing.niu
On 2018年06月30日 06:39, John Ferlan wrote: On 06/15/2018 05:29 AM, bing@intel.com wrote: From: Bing Niu Add memory bandwidth allocation support basing on existing s/basing/based Will fix. virresctrl implementation. Two new structures virResctrlInfoMB ^^ "cache"

Re: [libvirt] [RFCv2 PATCH 1/5] util: Rename and packing parts of virresctrl

2018-07-06 Thread bing.niu
On 2018年06月30日 06:36, John Ferlan wrote: On 06/15/2018 05:29 AM, bing@intel.com wrote: From: Bing Niu Renaming some functions and packing some CAT logic into functions Try to do one "thing" per patch - the "and" gives it away... Thus one patch could rename various functions and

Re: [libvirt] [RFCv2 PATCH 3/5] conf: rename cachetune to restune

2018-07-06 Thread bing.niu
On 2018年07月06日 06:40, John Ferlan wrote: On 07/03/2018 12:10 AM, bing.niu wrote: Hi John, Thanks for reviewing! Since major questions are from this thread, so I think we can start from this. On 2018年06月30日 06:47, John Ferlan wrote: On 06/15/2018 05:29 AM, bing@intel.com wrote: From

Re: [libvirt] [RFCv2 PATCH 3/5] conf: rename cachetune to restune

2018-07-02 Thread bing.niu
Hi John, Thanks for reviewing! Since major questions are from this thread, so I think we can start from this. On 2018年06月30日 06:47, John Ferlan wrote: On 06/15/2018 05:29 AM, bing@intel.com wrote: From: Bing Niu resctrl not only supports cache tuning, but also memory bandwidth

Re: [libvirt] [RFC PATCH 0/2] Introduce RDT memory bandwidth allocation support

2018-06-09 Thread bing.niu
On 2018年06月08日 21:00, Pavel Hrdina wrote: On Wed, Jun 06, 2018 at 03:46:37PM +0800, bing.niu wrote: Hi Pavel, On 2018年06月06日 13:56, bing.niu wrote: Then there is the domain XML, for CAT we use this:    ...    ...       ...       ... so

Re: [libvirt] [RFC PATCH 0/2] Introduce RDT memory bandwidth allocation support

2018-06-06 Thread bing.niu
Hi Pavel, On 2018年06月06日 13:56, bing.niu wrote: Then there is the domain XML, for CAT we use this:    ...    ...       ...       ... so the possible domain XML could look like

Re: [libvirt] [RFC PATCH 0/2] Introduce RDT memory bandwidth allocation support

2018-06-05 Thread bing.niu
Hi Pavel, Thanks for your valuable inputs here. please see my respond. On 2018年06月05日 20:11, Pavel Hrdina wrote: On Tue, May 29, 2018 at 06:58:01PM +0800, bing@intel.com wrote: From: Bing Niu This series is to introduce RDT memory bandwidth allocation support by extending current

Re: [libvirt] [RFC PATCH 2/2] conf: Extend cputune/cachetune to support memory bandwidth allocation

2018-06-03 Thread bing.niu
Hi Jano, Thanks for review, please see my response. On 2018年06月02日 22:54, Ján Tomko wrote: On Tue, May 29, 2018 at 06:58:03PM +0800, bing@intel.com wrote: From: Bing Niu Extend current cachetune section to support memory bandwidth allocation. Add a new cachetune element llc for memory

Re: [libvirt] [RFC PATCH 1/2] util: Add memory bandwidth support to resctrl

2018-06-03 Thread bing.niu
Hi Jano, Thanks a lot for the review! please see my reply below. On 2018年06月02日 22:50, Ján Tomko wrote: On Tue, May 29, 2018 at 06:58:02PM +0800, bing@intel.com wrote: From: Bing Niu Add memory bandwidth allocation support basing on existing virresctrl implementation. Two new structures

Re: [libvirt] [RFC PATCH 0/2] Introduce RDT memory bandwidth allocation support

2018-06-02 Thread bing.niu
ping for this series. thanks a lot bing On 2018年05月29日 18:58, bing@intel.com wrote: From: Bing Niu This series is to introduce RDT memory bandwidth allocation support by extending current virresctrl implementation. The Memory Bandwidth Allocation (MBA) feature provides indirect and