Re: [libvirt] [PATCH] Rename VIR_DOMAIN_PAUSED_GUEST_PANICKED to VIR_DOMAIN_PAUSED_CRASHED

2013-07-30 Thread chenfan
On Mon, 2013-07-29 at 17:56 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The VIR_DOMAIN_PAUSED_GUEST_PANICKED constant is badly named, leaking the QEMU event name. Elsewhere in the API we use 'CRASHED' rather than 'PANICKED', and the addition of 'GUEST' is

Re: [libvirt] [PATCH] Remove VIR_DOMAIN_SHUTDOWN_CRASHED from public API

2013-07-30 Thread chenfan
On Mon, 2013-07-29 at 17:48 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The VIR_DOMAIN_SHUTDOWN_CRASHED state constant does not appear to be used in the QEMU code anyway. It also doesn't make much (any) sense, since the 'shutdown' state is a transient state

Re: [libvirt] [PATCH v7 0/6] libvirt supports Guest Panicked

2013-06-24 Thread chenfan
On Fri, 2013-06-14 at 18:14 +0800, Chen Fan wrote: Changes: v6-v7: implement the rename-restart behavior. v5-v6: Refactor the patches, and fix the incorrect indentation and name. v4-v5: 1. fix the incorrect indentation and explanation (of some reasons). v3-v4: 1.

Re: [libvirt] [PATCH v7 0/6] libvirt supports Guest Panicked

2013-06-20 Thread chenfan
On Fri, 2013-06-14 at 18:14 +0800, Chen Fan wrote: Changes: v6-v7: implement the rename-restart behavior. v5-v6: Refactor the patches, and fix the incorrect indentation and name. v4-v5: 1. fix the incorrect indentation and explanation (of some reasons). v3-v4: 1.

Re: [libvirt] [PATCH v4 1/5] libvirt: Define domain crash event types

2013-06-05 Thread chenfan
On Wed, 2013-06-05 at 10:49 +0200, Daniel Hansel wrote: Applied and tested successfully on s390x platform (as expected by me). Eric mentioned already the few points that should be corrected (indentation of comments). It's right. Mit freundlichen Grüßen / Kind regards Daniel Hansel

Re: [libvirt] [PATCH v5 5/5] qemu: Implement the oncrash events in processWatchdogEvent

2013-06-05 Thread chenfan
Thx for your detailed reviewer, I will make correction as you pointed out. On Wed, 2013-06-05 at 16:54 -0600, Eric Blake wrote: On 06/05/2013 03:55 AM, Chen Fan wrote: Through the watchdog actions, we can implement the docoredump func, we rewrite the processWatchdogEvent function to serval

Re: [libvirt] [PATCH] libvirt supports Guest Panicked

2013-05-28 Thread chenfan
On Mon, 2013-05-27 at 14:28 +0200, Viktor Mihajlovski wrote: On 05/27/2013 10:41 AM, Chen Fan wrote: From: chenfan chen.fan.f...@cn.fujitsu.com @@ -3185,6 +3194,9 @@ int qemuMonitorVMStatusToPausedReason(const char *status) case QEMU_MONITOR_VM_STATUS_WATCHDOG: return