Re: [libvirt] [PATCH v3 0/4] util: Fixing libvirt errors on cavium/thunder-nicvf

had to ping me so > long for this. > > Thank you Michal for accepting this. > > On Wed, 23 Jan 2019 at 10:29, Michal Privoznik wrote: >> >> On 1/22/19 8:26 PM, dann frazier wrote: >> > Following up on my offer to take the baton[*], here's a v3 of this

[libvirt] [PATCH v3 1/4] util: fixing wrong assumption that PF has to have netdev assigned

suggested by Michal Privoznik ] Signed-off-by: dann frazier --- src/util/virnetdev.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 2111b3ada9..82823c0dfc 100644 --- a/src/util/virnetdev.c +++ b/src/util

[libvirt] [PATCH v3 2/4] util: Code simplification

From: Radoslaw Biernacki Removing redundant sections of the code Signed-off-by: Radoslaw Biernacki [ dannf: Add missing free of *pfname in error path and use proper < 0 comparison when checking return for errors, both suggested by Michal Privoznik ] Signed-off-by: dann frazier ---

[libvirt] [PATCH v3 4/4] util: Fixing invalid error checking from virPCIGetNetname()

) Signed-off-by: Radoslaw Biernacki Reviewed-by: Michal Privoznik Signed-off-by: dann frazier --- src/util/virhostdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 41d4e8d936..880ca083d4 100644 --- a/src/util

[libvirt] [PATCH v3 0/4] util: Fixing libvirt errors on cavium/thunder-nicvf

Following up on my offer to take the baton[*], here's a v3 of this series that should address the provided feedback provided for Radoslaw's v2. ThunderX is Cavium SoC. This platform contain SRIOV NIC. Unlike other commonly known network devices it does not have VF functionality duplicated in its P

[libvirt] [PATCH v3 3/4] util: Fix for NULL dereference

with "net" and "def->sounds[i]" with "sound") Fixes: c7fc151eec7 (qemu: assign virtio devices to PCIe slot when appropriate) Signed-off-by: Radoslaw Biernacki Reviewed-by: Michal Privoznik Signed-off-by: dann frazier --- src/qemu/qemu_domain_address.c |

Re: [libvirt] [PATCH v2 0/4] util: Fixing libvirt errors on cavium/thunder-nicvf

On Wed, Dec 12, 2018 at 12:23 PM dann frazier wrote: > > On Sat, Nov 17, 2018 at 1:17 PM Radoslaw Biernacki > wrote: > > > > ThunderX is Cavium SoC. This platform contain SRIOV NIC. > > Unlike other commonly known network devices it does not have VF > > funct

Re: [libvirt] [PATCH v2 0/4] util: Fixing libvirt errors on cavium/thunder-nicvf

On Sat, Nov 17, 2018 at 1:17 PM Radoslaw Biernacki wrote: > > ThunderX is Cavium SoC. This platform contain SRIOV NIC. > Unlike other commonly known network devices it does not have VF functionality > duplicated in its PF. PF is purely management device (on HW level). > > This creates several prob

[libvirt] [PATCH v3 0/2] qemu: Add AAVMF32 to the list of known UEFIs

Changes since v2: * Include updates to qemu.conf * Update tests for parity w/ AAVMF * Drop reference to 'experimental' in commit message Changes since v1: * Add a virt-aa-helper-test case. dann frazier (2): qemu: Add AAVMF32 to the list of known UEFIs virt-aa-helper-test: Ad

[libvirt] [PATCH v3 2/2] virt-aa-helper-test: Add test for aarch32 UEFI image path

Signed-off-by: dann frazier --- tests/virt-aa-helper-test | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/virt-aa-helper-test b/tests/virt-aa-helper-test index 51072f622c..0599046408 100755 --- a/tests/virt-aa-helper-test +++ b/tests/virt-aa-helper-test @@ -308,6 +308,7 @@ testme &q

[libvirt] [PATCH v3 1/2] qemu: Add AAVMF32 to the list of known UEFIs

Add a path for UEFI VMs for AArch32 VMs, based on the path Debian is using. libvirt is the de facto canonical location for defining where distros should place these firmware images, so let's define this path here to try and minimize distro fragmentation. --- src/qemu/qemu.conf

Re: [libvirt] [PATCH 1/2] qemu: Add AAVMF32 to the list of known UEFIs

On Mon, Jul 10, 2017 at 12:23 PM, John Ferlan wrote: > > > On 06/28/2017 12:02 PM, dann frazier wrote: >> Add a path for UEFI VMs for AArch32 VMs. This is the path Debian is >> currently using in experimental. libvirt is the de facto canonical > > "experimenta

[libvirt] [PATCH 1/2] qemu: Add AAVMF32 to the list of known UEFIs

Add a path for UEFI VMs for AArch32 VMs. This is the path Debian is currently using in experimental. libvirt is the de facto canonical location for where distros should place these firmware images, so let's define this path here to try and minimize distro fragmentation. --- src/qemu/qemu_conf.c |

[libvirt] [PATCH 2/2] virt-aa-helper-test: Add test for aarch32 UEFI image path

Signed-off-by: dann frazier --- tests/virt-aa-helper-test | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/virt-aa-helper-test b/tests/virt-aa-helper-test index 51072f622c..0599046408 100755 --- a/tests/virt-aa-helper-test +++ b/tests/virt-aa-helper-test @@ -308,6 +308,7 @@ testme &q

[libvirt] [PATCH 0/2] qemu: Add AAVMF32 to the list of known UEFIs

v2: Add a virt-aa-helper-test case. dann frazier (2): qemu: Add AAVMF32 to the list of known UEFIs virt-aa-helper-test: Add test for aarch32 UEFI image path src/qemu/qemu_conf.c | 12 tests/virt-aa-helper-test | 1 + 2 files changed, 9 insertions(+), 4 deletions

Re: [libvirt] [PATCH] qemu: Add AAVMF32 to the list of known UEFIs

-dann > [1]: https://www.redhat.com/archives/libvir-list/2017-May/msg00474.html > > > > On Wed, Jun 7, 2017 at 12:06 PM, dann frazier > wrote: >> >> Add a path for UEFI VMs for AArch32 VMs. This is the path Debian is >> currently >> using in experimental. li

[libvirt] [PATCH] qemu: Add AAVMF32 to the list of known UEFIs

Add a path for UEFI VMs for AArch32 VMs. This is the path Debian is currently using in experimental. libvirt is the de facto canonical location for where distros should place these firmware images, so let's define this path here to try and minimize distro fragmentation. --- src/qemu/qemu_conf.c |