[libvirt] [PATCH 2/2] Fix monitor ref counting when adding event handle

2010-05-12 Thread jdenemar
From: Jiri Denemark jdene...@redhat.com When closing a monitor using qemuMonitorClose(), we are aware of the possibility the monitor is still being used somewhere: /* NB: ordinarily one might immediately set mon-watch to -1 * and mon-fd to -1, but there may be a callback active *

[libvirt] [PATCH 1/2] Remove watches before calling REMOTE_PROC_CLOSE

2010-05-12 Thread jdenemar
From: Jiri Denemark jdene...@redhat.com First calling REMOTE_PROC_CLOSE and then removing watches might lead to a hang as HANGUP event can be triggered before the watches are actually removed but after virConnectPtr is already freed. As a result of that remoteDomainEventFired() would try to lock

[libvirt] [PATCH] Fix NULL dereference in remoteDomainMigratePrepare2

2010-05-12 Thread jdenemar
From: Jiri Denemark jdene...@redhat.com --- src/remote/remote_driver.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 990bfce..c62e3d6 100644 --- a/src/remote/remote_driver.c +++

[libvirt] [PATCH] Don't wipe generated iface target in active domains

2010-05-04 Thread jdenemar
From: Jiri Denemark jdene...@redhat.com Wipe generated interface target only when reading configuration of inactive domains. --- src/conf/domain_conf.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[libvirt] [PATCH 1/3] lxc: Use virDomainFindByUUID for domain lookup

2010-05-03 Thread jdenemar
From: Jiri Denemark jdene...@redhat.com Consistently use virDomainFindByUUID instead of virDomainFindByID and virDomainFindByName and report VIR_ERR_NO_DOMAIN when domain cannot be found. --- src/lxc/lxc_driver.c | 81 ++ 1 files changed, 55

[libvirt] [PATCH 3/3] lxc: Check domain is active/inactive as required by operation

2010-05-03 Thread jdenemar
From: Jiri Denemark jdene...@redhat.com Report VIR_ERR_OPERATION_INVALID when operation which requires running domain is called on inactive domain and vice versa. --- src/lxc/lxc_driver.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git

[libvirt] [PATCH 2/3] lxc: Make SetMemory work for active domains only

2010-05-03 Thread jdenemar
From: Jiri Denemark jdene...@redhat.com --- src/lxc/lxc_driver.c | 39 +-- 1 files changed, 21 insertions(+), 18 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index f118b7d..6884fea 100644 --- a/src/lxc/lxc_driver.c +++

[libvirt] [PATCH] Report all errors in SELinuxRestoreSecurityFileLabel

2010-04-30 Thread jdenemar
From: Jiri Denemark jdene...@redhat.com --- src/security/security_selinux.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 3e20475..1aabb20 100644 --- a/src/security/security_selinux.c +++

[libvirt] [PATCH] Fix build with DEBUG_RAW_IO=1

2010-04-27 Thread jdenemar
From: Jiri Denemark jdene...@redhat.com --- src/qemu/qemu_monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) At the top of qemu_monitor.c the following lines can be seen: #define DEBUG_IO 0 #define DEBUG_RAW_IO 0 diff --git a/src/qemu/qemu_monitor.c

[libvirt] [PATCH] Ignore qemu STOP event when stopping CPUs

2010-04-27 Thread jdenemar
From: Jiri Denemark jdene...@redhat.com With JSON qemu monitor, we get a STOP event from qemu whenever qemu stops guests CPUs. The downside of it is that vm-state is changed to PAUSED and a new generic paused event is send to applications. However, when we ask qemu to stop the CPUs we are not