Re: [libvirt] [PATCH v2] libvirt: support block device storage typein virshParseSnapshotDiskspec

2019-07-09 Thread liu.dayu
>> --->> Patch v1:>> >> https://www.redhat.com/archives/libvir-list/2019-June/msg01248.html>> >> >> Changes in v2:>> - Adding a "stype" field for the --diskspec string which >> will indicate a "file" or "block" storage type.>> I'm a little late for >> bike-shedding, but could we have supported

Re: [libvirt] [PATCH] libvirt: support block device storage type invirshParseSnapshotDiskspec

2019-06-26 Thread liu.dayu
> virsh has to be able to work remotely so this code will definitely not > be acceptable here. > > I think we can only go with adding a "type" field for the diskspec > string which will be either "file" or "block" and do this in that case. > e.g. > --diskspec vda,snapshot=external,driver=qcow2,type