Re: [libvirt] [PATCH] Make saving domain XML more robust

2011-10-12 Thread lvroyce
tested-by: Royce Lv Patch works as expected.Use setmaxmem cmd,tested cases of set mem success ,writing tmp config file failure and rename failure.old xml file reserves in case of failure so still can be used,and tmp config file cleared leaving no trash to xml folder. -- libvir-list mailing

Re: [libvirt] [PATCH] snapshot: use correct qmp monitor command

2011-10-19 Thread lvroyce
Tested by:lvroyce test with cmd snapshot-create domain --disk-only ,patch works when qmp or hmp monitor accessible, Got trace below when issue cmd "snapshot-delete domain --snapshotname name",no "delvm/savevm" in qmp, only "delvm/savevm" commands in hmp.Is this for future compability? 2011-

Re: [libvirt] [PATCHv2] snapshot: detect when qemu lacks disk-snapshot support

2011-10-19 Thread lvroyce
Tested by: Royce Lv Patch works as expected: tested with cmd "snapshot-create domain_name --disk-only" (1)when without hmp cmd support ,snapshot failed,0 size source file deleted (2)when source file creating failed,no snapshot taken and no crash with "need_unlink" flag set -- libvir-list mail

Re: [libvirt] [PATCH] qemu: Relax -no-shutdown check to [0.14.0, 0.15.0]

2011-10-20 Thread lvroyce
tested-by :Royce Lv patch workes expected,qemu version 0.15.50.reboot domain with ACPI support. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/7] Update systemtap probing

2011-10-25 Thread lvroyce
I believe enable systemtap will be very helpful for debugging.But I encountered belowing error when enable systemtap support: *emantic error: probe point mismatch at position 0 (alternatives: __nfs __scheduler __signal __tcpmib __vm _linuxmib _signal _sunrpc _syscall _vfs begin begin(number)

Re: [libvirt] [PATCH 0/7] Update systemtap probing

2011-10-28 Thread lvroyce
Tested by:Royce Lv I'm not sure whether I encountered are env/config related problem or bugs,so I submit my installation process here for you to reference. 1.env description: host os:Ubuntu 11.04(kernel 2.6.38-8-generic,x86_64) libvirt:0.9.6 qemu:0.15.50 dtrace:sun D 1.6 s

Re: [libvirt] [PATCH 0/7] Update systemtap probing

2011-10-28 Thread lvroyce
You're right, that is the root cause of the numeric errors, supporting systemtap should install not only package "systemtap",but also "systemtap*" to get dtrace installed. And also,many Ubuntu versions have a bug called:"systemtap process probes requires CONFIG_UTRACE enabled",which means I can

Re: [libvirt] [libvirt[]PATCH v2] Fix URI alias prefix matching

2011-11-01 Thread lvroyce
On 2011?11?01? 15:12, Philipp Hahn wrote: Now you have it the other way around, that any prefix matches: "virsh -c hai" will match "hail". Why not simply use STREQ instead of STREQLEN? Sincerely Philipp ooops..You're right.But here I think we can't use STREQ because in config file the com

[libvirt] can't start domain with a corrupted disk attatched

2011-11-03 Thread lvroyce
Hi all, I came across below issue when testing: 1.make a volume and attach it to a domain A 2.unplug the vg from the host in order to emulating a volume failure 3.start domain A(failed) In step 3 can't start domainA . because can't find disk listed in xml when create the Domai

Re: [libvirt] [PATCH] fix crash when starting network

2011-11-10 Thread lvroyce
tested-by: Wen Ruo Lv tested 1.net-start cmd with bridge mac specified (failed) 2.attach-device cmd with a hot plug nic(ok) My network is as below: default 361441af-e1f0-472d-a503-dfcbbefa03fb It fails at brSetInterfaceMac-->return ioctl(ctl->fd, SIOCSIFHWADDR, &ifr) but SIOCGIFHWADDR

[libvirt] storage: pool definition discarded by pool-create failure

2011-11-21 Thread lvroyce
1.how to reproduce: (1)just use LVM disk,leave libvirt create vg (2)xml: pic_pool2 /dev/pic_pool2 (3)steps: a.start libvirtd,copy xml b.virsh pool-define lvm_pool.xml c.virsh pool-list --all lvm_pool exsists c.virsh pool-create lvm_pool.xml lvm_pool disappears 2.a

[libvirt] storage:lvm pool creation fails because of vg not built

2011-11-21 Thread lvroyce
1.how to reproduce the reproduce steps just as http://www.redhat.com/archives/libvir-list/2011-November/msg01151.html 2.analyse: since create = define + start so pool-create can't work for the vg pre-built condition, shall we change create = define + build + start(if vg does not exist) and crea

[libvirt] [PATCH] add handling EINTR to test example of event loop

2012-06-18 Thread lvroyce
From: lvroyce some system call and signal will interrupt poll, making event loop stops and fails to react events and keepalive message from libvirt. adding handling EINTR to poll to make it more robust Signed-off-by: lvroyce --- examples/domain-events/events-python/event-test.py |8

[libvirt] [PATCHv2] adding handling EINTR to poll to make it more robust

2012-06-18 Thread lvroyce
From: Royce Lv some system call and signal will interrupt poll, making event loop stops and fails to react events and keepalive message from libvirt. adding handling EINTR to poll to make it more robust Signed-off-by: Royce Lv --- examples/domain-events/events-python/event-test.py | 95 +

[libvirt] [PATCH] fix key error for qemuMonitorGetBlockStatsInfo

2012-06-21 Thread lvroyce
From: lvroyce virDomainBlockStatsFlags can't collect total_time_ns for read/write/flush because of key typo when retriveing from qemu cmd result Signed-off-by: lvroyce --- src/qemu/qemu_monitor_json.c | 24 src/qemu/qemu_monitor_text.c | 18 +---