From: Marc-André Lureau
Follow better meson build system conventions. This allows to find
keymap-gen or CSV without explicitly setting the paths.
Signed-off-by: Marc-André Lureau
---
.gitmodules | 2 +-
meson.build | 1 +
src/util/meson.build
From: Marc-André Lureau
The function does not exist on win32.
Signed-off-by: Marc-André Lureau
Signed-off-by: Michal Privoznik
Reviewed-by: Michal Privoznik
---
src/rpc/virnetlibsshsession.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git
From: Marc-André Lureau
meson wraps python scripts already on win32, so we end up with these
failing commands:
[1/359] "C:/msys64/ucrt64/bin/meson" "--internal" "exe" "--capture"
"src/util/virkeycodetable_atset1.h" "--" "sh"
"C:/msys64/home/marca/src/libvirt/scripts/meson-python.sh"
From: Marc-André Lureau
Use 'dirs' argument to locate the program.
Signed-off-by: Marc-André Lureau
---
src/util/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/meson.build b/src/util/meson.build
index 2fe6f7699e..f055079d0b 100644
---
From: Marc-André Lureau
A number of changes, but notably python script shebang fixing build
issues in CI:
Daniel P. Berrangé (1):
Revert "Add local argparse for compat with python 2.6"
Dawid Dziurla (1):
Don't hardcode python3 path in shebang
Eli Schwartz (1):
make the
From: Marc-André Lureau
Or meson will complain with:
../meson.build:770:2: ERROR: Search directory /sbin is not an absolute path.
Signed-off-by: Marc-André Lureau
Reviewed-by: Michal Privoznik
---
meson.build | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git
From: Marc-André Lureau
Hi,
libvirt fails to compile on msys2/win32.
Also update keycodemapdb to fix CI build issues, and turn it into a
subproject(), as that makes things simpler for meson.
Fixes:
https://gitlab.com/libvirt/libvirt/-/issues/453
v2:
- update based on Michal version
-
From: Marc-André Lureau
The function does not exist on win32.
Signed-off-by: Marc-André Lureau
---
src/rpc/virnetlibsshsession.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/src/rpc/virnetlibsshsession.c b/src/rpc/virnetlibsshsession.c
index
From: Marc-André Lureau
meson wraps python scripts already on win32, so we end up with these
failing commands:
[1/359] "C:/msys64/ucrt64/bin/meson" "--internal" "exe" "--capture"
"src/util/virkeycodetable_atset1.h" "--" "sh"
"C:/msys64/home/marca/src/libvirt/scripts/meson-python.sh"
From: Marc-André Lureau
Or meson will complain with:
../meson.build:770:2: ERROR: Search directory /sbin is not an absolute path.
Signed-off-by: Marc-André Lureau
---
meson.build | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/meson.build b/meson.build
index
From: Marc-André Lureau
Hi,
libvirt fails to compile on msys2/win32. Here is a few patches that solve it,
but the way python scripts are being handled in general is a bit odd, so this is
RFC. (fwiw, a lot of tests fail though, I can send the log if anyone is
interested - or attach it to a
From: Marc-André Lureau
As Ed Swierk explained back in 2006:
https://lists.nongnu.org/archive/html/qemu-devel/2006-12/msg00160.html
"When qemu writes into the pipe, it immediately reads back what it just
wrote and treats it as a monitor command, endlessly breathing its own
exhaust."
This is
From: Marc-André Lureau
By default, libvirt will start a private bus and tell QEMU to connect to
it. Instead, a D-Bus "address" to connect to can be specified, or the
p2p mode enabled.
D-Bus display works best with GL & a rendernode, which can be specified
with child element.
Signed-off-by:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
NEWS.rst | 5 +
docs/formatdomain.rst | 43 ++-
2 files changed, 47 insertions(+), 1 deletion(-)
diff --git a/NEWS.rst b/NEWS.rst
index 7903449f9b..b32fd26167 100644
---
From: Marc-André Lureau
The USB device redirection works in a similar way as Spice. The
underlying 'dbus' channel is set to "org.qemu.usbredir" by default for
the client to identify the channel purpose (as specified in -display
dbus documentation).
Signed-off-by: Marc-André Lureau
---
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_7.0.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml | 1 +
4 files
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c | 4 +++
src/qemu/qemu_monitor_json.c | 9 ++
.../graphics-dbus-chardev.args| 32 +++
tests/qemuxml2argvtest.c
From: Marc-André Lureau
Like a Spice port, a dbus serial must specify an associated channel name.
Signed-off-by: Marc-André Lureau
---
src/conf/domain_conf.c| 25 +++
src/conf/domain_conf.h| 4 ++
src/conf/domain_validate.c
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c | 12 +--
src/qemu/qemu_validate.c | 30 -
.../qemuxml2argvdata/graphics-dbus-audio.args | 33 +++
tests/qemuxml2argvtest.c
From: Marc-André Lureau
This implementation reports only Unix bus address using the URI format
proposed in https://gitlab.freedesktop.org/dbus/dbus/-/issues/348.
We prefer a URI form over the D-Bus address form, since all other
display protocols use a URI, allowing to distinguish between
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/bhyve/bhyve_command.c | 1 +
src/conf/domain_conf.c| 34 +++---
src/conf/domain_conf.h| 2 +
src/conf/schemas/domaincommon.rng | 29
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/conf/domain_conf.c| 78 ++-
src/conf/domain_conf.h| 8 ++
src/conf/domain_validate.c| 9 ++-
src/conf/schemas/basictypes.rng | 7
From: Marc-André Lureau
Start the daemon if necessary (it is already stopped in qemuProcessStop)
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_extdevice.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/qemu/qemu_extdevice.c b/src/qemu/qemu_extdevice.c
index
From: Marc-André Lureau
Hi,
This series implements supports for the QEMU "-display dbus" support, available
since 7.0.
By default, libvirt will start a private VM bus (sharing and reusing the
existing "vmstate" VM bus & code).
The feature set should cover the needs to replace Spice as local
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
NEWS.rst | 7 ++-
docs/formatdomain.rst | 43 ++-
2 files changed, 48 insertions(+), 2 deletions(-)
diff --git a/NEWS.rst b/NEWS.rst
index e7d53167219f..92042459653d 100644
From: Marc-André Lureau
The USB device redirection works in a similar way as Spice. The
underlying 'dbus' channel is set to "org.qemu.usbredir" by default for
the client to identify the channel purpose (as specified in -display
dbus documentation).
Signed-off-by: Marc-André Lureau
---
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c | 4 +++
src/qemu/qemu_monitor_json.c | 9 ++
.../graphics-dbus-chardev.args| 32 +++
tests/qemuxml2argvtest.c
From: Marc-André Lureau
Like a Spice port, a dbus serial must specify an associated channel name.
Signed-off-by: Marc-André Lureau
---
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c| 26 +++
src/conf/domain_conf.h
From: Marc-André Lureau
This feature requires to setup a "-chardev qemu-vdagent,clipboard=on".
"qemu-vdagent" is not a typical chardev that you can connect to another
end, so it doesn't map to a or . Set it up along with
"-display dbus" code instead.
Signed-off-by: Marc-André Lureau
---
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
docs/schemas/domaincommon.rng | 8 +
src/conf/domain_conf.c| 13 ++-
src/conf/domain_conf.h| 1 +
.../graphics-dbus-clipboard.xml | 35
From: Marc-André Lureau
By default, libvirt will start a private bus and tell QEMU to connect to
it. Instead, a D-Bus "address" to connect to can be specified, or the
p2p mode enabled.
D-Bus display works best with GL & a rendernode, which can be specified
with child element.
Signed-off-by:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c | 12 +--
src/qemu/qemu_validate.c | 30 -
.../qemuxml2argvdata/graphics-dbus-audio.args | 33 +++
tests/qemuxml2argvtest.c
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
docs/schemas/domaincommon.rng | 29
src/bhyve/bhyve_command.c | 1 +
src/conf/domain_conf.c| 34 +++---
src/conf/domain_conf.h|
From: Marc-André Lureau
This implementation reports only Unix bus address using the URI format
proposed in https://gitlab.freedesktop.org/dbus/dbus/-/issues/348.
We prefer a URI form over the D-Bus address form, since all other
display protocols use a URI, allowing to distinguish between
From: Marc-André Lureau
The function is large and quite complex. Move the inner loop for each
scheme in a separate function cmdDomDisplayScheme().
Signed-off-by: Marc-André Lureau
---
tools/virsh-domain.c | 341 +--
1 file changed, 169 insertions(+),
From: Marc-André Lureau
Start the daemon if necessary (it is already stopped in qemuProcessStop)
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_extdevice.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/qemu/qemu_extdevice.c b/src/qemu/qemu_extdevice.c
index
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
docs/schemas/basictypes.rng | 7 ++
docs/schemas/domaincommon.rng | 33
src/conf/domain_conf.c| 78 ++-
src/conf/domain_conf.h
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h | 3 +++
2 files changed, 7 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 1cf56ace71b2..f6ba51229841 100644
---
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_6.2.0.aarch64.xml | 1 +
From: Marc-André Lureau
Hi,
This series implements supports for the uQEMU "-display dbus" support, that
landed earlier this week for 7.0.
By default, libvirt will start a private VM bus (sharing and reusing the
existing "vmstate" VM bus & code).
The feature set should cover the needs to
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c | 12 +--
src/qemu/qemu_validate.c | 30 -
.../qemuxml2argvdata/graphics-dbus-audio.args | 33 +++
tests/qemuxml2argvtest.c
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
docs/schemas/domaincommon.rng | 29
src/bhyve/bhyve_command.c | 1 +
src/conf/domain_conf.c| 34 +++---
src/conf/domain_conf.h|
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
docs/schemas/domaincommon.rng | 8 +
src/conf/domain_conf.c| 13 ++-
src/conf/domain_conf.h| 1 +
.../graphics-dbus-clipboard.xml | 35
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
docs/formatdomain.rst | 43 ++-
1 file changed, 42 insertions(+), 1 deletion(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index eb8c973cf1fc..ac298fbafa7f 100644
---
From: Marc-André Lureau
The USB device redirection works in a similar way as Spice. The
underlying 'dbus' channel is set to "org.qemu.usbredir" by default for
the client to identify the channel purpose (as specified in -display
dbus documentation).
Signed-off-by: Marc-André Lureau
---
From: Marc-André Lureau
Like a Spice port, a dbus serial must specify an associated channel name.
Signed-off-by: Marc-André Lureau
---
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c| 26 +++
src/conf/domain_conf.h
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c | 8 +
src/qemu/qemu_monitor_json.c | 9 ++
.../graphics-dbus-chardev.args| 32 +++
tests/qemuxml2argvtest.c
From: Marc-André Lureau
This feature requires to setup a "-chardev qemu-vdagent,clipboard=on".
"qemu-vdagent" is not a typical chardev that you can connect to another
end, so it doesn't map to a or . Set it up along with
"-display dbus" code instead.
Signed-off-by: Marc-André Lureau
---
From: Marc-André Lureau
This implementation reports only Unix bus address using the URI format
proposed in https://gitlab.freedesktop.org/dbus/dbus/-/issues/348.
We prefer a URI form over the D-Bus address form, since all other
display protocols use a URI, allowing to distinguish between
From: Marc-André Lureau
The function is large and quite complex. Move the inner loop for each
scheme in a separate function cmdDomDisplayScheme().
Signed-off-by: Marc-André Lureau
---
tools/virsh-domain.c | 341 +--
1 file changed, 169 insertions(+),
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
docs/schemas/basictypes.rng | 7 ++
docs/schemas/domaincommon.rng | 33
src/conf/domain_conf.c| 78 ++-
src/conf/domain_conf.h
From: Marc-André Lureau
By default, libvirt will start a private bus and tell QEMU to connect to
it. Instead, a D-Bus "address" to connect to can be specified, or the
p2p mode enabled.
D-Bus display works best with GL & a rendernode, which can be specified
with child element.
Signed-off-by:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_6.2.0.x86_64.replies | 10 +-
From: Marc-André Lureau
Start the daemon if necessary (it is already stopped in qemuProcessStop)
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_extdevice.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/qemu/qemu_extdevice.c b/src/qemu/qemu_extdevice.c
index
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_6.2.0.aarch64.xml | 1 +
From: Marc-André Lureau
Hi,
This series implements supports for the upcoming QEMU "-display dbus" support.
Development is still in progress, but I hope to land the QEMU support early in
6.3 (last version posted:
https://patchew.org/QEMU/20211009210838.2219430-1-marcandre.lur...@redhat.com/).
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c| 26 +
src/conf/domain_conf.h| 4 ++
src/conf/domain_validate.c| 32
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
docs/formatdomain.rst | 24
1 file changed, 24 insertions(+)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index eb8c973cf1fc..b477aec65f5c 100644
--- a/docs/formatdomain.rst
+++
From: Marc-André Lureau
The USB device redirection works in a similar way as Spice. The
underlying 'dbus' channel is set to "org.qemu.usbredir" by default for
the client to identify the channel purpose (as specified in -display
dbus documentation).
Signed-off-by: Marc-André Lureau
---
From: Marc-André Lureau
This feature requires to setup a "-chardev qemu-vdagent,clipboard=on".
"qemu-vdagent" is not a typical chardev that you can connect to another
end, so it doesn't map to a or . Set it up along with
"-display dbus" code instead.
Signed-off-by: Marc-André Lureau
---
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
docs/schemas/domaincommon.rng | 29 +
src/bhyve/bhyve_command.c | 1 +
src/conf/domain_conf.c| 16 +++
src/conf/domain_conf.h| 2 +
From: Marc-André Lureau
Without any extra option, libvirt will start and tell QEMU to connect to
the private VM bus.
Instead, a D-Bus "address" to connect to can be specified. Or the p2p
mode enabled.
D-Bus display best works with GL & a rendernode, which can be specified
with child element.
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_6.2.0.x86_64.replies | 10 +-
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_6.2.0.aarch64.xml | 1 +
From: Marc-André Lureau
The daemon is started on daemon in external devices and hotplug code.
Add a mechanism to start it before qemu, if qemu itself needs it. (it is
already stopped in qemuProcessStop)
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_domain.h | 1 +
From: Marc-André Lureau
Hi,
This series implements supports for the upcoming QEMU "-display dbus" support.
Development is still in progress, but I hope to land the QEMU support early in
6.3 (last version posted:
https://patchew.org/QEMU/20211009210838.2219430-1-marcandre.lur...@redhat.com/).
From: Marc-André Lureau
guest-get-disks is available since QEMU 5.2:
https://wiki.qemu.org/ChangeLog/5.2#Guest_agent
Note that the test response was manually edited based on a reply on my
bare-metal computer. It shows partial results due to pcieport driver not
being currently supported by QGA.
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_agent.c | 2 +-
src/qemu/qemu_agent.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index beb42449ce..ba07d6bfdf 100644
--- a/src/qemu/qemu_agent.c
From: Marc-André Lureau
There might be more potential users around, I haven't looked thoroughly.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_monitor_json.c | 34 ++
1 file changed, 6 insertions(+), 28 deletions(-)
diff --git
From: Marc-André Lureau
Hi,
The following series extends virDomainGetGuestInfo to report disk informations
provided by the new QGA "guest-get-disks" command in QEMU 5.2.
Please review,
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1899527
Marc-André Lureau (9):
qemu_agent: rename
From: Marc-André Lureau
To match the QGA schema name (we are introducing a qemuAgentDiskInfo
struct again for different purpose).
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_agent.c | 10 +-
src/qemu/qemu_agent.h | 8
src/qemu/qemu_driver.c | 4 ++--
3 files
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
tools/virsh-domain.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index c999458d72..070b8d21fd 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -14219,6
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_driver.c | 99 --
1 file changed, 96 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index a8760f82b1..8d3e09da69 100644
---
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
include/libvirt/libvirt-domain.h | 1 +
src/libvirt-domain.c | 17 +
2 files changed, 18 insertions(+)
diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/libvirt_private.syms | 1 +
src/util/virjson.c | 30 ++
src/util/virjson.h | 1 +
3 files changed, 32 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_agent.c | 83 ++-
1 file changed, 43 insertions(+), 40 deletions(-)
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index ba07d6bfdf..31f26eedd1 100644
---
From: Marc-André Lureau
In QEMU 5.2, the guest agent learned to manipulate a user
~/.ssh/authorized_keys. Bind the JSON API to libvirt.
https://wiki.qemu.org/ChangeLog/5.2#Guest_agent
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1888537
Signed-off-by: Marc-André Lureau
---
From: Marc-André Lureau
External devices are started before cgroup is created. Add the DBus
daemon to the VM cgroup with the rest of the external devices.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_dbus.c | 24
src/qemu/qemu_dbus.h | 3 +++
From: Marc-André Lureau
The file doesn't use virSystemd functions directly.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_cgroup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index 2afe22f177..2e019b64af 100644
---
From: Marc-André Lureau
Allow calling qemuDBusStart() multiple times (as may be done by
qemu-slirp already).
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_dbus.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c
index
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_dbus.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c
index ae55bbb299..02dc3ebf07 100644
--- a/src/qemu/qemu_dbus.c
+++ b/src/qemu/qemu_dbus.c
@@ -142,13 +142,11 @@
From: Marc-André Lureau
Don't stop the DBus daemon if a slirp helper failed to start, as it
may be shared with other helpers.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_slirp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_slirp.c
From: Marc-André Lureau
The slirp helper process should be associated with the VM cgroup, like
other helpers.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_extdevice.c | 8
src/qemu/qemu_slirp.c | 14 ++
src/qemu/qemu_slirp.h | 3 +++
3 files changed, 25
From: Marc-André Lureau
Hi,
Here is a subset of the series posted earlier "RFC: basic CGroup
support with qemu:///session", as requested by Pavel.
Marc-André Lureau (6):
slirp: leave the dbus daemon running on error
slirp: add helper to VM cgroup
qemu-dbus: prevent double start of the
From: Marc-André Lureau
machined could quite easily support session management:
https://github.com/systemd/systemd/pull/15312
Signed-off-by: Marc-André Lureau
---
src/util/virsystemd.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git
From: Marc-André Lureau
This fixes an error path when virCgroupV2DevicesDetectProg() fails but
wasn't needed in the first place on VM shutdown.
Signed-off-by: Marc-André Lureau
---
src/util/vircgroupv2devices.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
From: Marc-André Lureau
External devices registration can add processes to the process group,
which allows basic process management or other tuning.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_cgroup.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/src/qemu/qemu_cgroup.c
From: Marc-André Lureau
The service is started on demand, checking if it's already registered
on the bus defeat this purpose.
Note: the same is probably true for login1, but I don't intent to look
at the code path yet.
Signed-off-by: Marc-André Lureau
---
src/util/virsystemd.c | 2 --
From: Marc-André Lureau
CGroup delegation can allow various processes or users to use
cgroup. Further checks should be done by the various backends.
With this series, a qemu:///session VM can have basic CGroupv2 support
with machined --user help.
Signed-off-by: Marc-André Lureau
---
From: Marc-André Lureau
This allow for basic process management, at least.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_process.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 6b9f6fb860..0c33eab26c
From: Marc-André Lureau
The file doesn't use virSystemd functions directly.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_cgroup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index 23e52fa218..cec0a03889 100644
---
From: Marc-André Lureau
External devices are started before cgroup is created. Add the DBus
daemon to the VM cgroup with the rest of the external devices.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_dbus.c | 24
src/qemu/qemu_dbus.h | 3 +++
From: Marc-André Lureau
Since commit f10bd740e178c89f24d0b0298d0b5413537d0699 ("Cache the
presence of machine1 service"), the code checks for systemd1
registration. Not totally unreasonable, but that seems odd since we
actually check machined presence in this function.
Signed-off-by: Marc-André
From: Marc-André Lureau
Those functions talk to system bus and have a special handling of
system bus missing.
Signed-off-by: Marc-André Lureau
---
src/util/virdbus.c | 12 ++--
src/util/virdbus.h | 4 ++--
src/util/virfirewalld.c | 2 +-
src/util/virsystemd.c | 8
From: Marc-André Lureau
Hi,
This is a small series that allows basic QEMU VM CGroup support with
the help of machined --user:
https://github.com/systemd/systemd/pull/15312
The first few patches are fixes to register dbus and slirp-helper
correctly with the VM cgroup.
A few changes are done to
From: Marc-André Lureau
The slirp helper process should be associated with the VM cgroup, like
other helpers.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_extdevice.c | 8
src/qemu/qemu_slirp.c | 14 ++
src/qemu/qemu_slirp.h | 3 +++
3 files changed, 25
From: Marc-André Lureau
Allow calling qemuDBusStart() multiple times (as may be done by
qemu-slirp already).
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_dbus.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c
index
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_dbus.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c
index ae55bbb299..02dc3ebf07 100644
--- a/src/qemu/qemu_dbus.c
+++ b/src/qemu/qemu_dbus.c
@@ -142,13 +142,11 @@
From: Marc-André Lureau
Don't stop the DBus daemon if a slirp helper failed to start, as it
may be shared with other helpers.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_slirp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_slirp.c
From: Marc-André Lureau
Learn to check presence of services on a given connection.
Signed-off-by: Marc-André Lureau
---
src/util/virdbus.c | 65 +++---
src/util/virdbus.h | 3 +++
2 files changed, 53 insertions(+), 15 deletions(-)
diff --git
1 - 100 of 318 matches
Mail list logo
