On Mon, Feb 10, 2020 at 01:38:04PM +, math...@pius.io wrote:
> From: Mathias Pius
>
> ---
> src/storage_pool.rs | 54 ++-
> tests/storage_pool.rs | 34 +++
> 2 files changed, 87 insertions(+), 1 deletion(-)
Sounds good thank
On Wed, Jan 29, 2020 at 08:24:10PM -0700, Zixing Liu wrote:
> This set of patches will add more functions to the Rust bindings.
> Newly mapped functions from C library: virStreamNew
> virStreamEventUpdateCallback virStreamEventRemoveCallback
> virStreamEventAddCallback.
>
>
This is updating the releases and resources links so they point now to
crates.io for the releases and docs.rs for the api ref.
Signed-off-by: Sahid Orentino Ferdjaoui
---
docs/downloads.html.in | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/docs/downloads.html.in b
851296786626d61ebec985a9caeb515514955dd8
Author: Sahid Orentino Ferdjaoui
Date: Tue Jan 28 15:05:44 2020 +0100
ensure that the code is well formatted using rustfmt.
In this commit we add CI rule so travis would check whether the code
is well formatted using rustfmt.
Signed-off-by: Sahid Orentino Ferdjaoui
On Fri, Jan 17, 2020 at 12:23:46AM -0700, Zixing Liu wrote:
> On 1/13/20 3:53 AM, Sahid Orentino Ferdjaoui wrote:
>
> > On Fri, Jan 10, 2020 at 11:35:32AM -0700, Zixing Liu wrote:
> >> On 2020-01-10 04:48, Sahid Orentino Ferdjaoui wrote:
> >>
> >>> On Tue
On Fri, Jan 10, 2020 at 11:35:32AM -0700, Zixing Liu wrote:
> On 2020-01-10 04:48, Sahid Orentino Ferdjaoui wrote:
>
> > On Tue, Dec 24, 2019 at 12:12:53AM -0700, Zixing Liu wrote:
> >> * used rustfmt to clean up the code
> >>
> >> Signed-off-by: Zixing
On Tue, Dec 24, 2019 at 12:12:55AM -0700, Zixing Liu wrote:
> * minimized unsafe scope
> * removed pub from `from_ptr` function
>
> Signed-off-by: Zixing Liu
> ---
> src/stream.rs | 16 +++-
> 1 file changed, 7 insertions(+), 9 deletions(-)
Reviewed-by: Sah
On Tue, Dec 24, 2019 at 12:12:54AM -0700, Zixing Liu wrote:
> Signed-off-by: Zixing Liu
> ---
> src/domain.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Sahid Orentino Ferdjaoui
> diff --git a/src/domain.rs b/src/domain.rs
> index 40a18d8..61ca411
On Tue, Dec 24, 2019 at 12:12:53AM -0700, Zixing Liu wrote:
> * used rustfmt to clean up the code
>
> Signed-off-by: Zixing Liu
> ---
> src/stream.rs | 97 +--
> 1 file changed, 56 insertions(+), 41 deletions(-)
NAK, we don't have specific rule
u
> ---
> src/stream.rs | 46 --
> 1 file changed, 44 insertions(+), 2 deletions(-)
Reviewed-by: Sahid Orentino Ferdjaoui
> diff --git a/src/stream.rs b/src/stream.rs
> index de272ab..1ffd186 100644
> --- a/src/stream.rs
> +++ b/src/stream.rs
> @
> Signed-off-by: Zixing Liu
> ---
> src/stream.rs | 42 +-
> tests/stream.rs | 40
> 2 files changed, 81 insertions(+), 1 deletion(-)
> create mode 100644 tests/stream.rs
Reviewed-by:
gs
>
> Signed-off-by: Vineeth Remanan Pillai
> ---
> examples/hello.rs | 38 +++
> src/domain.rs | 260 +++---
> 2 files changed, 283 insertions(+), 15 deletions(-)
Reviewed-by: Sahid Orentino Ferdjaoui
I will merge it and
On Tue, Nov 12, 2019 at 02:44:45PM -0700, Zixing Liu wrote:
> Signed-off-by: Zixing Liu
> ---
> src/domain.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Sahid Orentino Ferdjaoui
>
> diff --git a/src/domain.rs b/src/domain.rs
> index ac
On Tue, Nov 12, 2019 at 02:44:44PM -0700, Zixing Liu wrote:
> * used rustfmt to clean up the code
>
> Signed-off-by: Zixing Liu
> ---
> src/stream.rs | 97 +--
> 1 file changed, 56 insertions(+), 41 deletions(-)
NACK, We don't have any rules for
0 @@
> +/*
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version
---
> .gitpublish | 2 +-
> README.md | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Sahid Orentino Ferdjaoui
Thanks,
s.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Nov 12, 2019 at 11:36:49AM +0100, Andrea Bolognani wrote:
> On Fri, 2019-11-01 at 14:23 -0600, liushuyu wrote:
> > From: liushuyu
>
> Please include a Signed-off-by: tag with your full legal name and
> your email address to certify that you're in compliance with the DCO,
> as explained
On Fri, Sep 20, 2019 at 10:02:47AM +0200, Martin Kletzander wrote:
> On Thu, Sep 19, 2019 at 05:48:49AM +, Linus Färnstrand wrote:
> > * Handle the -2 error case
> > * Allow sending arbitrary byte array, not just UTF-8 strings
> > * Fix FFI declaration, takes size_t, not c_uint
> > * Return
On Mon, Sep 30, 2019 at 12:10:49PM +0200, Martin Kletzander wrote:
> On Wed, Sep 25, 2019 at 04:36:16PM +, Linus Färnstrand wrote:
> > Giving an invalid pointer to the safe wrapper types causes
> > undefined behavior when methods are later called on said wrapper
> >
> > Properly document
On Thu, Aug 29, 2019 at 02:05:12AM -0700, Sage Imel wrote:
> From: Sage Imel
>
> Always returns the full list of volumes,
> can't just ask it how many volumes are in the pool
>
> Signed-off-by: Sage Imel
> ---
That looks to be a nice add, thank you for this contribution, can you
just consider
Just A small note to indicate that a new release v0.2.11 has been
published.
https://docs.rs/virt/0.2.11/virt/
Thanks to Sage Imel for its contribution to a bug fix:
e737a93 virDomainGetAutostart takes a pointer that it writes the output value
to
s.
--
libvir-list mailing list
In this refactor we avoid to enclose all the code with unsafe tags and
just use it when necessary. Also we add annotations to explain why
it's safe to use.
The integrations tests related are also been reviewed to avoid using
panic.
Signed-off-by: Sahid Orentino Ferdjaoui
---
src/connect.rs
Signed-off-by: Sahid Orentino Ferdjaoui
---
src/lib.rs | 4
1 file changed, 4 deletions(-)
diff --git a/src/lib.rs b/src/lib.rs
index f9ede21..77bf4a9 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -107,10 +107,6 @@ macro_rules! string_to_mut_c_chars {
($x:expr) => (::std::ffi::CStr
In this commit we also add todo and warning to avoid using them +
remove them in future.
Signed-off-by: Sahid Orentino Ferdjaoui
---
src/lib.rs | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/src/lib.rs b/src/lib.rs
index 77bf4a9..64d49cd 100644
This is fixing the invalid email address in Cargo.toml + update the
command examples to send patches so they CC the current maintainer.
Signed-off-by: Sahid Orentino Ferdjaoui
---
.gitpublish | 3 ++-
Cargo.toml | 2 +-
README.md | 12 +++-
3 files changed, 10 insertions(+), 7
Signed-off-by: Sahid Orentino Ferdjaoui
---
README.md | 4
1 file changed, 4 insertions(+)
diff --git a/README.md b/README.md
index a359574..6e1ad64 100644
--- a/README.md
+++ b/README.md
@@ -76,14 +76,18 @@ at any time. The preferred submission method is to use git
send-email
to submit
Due to an issue fixed in libvirt master we should not consider running
integration tests in parallel.
https://www.redhat.com/archives/libvir-list/2019-July/msg00287.html
Signed-off-by: Sahid Orentino Ferdjaoui
---
.travis.yml | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff
Signed-off-by: Sahid Orentino Ferdjaoui
---
.travis.yml | 7 +++
README.md | 2 +-
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 54f3c24..ebefca8 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -13,11 +13,10 @@ matrix:
- rust: nightly
Also configure default mech used by sasl to 'digest-md5' since
'scram-sha-1' requires an encryption layer.
Signed-off-by: Sahid Orentino Ferdjaoui
---
.travis.yml | 3 ++-
tests/libvirtd.sasl | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
create mode 100644 tests/libvirtd.sasl
Signed-off-by: Sahid Orentino Ferdjaoui
---
tests/domain.rs | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/tests/domain.rs b/tests/domain.rs
index 5a64a75..dcf7dd9 100644
--- a/tests/domain.rs
+++ b/tests/domain.rs
@@ -91,14 +91,13 @@ fn test_get_vcpus_flags
We passed the 0.2.9 since that one has been sent to crates.io but the
code was never merged. To avoid that in future, new version will be
sent to crates.io only when accepted by upstream.
Signed-off-by: Sahid Orentino Ferdjaoui
---
Cargo.toml | 2 +-
1 file changed, 1 insertion(+), 1 deletion
y except in SASL code itself.
> > >
> > > Signed-off-by: Daniel P. Berrangé
> > > ---
> > > src/rpc/virnetsaslcontext.c | 50 ++++-
> > > 1 file changed, 33 insertions(+), 17 deletions(-)
> >
> > Review
On Fri, Jul 05, 2019 at 09:55:37AM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 04, 2019 at 12:15:28PM +0200, Sahid Orentino Ferdjaoui wrote:
> > Not sure what the problem is by using 'scram-sha-1' with ubuntu:
> >
> > cannot list SASL mechanisms -4 (SASL(-4): n
On Fri, Jul 05, 2019 at 09:49:02AM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 04, 2019 at 12:15:26PM +0200, Sahid Orentino Ferdjaoui wrote:
> > Signed-off-by: Sahid Orentino Ferdjaoui
> > ---
> > tests/domain.rs | 19 +--
> > 1 file changed, 9
On Fri, Jul 05, 2019 at 09:47:14AM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 04, 2019 at 12:15:25PM +0200, Sahid Orentino Ferdjaoui wrote:
> > The open_auth test cases were randomly failling. It seems that because
> > tests are executed in parallel if a sasl connecti
Signed-off-by: Sahid Orentino Ferdjaoui
---
README.md | 4
1 file changed, 4 insertions(+)
diff --git a/README.md b/README.md
index a359574..6e1ad64 100644
--- a/README.md
+++ b/README.md
@@ -76,14 +76,18 @@ at any time. The preferred submission method is to use git
send-email
to submit
orthy mechs found)".
Signed-off-by: Sahid Orentino Ferdjaoui
---
tests/integration_qemu.rs | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/tests/integration_qemu.rs b/tests/integration_qemu.rs
index 49e07c4..7db43d5 100644
--- a/tests/integration_qem
Not sure what the problem is by using 'scram-sha-1' with ubuntu:
cannot list SASL mechanisms -4 (SASL(-4): no mechanism available:
Internal Error -4 in ../../lib/server.c near line 1762)
So we currently switch the mech to digest-md5. Seems that libvirt-go
is doing same.
Signed-off-by: Sahid
Signed-off-by: Sahid Orentino Ferdjaoui
---
tests/domain.rs | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/tests/domain.rs b/tests/domain.rs
index 5a64a75..a70139e 100644
--- a/tests/domain.rs
+++ b/tests/domain.rs
@@ -89,26 +89,25 @@ fn
Signed-off-by: Sahid Orentino Ferdjaoui
---
.travis.yml | 7 +++
README.md | 2 +-
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index c52f745..2267a8f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -13,11 +13,10 @@ matrix:
- rust: nightly
Hello Daniel,
When you have a moment, can you please merge this serie. It fixes CI
issue, switch to bionic, and updates the tested versions.
Results:
https://travis-ci.org/sahid/libvirt-rust/builds/554170698
Thanks,
s.
Sahid Orentino Ferdjaoui (5):
fix bug integration test with rust
argo ignored these extra args so the mistake was not noticed, but it
> now generates a fatal error.
>
Thanks for this Daniel. Do you want me to merge it or are you going to
take care of that too?
Reviewed-by: Sahid Orentino Ferdjaoui <sahid.ferdja...@redhat.com>
> Signed-off-by
On Sat, Jun 17, 2017 at 12:30:29PM -0400, Laine Stump wrote:
> On 06/15/2017 10:17 AM, sferd...@redhat.com wrote:
> > From: Sahid Orentino Ferdjaoui <sahid.ferdja...@redhat.com>
> >
> > This patch finalizes support of 'poll_us' attribute as an option of
> >
On Wed, Jun 07, 2017 at 11:14:11AM +0200, Martin Kletzander wrote:
> On Tue, Jun 06, 2017 at 12:19:21PM +0200, Sahid Orentino Ferdjaoui wrote:
> > Hello,
> >
> > I started a work on a libvirt binding for Rust [0]. Not all of the API
> > is implemeted but I think
Hello,
I started a work on a libvirt binding for Rust [0]. Not all of the API
is implemeted but I think it's now in a usable state.
https://docs.rs/crate/virt
https://github.com/sahid/libvirt-rs
The code is licensed under LGPL-2.1, it's tested by a CI running
libvirt 1.2.0, 2.5.0, 3.3.0
From 0f43b11ee1d1c4a2134f3e475846ac494d2471a3 Mon Sep 17 00:00:00 2001
From: Sahid Orentino Ferdjaoui sahid.ferdja...@cloudwatt.com
Date: Fri, 11 Apr 2014 18:44:32 +
Subject: [PATCH 1/2] Add a new example to illustrate domain migration
This commit adds a new example to illustrate peer to
peer
From a43dc307c3014d70a01035313cd763ee13e9d219 Mon Sep 17 00:00:00 2001
From: Sahid Orentino Ferdjaoui sahid.ferdja...@cloudwatt.com
Date: Fri, 11 Apr 2014 19:17:47 +
Subject: [PATCH 2/2] Add support for QEMU migration to use SASL authentication
This commit provides the ability
responsible to fetching credentials.
Sahid Orentino Ferdjaoui (2):
Add a new example to illustrate domain migration
Add support for QEMU migration to use SASL authentication
.gitignore | 1 +
Makefile.am | 2 +-
configure.ac | 1
This commit adds a new example to illustrate peer to
peer domain migration with virDomainMigrateToURI.
Signed-off-by: Sahid Orentino Ferdjaoui sahid.ferdja...@cloudwatt.com
---
.gitignore | 1 +
Makefile.am | 2 +-
configure.ac
This commit provides the ability to virDomainMigrateToURI to
check for SASL credentials when attempts to migrate a domain
with the driver QEMU.
Signed-off-by: Sahid Orentino Ferdjaoui sahid.ferdja...@cloudwatt.com
---
src/qemu/qemu_migration.c | 14 +-
1 file changed, 13 insertions
This commit adds a new example to illustrate peer to
peer domain migration with virDomainMigrateToURI.
Signed-off-by: Sahid Orentino Ferdjaoui sahid.ferdja...@cloudwatt.com
---
.gitignore | 1 +
Makefile.am | 2 +-
configure.ac
responsible to fetching credentials.
Sahid Orentino Ferdjaoui (2):
Add a new example to illustrate domain migration
Add support for QEMU migration to use SASL authentication
.gitignore | 1 +
Makefile.am | 2 +-
configure.ac | 1
This commit provides the ability to virDomainMigrateToURI to
check for SASL credentials when attempts to migrate a domain
with the driver QEMU.
Signed-off-by: Sahid Orentino Ferdjaoui sahid.ferdja...@cloudwatt.com
---
src/qemu/qemu_migration.c | 14 +-
1 file changed, 13 insertions
. Does it makes sense?
Best,
Sahid.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
54 matches
Mail list logo
