[PATCH] Conf: Move validation of Graphics Transport and StorageNetwork Socket out of parser

2023-04-04 Thread skran
Thank you for the corrections. I understand it now. [1] I have made the Graphics Transport validation function static and moved its call out of the parser, to virDomainGraphicsDefListensValidate() in domain_validate.h. Is this a correct implementation?, it does pass the tests. I have removed the

Re: [PATCH] Conf: Move validation of Graphics Transport and StorageNetwork Socket out of parser

2023-04-04 Thread skran
Thank you for the corrections. I understand it now. [1] I have made the Graphics Transport validation function static and moved its call out of the parser, to virDomainGraphicsDefListensValidate() in domain_validate.h. Is this a correct implementation?, it does pass the tests. I have removed the

[PATCH] Conf: Move validation of Graphics Transport and StorageNetwork Socket out of parser

2023-04-03 Thread skran
I have implemented your corrections successfully. Thank you. Signed-off-by: K Shiva --- src/conf/domain_conf.c | 42 +++- src/conf/domain_validate.c | 56 ++ src/conf/domain_validate.h | 7 + 3 files changed, 67 insertions(+), 3

[PATCH 1/1] Partial fixes for Issue #7 titled 'Move validation checks out of domain XML parsing'

2023-04-03 Thread skran
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 3ab7cd2666..2a94566047 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5840,14 +5840,14 @@ virDomainStorageNetworkParseHost(xmlNodePtr hostnode, host->socket = virXMLPropString(hostnode, "socket"); i