Re: [GSoC][PATCH v2 3/6] qemu_domainjob: `maxQueuedJobs` added to `qemuDomainJobPrivate`

2020-08-23 Thread Prathamesh Chavan
Keeping the above arguments in mind, I think having callback functions for accessing them instead of added them should do the work for now. Thanks, Prathamesh Chavan On Wed, Aug 19, 2020 at 9:05 PM Erik Skultety wrote: > > On Wed, Aug 19, 2020 at 05:04:58PM +0200, Michal Privoznik wrote: > > On

Re: [GSoC][PATCH v2 3/6] qemu_domainjob: `maxQueuedJobs` added to `qemuDomainJobPrivate`

2020-08-19 Thread Erik Skultety
On Wed, Aug 19, 2020 at 05:04:58PM +0200, Michal Privoznik wrote: > On 8/19/20 2:00 PM, Erik Skultety wrote: > > On Wed, Aug 19, 2020 at 01:45:37PM +0200, Michal Privoznik wrote: > > > On 8/18/20 10:48 AM, Erik Skultety wrote: > > > > On Mon, Aug 17, 2020 at 10:37:18AM +0530, Prathamesh Chavan

Re: [GSoC][PATCH v2 3/6] qemu_domainjob: `maxQueuedJobs` added to `qemuDomainJobPrivate`

2020-08-19 Thread Michal Privoznik
On 8/19/20 2:00 PM, Erik Skultety wrote: On Wed, Aug 19, 2020 at 01:45:37PM +0200, Michal Privoznik wrote: On 8/18/20 10:48 AM, Erik Skultety wrote: On Mon, Aug 17, 2020 at 10:37:18AM +0530, Prathamesh Chavan wrote: Reference to `maxQueuedJobs` required us to access config of the qemu-driver.

Re: [GSoC][PATCH v2 3/6] qemu_domainjob: `maxQueuedJobs` added to `qemuDomainJobPrivate`

2020-08-19 Thread Erik Skultety
On Wed, Aug 19, 2020 at 01:45:37PM +0200, Michal Privoznik wrote: > On 8/18/20 10:48 AM, Erik Skultety wrote: > > On Mon, Aug 17, 2020 at 10:37:18AM +0530, Prathamesh Chavan wrote: > > > Reference to `maxQueuedJobs` required us to access > > > config of the qemu-driver. And creating its copy in >

Re: [GSoC][PATCH v2 3/6] qemu_domainjob: `maxQueuedJobs` added to `qemuDomainJobPrivate`

2020-08-19 Thread Michal Privoznik
On 8/18/20 10:48 AM, Erik Skultety wrote: On Mon, Aug 17, 2020 at 10:37:18AM +0530, Prathamesh Chavan wrote: Reference to `maxQueuedJobs` required us to access config of the qemu-driver. And creating its copy in the `qemuDomainJob` helped us access the variable without referencing the driver's

Re: [GSoC][PATCH v2 3/6] qemu_domainjob: `maxQueuedJobs` added to `qemuDomainJobPrivate`

2020-08-18 Thread Erik Skultety
On Mon, Aug 17, 2020 at 10:37:18AM +0530, Prathamesh Chavan wrote: > Reference to `maxQueuedJobs` required us to access > config of the qemu-driver. And creating its copy in > the `qemuDomainJob` helped us access the variable > without referencing the driver's config. > > Signed-off-by: Prathamesh

[GSoC][PATCH v2 3/6] qemu_domainjob: `maxQueuedJobs` added to `qemuDomainJobPrivate`

2020-08-16 Thread Prathamesh Chavan
Reference to `maxQueuedJobs` required us to access config of the qemu-driver. And creating its copy in the `qemuDomainJob` helped us access the variable without referencing the driver's config. Signed-off-by: Prathamesh Chavan --- src/qemu/qemu_domain.c| 5 - src/qemu/qemu_domainjob.c