Re: [Libvir] [PATCH] Add the check of the format of MAC address on virsh attach-interface

2007-07-13 Thread Daniel Veillard
On Fri, Jul 13, 2007 at 02:24:01PM +0900, Masayuki Sunou wrote: Hi Even if specified MAC address is invalid, network interface is attached to the guest. And attached network interface cannot communicate. This patch checks the format of MAC address, and virsh become error when it is

Re: [Libvir] [PATCH] Add the check of the format of MAC address on virsh attach-interface

2007-07-13 Thread Masayuki Sunou
Hi Daniel Hum, right, I don't expect to see non-ethernet MAC addresses at that point, and doing the checking earlier allows a better handling of the error. This makes sense so applied, but I fixed the code to avoid a couple of warnings from gcc. I missed warning message from gcc.

Re: [Libvir] [PATCH] Add the check of the format of MAC address on virsh attach-interface

2007-07-13 Thread Daniel P. Berrange
On Fri, Jul 13, 2007 at 02:24:01PM +0900, Masayuki Sunou wrote: Hi Even if specified MAC address is invalid, network interface is attached to the guest. And attached network interface cannot communicate. This patch checks the format of MAC address, and virsh become error when it is

[Libvir] [PATCH] Add the check of the format of MAC address on virsh attach-interface

2007-07-12 Thread Masayuki Sunou
Hi Even if specified MAC address is invalid, network interface is attached to the guest. And attached network interface cannot communicate. This patch checks the format of MAC address, and virsh become error when it is invalid. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki