Re: [Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: > Without this patch, building without HAVE_AVAHI fails due to an unguarded > use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly > and less maintainable), I've chosen to un-ifdef the declarations and > a few uses. The more code that we co

Re: [Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Daniel Veillard
On Mon, Dec 03, 2007 at 02:36:17PM +0100, Jim Meyering wrote: > Without this patch, building without HAVE_AVAHI fails due to an unguarded > use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly > and less maintainable), I've chosen to un-ifdef the declarations and > a few uses. Th

Re: [Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Richard W.M. Jones
Richard W.M. Jones wrote: Strangely enough I didn't hit this problem when building on Cygwin, and I'm pretty sure they don't have avahi? Update: yes, I'm now hitting this problem, and your patch fixes it. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Addre

Re: [Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Daniel P. Berrange
On Mon, Dec 03, 2007 at 02:43:30PM +, Richard W.M. Jones wrote: > Jim Meyering wrote: > >Without this patch, building without HAVE_AVAHI fails due to an unguarded > >use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly > >and less maintainable), I've chosen to un-ifdef the dec

Re: [Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Daniel P. Berrange
On Mon, Dec 03, 2007 at 02:36:17PM +0100, Jim Meyering wrote: > Without this patch, building without HAVE_AVAHI fails due to an unguarded > use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly > and less maintainable), I've chosen to un-ifdef the declarations and > a few uses. Th

Re: [Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Jim Meyering
"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> Without this patch, building without HAVE_AVAHI fails due to an unguarded >> use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly >> and less maintainable), I've chosen to un-ifdef the declarations and >> a

Re: [Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Richard W.M. Jones
Jim Meyering wrote: Without this patch, building without HAVE_AVAHI fails due to an unguarded use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly and less maintainable), I've chosen to un-ifdef the declarations and a few uses. The more code that we compile and use unconditiona

[Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Jim Meyering
Without this patch, building without HAVE_AVAHI fails due to an unguarded use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly and less maintainable), I've chosen to un-ifdef the declarations and a few uses. The more code that we compile and use unconditionally, the fewer surpris