Re: [Libvir] [PATCH] BZ#251641: Allow to change the cpu pinning for inactive domain

2007-11-28 Thread Richard W.M. Jones
Saori Fukuta wrote: I checked the patch and confirmed that is working properly. Many thanks to all for your help ! OK, that's in CVS now. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street,

Re: [Libvir] [PATCH] BZ#251641: Allow to change the cpu pinning for inactive domain

2007-11-27 Thread Saori Fukuta
On Mon, 26 Nov 2007 10:17:41 -0500 Daniel Veillard wrote: On Mon, Nov 26, 2007 at 11:12:29AM +0900, Saori Fukuta wrote: I want to change the cpu pinning for inactive domain on RHEL-5.1. So, I just add the xenXMDomainPinVcpu to xm_internal.c. We will be allowed to change cpus parameter in

Re: [Libvir] [PATCH] BZ#251641: Allow to change the cpu pinning for inactive domain

2007-11-27 Thread Richard W.M. Jones
Morning Saori, You need to call the error function for each error condition, eg: if (mapstr == NULL) { xenXMError (domain ? domain-conn : NULL, VIR_ERR_NO_MEMORY, __FUNCTION__); return -1; } (Much of the current libvirt code gets this wrong, and it's a great deal of pain caused by

Re: [Libvir] [PATCH] BZ#251641: Allow to change the cpu pinning for inactive domain

2007-11-27 Thread Daniel Veillard
On Tue, Nov 27, 2007 at 01:19:48PM +, Richard W.M. Jones wrote: Morning Saori, You need to call the error function for each error condition, eg: if (mapstr == NULL) { xenXMError (domain ? domain-conn : NULL, VIR_ERR_NO_MEMORY, __FUNCTION__); return -1; } (Much of the current

Re: [Libvir] [PATCH] BZ#251641: Allow to change the cpu pinning for inactive domain

2007-11-27 Thread Richard W.M. Jones
Daniel Veillard wrote: On Tue, Nov 27, 2007 at 01:19:48PM +, Richard W.M. Jones wrote: Morning Saori, You need to call the error function for each error condition, eg: if (mapstr == NULL) { xenXMError (domain ? domain-conn : NULL, VIR_ERR_NO_MEMORY, __FUNCTION__); return -1; }

Re: [Libvir] [PATCH] BZ#251641: Allow to change the cpu pinning for inactive domain

2007-11-27 Thread Saori Fukuta
On Tue, 27 Nov 2007 14:55:22 + Richard W.M. Jones wrote: Daniel Veillard wrote: On Tue, Nov 27, 2007 at 01:19:48PM +, Richard W.M. Jones wrote: Morning Saori, Hello Rich, You need to call the error function for each error condition, eg: if (mapstr == NULL) { xenXMError

Re: [Libvir] [PATCH] BZ#251641: Allow to change the cpu pinning for inactive domain

2007-11-26 Thread Daniel Veillard
On Mon, Nov 26, 2007 at 11:12:29AM +0900, Saori Fukuta wrote: Hi, I want to change the cpu pinning for inactive domain on RHEL-5.1. So, I just add the xenXMDomainPinVcpu to xm_internal.c. We will be allowed to change cpus parameter in configuration file with vcpupin command by this patch,

[Libvir] [PATCH] BZ#251641: Allow to change the cpu pinning for inactive domain

2007-11-25 Thread Saori Fukuta
Hi, I want to change the cpu pinning for inactive domain on RHEL-5.1. So, I just add the xenXMDomainPinVcpu to xm_internal.c. We will be allowed to change cpus parameter in configuration file with vcpupin command by this patch, like setmem or setvcpus. There is 2 things to note: - This is an