Re: [Libvir] [PATCH] Cleanup xs_internal.c

2007-08-21 Thread Atsushi SAKAI
Hi, "Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > Atsushi SAKAI wrote: > > Anyway some code seems to be assumed tab = 8spaces(not 4spaces), > > I hope this kind of mis-spaces will be fixed. > > Tabstops are normally 8 spaces ... So it is difficult to see for my case :-) Thanks Atsushi --

Re: [Libvir] [PATCH] Cleanup xs_internal.c

2007-08-21 Thread Richard W.M. Jones
Atsushi SAKAI wrote: Anyway some code seems to be assumed tab = 8spaces(not 4spaces), I hope this kind of mis-spaces will be fixed. Tabstops are normally 8 spaces ... Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 10

Re: [Libvir] [PATCH] Cleanup xs_internal.c

2007-08-21 Thread Daniel Veillard
On Tue, Aug 21, 2007 at 09:58:27AM +0900, Atsushi SAKAI wrote: > Hi, Daniel > > That's a good idea. > Anyway some code seems to be assumed tab = 8spaces(not 4spaces), > I hope this kind of mis-spaces will be fixed. Well I actually looked at xenStoreOpen() which is one of the places your patch

Re: [Libvir] [PATCH] Cleanup xs_internal.c

2007-08-20 Thread Atsushi SAKAI
Hi, Daniel That's a good idea. Anyway some code seems to be assumed tab = 8spaces(not 4spaces), I hope this kind of mis-spaces will be fixed. Thanks Atsushi SAKAI Daniel Veillard <[EMAIL PROTECTED]> wrote: > On Mon, Aug 20, 2007 at 12:58:48PM +0100, Richard W.M. Jones wrote: > > Masayuki Sunou

Re: [Libvir] [PATCH] Cleanup xs_internal.c

2007-08-20 Thread Daniel Veillard
On Mon, Aug 20, 2007 at 12:58:48PM +0100, Richard W.M. Jones wrote: > Masayuki Sunou wrote: > >Hi > > > >Blanks and Tabs coexist in xs_internal.c. > >This patch replaces a tab by blanks in xs_internal.c. > > I'm not sure what our policy is for this. Emacs at least displays and > creates the opti

Re: [Libvir] [PATCH] Cleanup xs_internal.c

2007-08-20 Thread Richard W.M. Jones
Masayuki Sunou wrote: Hi Blanks and Tabs coexist in xs_internal.c. This patch replaces a tab by blanks in xs_internal.c. I'm not sure what our policy is for this. Emacs at least displays and creates the optimal mix of tabs and spaces, and assuming you have a sensible default of tabstops eve

[Libvir] [PATCH] Cleanup xs_internal.c

2007-08-17 Thread Masayuki Sunou
Hi Blanks and Tabs coexist in xs_internal.c. This patch replaces a tab by blanks in xs_internal.c. Signed-off-by: Masayuki Sunou <[EMAIL PROTECTED]> Thanks, Masayuki Sunou. tab_to_space.patch Description: Binary data -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/ma