Daniel P. Berrange [EMAIL PROTECTED] wrote:
Just discovered an accidental ommission in this patch - removed the listen_tls
and listen_tcp config param handling completely. So I've commited the attached
trivial patch to re-add them.
Thanks.
I'll adjust my upcoming config-test addition so that
Just discovered an accidental ommission in this patch - removed the listen_tls
and listen_tcp config param handling completely. So I've commited the attached
trivial patch to re-add them.
On Thu, Nov 29, 2007 at 07:35:47PM +0100, Jim Meyering wrote:
@@ -1521,166 +1654,103 @@
Daniel P. Berrange [EMAIL PROTECTED] wrote:
...
Can you commit the code changes, but leave out the config file changes - I've
re-written/structured major parts of the config file in my SASL patches, so
I'll just include the few typos you found in my updated patches.
Sure.
I've just done it.
On Thu, Nov 29, 2007 at 07:35:47PM +0100, Jim Meyering wrote:
Daniel P. Berrange [EMAIL PROTECTED] wrote:
On Wed, Nov 28, 2007 at 02:18:22PM +0100, Jim Meyering wrote:
I spotted a few unchecked heap allocations (strdup, malloc, calloc)
in qemud.c and have fixed it so such failure evokes a
Daniel P. Berrange [EMAIL PROTECTED] wrote:
On Wed, Nov 28, 2007 at 02:18:22PM +0100, Jim Meyering wrote:
I spotted a few unchecked heap allocations (strdup, malloc, calloc)
in qemud.c and have fixed it so such failure evokes a proper diagnostic
rather than e.g., a segfault.
Yep, good
I spotted a few unchecked heap allocations (strdup, malloc, calloc)
in qemud.c and have fixed it so such failure evokes a proper diagnostic
rather than e.g., a segfault.
I've also arranged to free some of the memory upon failure,
but not all (see comments for why).
In spite of those additions,
Worthwhile cleanups, ACK.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
On Wed, Nov 28, 2007 at 02:18:22PM +0100, Jim Meyering wrote:
I spotted a few unchecked heap allocations (strdup, malloc, calloc)
in qemud.c and have fixed it so such failure evokes a proper diagnostic
rather than e.g., a segfault.
Yep, good stuff.
I've also arranged to free some of the
Daniel P. Berrange wrote:
On Wed, Nov 28, 2007 at 02:18:22PM +0100, Jim Meyering wrote:
I spotted a few unchecked heap allocations (strdup, malloc, calloc)
in qemud.c and have fixed it so such failure evokes a proper diagnostic
rather than e.g., a segfault.
Yep, good stuff.
I've also
