Re: [Libvir] [PATCH] Device attach/detach on virsh (command optionversion)

2007-06-19 Thread Daniel Veillard
On Tue, Jun 19, 2007 at 05:38:58PM +0900, Masayuki Sunou wrote: > Hi > > Would you give me a comment on this patch? oh right, I knew I had forgotten it for 0.2.3 but didn't yet look at it again. Stylistically I would have preferred if creating the XML was done using the xmlBuffer APIs, but it's

Re: [Libvir] [PATCH] Device attach/detach on virsh (command optionversion)

2007-06-19 Thread Masayuki Sunou
Hi Would you give me a comment on this patch? Thanks, Masayuki Sunou. In message <[EMAIL PROTECTED]> "[Libvir] [PATCH] Device attach/detach on virsh (command optionversion)" "Masayuki Sunou <[EMAIL PROTECTED]>" wrote: > Hi > > This patch adds

Re: [Libvir] [PATCH] Device attach/detach on virsh (command optionversion)

2007-06-01 Thread Masayuki Sunou
Hi Would you give me a comment on this patch? Thanks, Masayuki Sunou. In message <[EMAIL PROTECTED]> "[Libvir] [PATCH] Device attach/detach on virsh (command optionversion)" "Masayuki Sunou <[EMAIL PROTECTED]>" wrote: Hi This patch adds virsh attach-devic