Re: [Libvir] [PATCH] Enable USB device setting information handling on virsh.

2007-03-29 Thread Daniel Veillard
On Thu, Mar 15, 2007 at 05:54:19PM +0900, Masayuki Sunou wrote: Hi Daniel I contribute some corrected patches. 1. strtok() -- strtok_r() -- Add tok_buf for strtok_r() 2. Correct the first argument of strtok_r() 3. Add a version of XML -- So that the format of XML may change in

Re: [Libvir] [PATCH] Enable USB device setting information handling on virsh.

2007-03-15 Thread Masayuki Sunou
) --- In message [EMAIL PROTECTED] Re: [Libvir] [PATCH] Enable USB device setting information handling on virsh. Daniel Veillard [EMAIL PROTECTED] wrote: On Wed, Mar 14, 2007 at 03:38:02AM +, Daniel P. Berrange wrote: I'm not so sure about this to be honest. This is very verbose syntax

Re: [Libvir] [PATCH] Enable USB device setting information handling on virsh.

2007-03-14 Thread Daniel Veillard
On Wed, Mar 14, 2007 at 03:38:02AM +, Daniel P. Berrange wrote: I'm not so sure about this to be honest. This is very verbose syntax and having the empty usb wrapper around every element isn't adding all that much useful info in relation to its verbosity. I based my review on the

Re: [Libvir] [PATCH] Enable USB device setting information handling on virsh.

2007-03-08 Thread Daniel P. Berrange
On Thu, Mar 08, 2007 at 04:52:43PM +0900, Masayuki Sunou wrote: Hi When domHVM started by virsh create, the information of USB setting is not saved by vish dumpxml. The reason is that USB setting is defined by Xen itself, not virsh. This patch enables USB device setting information

Re: [Libvir] [PATCH] Enable USB device setting information handling on virsh.

2007-03-08 Thread Daniel Veillard
On Thu, Mar 08, 2007 at 12:59:30PM +, Daniel P. Berrange wrote: On Thu, Mar 08, 2007 at 04:52:43PM +0900, Masayuki Sunou wrote: Hi When domHVM started by virsh create, the information of USB setting is not saved by vish dumpxml. The reason is that USB setting is defined by Xen

[Libvir] [PATCH] Enable USB device setting information handling on virsh.

2007-03-07 Thread Masayuki Sunou
Hi When domHVM started by virsh create, the information of USB setting is not saved by vish dumpxml. The reason is that USB setting is defined by Xen itself, not virsh. This patch enables USB device setting information handling on virsh create/virsh dumpxml. Signed-off-by: Masayuki Sunou