This patch has been applied.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
Jim Meyering wrote:
+/* In Xenstore, /local/domain/0/backend/vbd/domid/device/state,
+ * if available, must be XenbusStateConnected (= 4), otherwise there
+ * is no connected device.
+ */
+static int
+check_bd_connected (xenUnifiedPrivatePtr priv, int device, int domid)
+{
+char s[256], *rs;
Richard W.M. Jones [EMAIL PROTECTED] wrote:
...
That function should also check LEN (i.e., what if it's 0 or 1?).
Otherwise, STREQ might read uninitialized memory.
I've addressed that by doing something, hopefully the right thing, if
len == 0. (We would expect len == 1).
Yeah, you're right.
On Fri, Sep 28, 2007 at 10:26:05AM +0100, Richard W.M. Jones wrote:
Thanks Jim. Here is an updated patch which fixes this issue, and is
tested against Xen 3.1.
The principle of the patch sounds good to me, I didn't spot anything
obvious, but I didn't try to test it.
+1
Once it's in CVS
