Re: [Libvir] [PATCH] Fields in virDomainPtr which appear to be never used

2007-05-08 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Sat, May 05, 2007 at 11:25:00AM +0100, Richard W.M. Jones wrote: With this analysis in mind, attached is a patch which removes these three fields (path, flags, xml) and the unused virDomainFlags, with no apparent ill-effects. ACK, I'm all for removing code which i

Re: [Libvir] [PATCH] Fields in virDomainPtr which appear to be never used

2007-05-07 Thread Daniel P. Berrange
On Sat, May 05, 2007 at 11:25:00AM +0100, Richard W.M. Jones wrote: > Below is the definition of struct _virDomain from internal.h. I may be > missing something big (well, it wouldn't be the first time), but as far > as I can see some of these fields are never used, and some are set but > can n

[Libvir] [PATCH] Fields in virDomainPtr which appear to be never used

2007-05-05 Thread Richard W.M. Jones
Below is the definition of struct _virDomain from internal.h. I may be missing something big (well, it wouldn't be the first time), but as far as I can see some of these fields are never used, and some are set but can never be read. struct _virDomain { unsigned int magic; /* specific val