Re: [Libvir] [PATCH] Fix endless loop of VirBufferVSprintf()

2007-08-30 Thread Daniel Veillard
On Thu, Aug 30, 2007 at 11:29:34AM +0900, Masayuki Sunou wrote: Hi Would you give me a comment on this? This occurs when virsh create is executed by using the attached file. Yes, sorry when I first looked at the patch I though I needed to give it a deeper look because I misunderstood

[Libvir] [PATCH] Fix endless loop of VirBufferVSprintf()

2007-08-24 Thread Masayuki Sunou
Hi VirBufferVSprintf() loops endless when it receives over 2000 bytes, because the return value of vsnprintf() is more than size - 1. It is because the maximum of size is 1999 bytes. -- the maximum of buf-size - buf-use = 2000 (1000(argument of virBufferGrow()) + 1000(set in