Re: [Libvir] [PATCH] Fix strange message on virsh attach-device

2007-07-13 Thread Daniel Veillard
On Fri, Jul 13, 2007 at 12:29:40PM +0100, Richard W.M. Jones wrote: Masayuki Sunou wrote: +} else { +goto error; It'd be better to add a call to virXMLError in there, but other than that the patch is fine. I needed to check first who called that routine, but it is only used

Re: [Libvir] [PATCH] Fix strange message on virsh attach-device

2007-07-13 Thread Richard W.M. Jones
Masayuki Sunou wrote: +} else { +goto error; It'd be better to add a call to virXMLError in there, but other than that the patch is fine. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod

[Libvir] [PATCH] Fix strange message on virsh attach-device

2007-07-12 Thread Masayuki Sunou
Hi Virsh attach-device outputs a strange message, when XML whose top element is not device or interface. -- libvir: Xen Daemon error : POST operation failed: (xend.err object of type 'NoneType' has no len()) error: Failed to