Re: [Libvir] [PATCH] Fix substitution of QEMUD_PID_FILE

2007-04-04 Thread Richard W.M. Jones
Mark McLoughlin wrote: On Tue, 2007-04-03 at 12:47 +0100, Richard W.M. Jones wrote: Are we good to commit this patch and the preceeding one (adding help to libvirt qemu daemon)? They both look good to me. OK, so no one else objected and they both seemed pretty uncontroversial, so

[Libvir] [PATCH] Fix substitution of QEMUD_PID_FILE

2007-04-03 Thread Richard W.M. Jones
This fixes the bug I raised in my previous email. Use AC_SUBST instead of AC_DEFINE because we want autoconf to substitute the value into the Makefile, not into config.h. Then add @QEMUD_PID_FILE@ to CFLAGS. This seems to be the correct thing to do, according to my understanding of

Re: [Libvir] [PATCH] Fix substitution of QEMUD_PID_FILE

2007-04-03 Thread Richard W.M. Jones
Mark McLoughlin wrote: On Tue, 2007-04-03 at 11:40 +0100, Richard W.M. Jones wrote: Use AC_SUBST instead of AC_DEFINE because we want autoconf to substitute the value into the Makefile, not into config.h. Then add @QEMUD_PID_FILE@ to CFLAGS. Sounds sane ... Bear in mind,