Re: [Libvir] [PATCH] Have xen fv acknowledge boot tag

2008-03-07 Thread Daniel Veillard
On Thu, Mar 06, 2008 at 11:37:19AM -0500, Cole Robinson wrote: Yeah it was basically just poor checking. If there was no loader tag, loader == NULL, which caused STRNEQ to segfault. Corrected patch attached. I verified all the tests passed as expected. Okay, I see, applied, I just fully

Re: [Libvir] [PATCH] Have xen fv acknowledge boot tag

2008-03-06 Thread Cole Robinson
Daniel Veillard wrote: On Wed, Mar 05, 2008 at 05:26:47PM -0500, Cole Robinson wrote: https://bugzilla.redhat.com/show_bug.cgi?id=428868 Defining a xen fullvirt guest with a boot dev={hd,cdrom,etc.} tag currently ignores this tag and forces in a kernel tag. Dan pointed out the fix in the

[Libvir] [PATCH] Have xen fv acknowledge boot tag

2008-03-05 Thread Cole Robinson
https://bugzilla.redhat.com/show_bug.cgi?id=428868 Defining a xen fullvirt guest with a boot dev={hd,cdrom,etc.} tag currently ignores this tag and forces in a kernel tag. Dan pointed out the fix in the bz, which I verified does the trick. Patch attached. Thanks, Cole diff --git

Re: [Libvir] [PATCH] Have xen fv acknowledge boot tag

2008-03-05 Thread Daniel Veillard
On Wed, Mar 05, 2008 at 05:26:47PM -0500, Cole Robinson wrote: https://bugzilla.redhat.com/show_bug.cgi?id=428868 Defining a xen fullvirt guest with a boot dev={hd,cdrom,etc.} tag currently ignores this tag and forces in a kernel tag. Dan pointed out the fix in the bz, which I verified does