Re: [Libvir] [PATCH] change a Disk/Nic of inactive domain

2008-02-06 Thread Daniel Veillard
On Tue, Feb 05, 2008 at 04:00:14PM -0800, Ryan Scott wrote: Resurrecting a two-week old thread... Was a version of this patch ever committed? I don't see it, but I may have missed it. I used an earlier version of the patch to fix a problem we've noticed, but I would like to see the

Re: [Libvir] [PATCH] change a Disk/Nic of inactive domain

2008-02-06 Thread Richard W.M. Jones
Daniel Veillard wrote: On Tue, Feb 05, 2008 at 04:00:14PM -0800, Ryan Scott wrote: Resurrecting a two-week old thread... Was a version of this patch ever committed? I don't see it, but I may have missed it. I used an earlier version of the patch to fix a problem we've noticed, but I would

Re: [Libvir] [PATCH] change a Disk/Nic of inactive domain

2008-02-05 Thread Ryan Scott
Resurrecting a two-week old thread... Was a version of this patch ever committed? I don't see it, but I may have missed it. I used an earlier version of the patch to fix a problem we've noticed, but I would like to see the final version of the patch. Thanks, Ryan S.Sakamoto wrote:

Re: [Libvir] [PATCH] change a Disk/Nic of inactive domain

2008-01-21 Thread S.Sakamoto
These struct definitions *intentionally* private. Oops, I did not notice it... I revised a patch not to access the struct data directly. In principle this patch looks good. If no one else objects, I'll commit this, with a few of my own fixes (below). Rich. +

Re: [Libvir] [PATCH] change a Disk/Nic of inactive domain

2008-01-19 Thread Daniel Veillard
On Mon, Jan 14, 2008 at 01:51:56PM +, Daniel P. Berrange wrote: On Mon, Jan 14, 2008 at 12:25:44PM +, Richard W.M. Jones wrote: S.Sakamoto wrote: These struct definitions *intentionally* private. Oops, I did not notice it... I revised a patch not to access the struct data

Re: [Libvir] [PATCH] change a Disk/Nic of inactive domain

2008-01-14 Thread Richard W.M. Jones
S.Sakamoto wrote: These struct definitions *intentionally* private. Oops, I did not notice it... I revised a patch not to access the struct data directly. In principle this patch looks good. If no one else objects, I'll commit this, with a few of my own fixes (below). Rich. +

Re: [Libvir] [PATCH] change a Disk/Nic of inactive domain

2008-01-14 Thread Daniel P. Berrange
On Mon, Jan 14, 2008 at 12:25:44PM +, Richard W.M. Jones wrote: S.Sakamoto wrote: These struct definitions *intentionally* private. Oops, I did not notice it... I revised a patch not to access the struct data directly. In principle this patch looks good. If no one else objects, I'll

Re: [Libvir] [PATCH] change a Disk/Nic of inactive domain

2008-01-08 Thread Daniel P. Berrange
On Tue, Jan 08, 2008 at 02:04:00PM +0900, S.Sakamoto wrote: Hi The libvirt on Xen-3.03 does not have the function that add/change/delete a Disk/NIC of inactive domain. So, I made a patch which enabled add/change/delete of Disk/NIC of inactive domain. This patch will be able to change

[Libvir] [PATCH] change a Disk/Nic of inactive domain

2008-01-07 Thread S.Sakamoto
Hi The libvirt on Xen-3.03 does not have the function that add/change/delete a Disk/NIC of inactive domain. So, I made a patch which enabled add/change/delete of Disk/NIC of inactive domain. This patch will be able to change disk or vif parameter in configuration file with