Jim Meyering wrote:
Dave Leskovec [EMAIL PROTECTED] wrote:
...
+#ifndef _SIGNAL_H
+#include signal.h
+#endif
In practice it's fine to include signal.h unconditionally,
and even multiple times. Have you encountered a version of signal.h
that may not be included twice? If so, it probably
Dave Leskovec [EMAIL PROTECTED] wrote:
Jim Meyering wrote:
Dave Leskovec [EMAIL PROTECTED] wrote:
...
+#ifndef _SIGNAL_H
+#include signal.h
+#endif
In practice it's fine to include signal.h unconditionally,
and even multiple times. Have you encountered a version of signal.h
that may not
On Wed, Apr 30, 2008 at 11:38:01PM -0700, Dave Leskovec wrote:
This patch allows the lxc driver to handle SIGCHLD signals from exiting
containers. The handling will perform some cleanup such as waiting for
the container process and killing/waiting the tty process. This is also
required as a
Daniel P. Berrange wrote:
On Wed, Apr 30, 2008 at 11:38:01PM -0700, Dave Leskovec wrote:
This patch allows the lxc driver to handle SIGCHLD signals from exiting
containers. The handling will perform some cleanup such as waiting for
the container process and killing/waiting the tty process.
On Mon, May 05, 2008 at 02:33:09PM -0700, Dave Leskovec wrote:
Daniel P. Berrange wrote:
On Wed, Apr 30, 2008 at 11:38:01PM -0700, Dave Leskovec wrote:
This patch allows the lxc driver to handle SIGCHLD signals from exiting
containers. The handling will perform some cleanup such as waiting
Hi Jim,
Thanks for the review. Answers below -
Jim Meyering wrote:
Dave Leskovec [EMAIL PROTECTED] wrote:
This patch allows the lxc driver to handle SIGCHLD signals from exiting
...
Hi Dave,
At least superficially, this looks fine.
Two questions:
Index: b/src/driver.h
Dave Leskovec [EMAIL PROTECTED] wrote:
...
+#ifndef_SIGNAL_H
+#include signal.h
+#endif
In practice it's fine to include signal.h unconditionally,
and even multiple times. Have you encountered a version of signal.h
that may not be included twice? If so, it probably deserves a comment
