Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-27 Thread Richard W.M. Jones
On Wed, Feb 27, 2008 at 02:27:30PM +0900, S.Sakamoto wrote: OK, try this patch. I tried this patch. It works fine to me. Yes, the patch works for me too. I'll commit this end of today unless anyone objects. Rich. -- Richard Jones, Emerging Technologies, Red Hat

Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-27 Thread Richard W.M. Jones
This patch has been committed now. Thanks for your contribution to libvirt. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen

[Libvir] [PATCH]Change MAC address to case insensitive

2008-02-26 Thread S.Sakamoto
Hi, xenXMDomainAttachDevice and xenXMDomainDetachDevice treats case sensitve for MAC address of stopping domain. This patch changes from case sensitive to case insensitive. Thanks, Shigeki Sakamoto. Index: src/xm_internal.c ===

Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-26 Thread Richard W.M. Jones
I'll apply this today (using our STRCASEEQ macros) if no one else objects. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen

Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-26 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: I'll apply this today (using our STRCASEEQ macros) if no one else objects. Hi, What do you think about using a MAC-address-specific comparison function? I.e., one that is not only case-independent, but that also knows leading zeros are unnecessary?

Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-26 Thread Daniel P. Berrange
On Tue, Feb 26, 2008 at 12:13:43PM +0100, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: I'll apply this today (using our STRCASEEQ macros) if no one else objects. Hi, What do you think about using a MAC-address-specific comparison function? I.e., one that is not only

Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-26 Thread Richard W.M. Jones
On Tue, Feb 26, 2008 at 12:54:15PM +, Daniel P. Berrange wrote: On Tue, Feb 26, 2008 at 12:13:43PM +0100, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: I'll apply this today (using our STRCASEEQ macros) if no one else objects. Hi, What do you think about

Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-26 Thread S.Sakamoto
OK, try this patch. I tried this patch. It works fine to me. Shigeki Sakamoto. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list