Hi, Rich
Don't know ... I've been thinking about this on and off for a while, and
I can't see a good way to fix it.
Thank you for your reply and showing your policy.
I agree that there is no *fundamental* solution without the support of XenD.
Thanks,
Kazuki Mizushima
--
Libvir-list mailing l
Kazuki Mizushima wrote:
Hi,
under layer, XenD or so. I'II try to put this into XenD.
I tried to put xen community, it rejects.
[For reference, here is the thread on xen-devel]
http://lists.xensource.com/archives/html/xen-devel/2007-03/threads.html#00298
Though I am understanding follwing
Hi,
under layer, XenD or so. I'II try to put this into XenD.
I tried to put xen community, it rejects.
Though I am understanding follwing,
Isn't there something good way ?
There is really no way virsh/libvirt can reliably check for dump
or save file existance - only XenD or QEMU can do t
On Tue, Mar 06, 2007 at 01:55:19PM +0900, Kazuki Mizushima wrote:
>
> >My other problem is the use of stat(2) (or access) to determine if a
> >file exists, since we up on slippy ground if this is relied upon in a
> >security-related context. It's better to make the atomic open(2) call
> >fail ins
le is existing or not.
The xenXMDriver uses it which isn't a file(S_ISREG).
Thanks,
Kazuki Mizushima
- Original Message -
From: "Richard W.M. Jones" <[EMAIL PROTECTED]>
To:
Sent: Monday, March 05, 2007 8:30 PM
Subject: Re: [Libvir] [PATCH]Reprt error for a existing file
shima
- Original Message -
From: "Daniel P. Berrange" <[EMAIL PROTECTED]>
To: "Kazuki Mizushima" <[EMAIL PROTECTED]>
Cc:
Sent: Tuesday, March 06, 2007 1:26 AM
Subject: Re: [Libvir] [PATCH]Reprt error for a existing file
On Mon, Mar 05, 2007 at 06:04:49PM +0900, K
On Mon, Mar 05, 2007 at 06:04:49PM +0900, Kazuki Mizushima wrote:
> Hi,
>
> I make a patch which reports error for a existing file to prevent
> overwriting before the file.
> diff -u -p -r1.58 virsh.c
> --- src/virsh.c 2 Mar 2007 14:22:33 - 1.58
> +++ src/virsh.c 5 Mar 2007 06:49:28 -
Kazuki Mizushima wrote:
> Hi,
> I make a patch which reports error for a existing file to prevent
> overwriting before the file.
>
> # ./virsh dump 1 a.dump
> error: file a.dump exists already
> @@ -871,6 +873,11 @@ cmdSave(vshControl * ctl, vshCmd * cmd)
> if (!(dom = vshCommandOptDomain(ct
Hi,
I make a patch which reports error for a existing file to prevent
overwriting before the file.
# ./virsh dump 1 a.dump
error: file a.dump exists already
# echo $?
1
# ./virsh save 1 a.save
error: file a.save exists already
# echo $?
1
As you know, we need to add this message item to libvi
