Re: [Libvir] [PATCH 1/2] Add internal API for managing capabilities data

2008-02-26 Thread Richard W.M. Jones
Yes, this all looks good. Another advantage of doing this is that we can be sure that the capabilities XML generated by each driver will have the same schema. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual

Re: [Libvir] [PATCH 1/2] Add internal API for managing capabilities data

2008-02-26 Thread Daniel P. Berrange
On Tue, Feb 26, 2008 at 09:39:49AM +, Richard W.M. Jones wrote: Yes, this all looks good. Another advantage of doing this is that we can be sure that the capabilities XML generated by each driver will have the same schema. Yes indeed - this is a very good benefit, particularly as we

Re: [Libvir] [PATCH 1/2] Add internal API for managing capabilities data

2008-02-26 Thread Daniel Veillard
On Tue, Feb 26, 2008 at 12:52:32PM +, Daniel P. Berrange wrote: On Tue, Feb 26, 2008 at 09:39:49AM +, Richard W.M. Jones wrote: Yes, this all looks good. Another advantage of doing this is that we can be sure that the capabilities XML generated by each driver will have the

Re: [Libvir] [PATCH 1/2] Add internal API for managing capabilities data

2008-02-26 Thread Daniel P. Berrange
On Tue, Feb 26, 2008 at 08:24:53AM -0500, Daniel Veillard wrote: On Tue, Feb 26, 2008 at 12:52:32PM +, Daniel P. Berrange wrote: On Tue, Feb 26, 2008 at 09:39:49AM +, Richard W.M. Jones wrote: Yes, this all looks good. Another advantage of doing this is that we can be sure

Re: [Libvir] [PATCH 1/2] Add internal API for managing capabilities data

2008-02-25 Thread Daniel P. Berrange
This patch adds the files src/capabilities.{c,h} providing an internal API for dealing with capabilities data. All the struct's defined in the header map 1-to-1 onto the structure of the XML capabilities data. Since these definitions are internal only we are not stuck with ABI constraints on