[Libvir] [PATCH 3/3] Python cygvirtmod.dll - libvirtmod.dll

2007-11-29 Thread Richard W.M. Jones
Cygwin likes to name DLLs as cygname.dll. This is very unhelpful for Python loadable modules because the init function name will be wrong and because it requires a change to the 'libvirt.py' file to load the right module name (import libvirtmod - import cygvirtmod). In this patch I've added

Re: [Libvir] [PATCH 3/3] Python cygvirtmod.dll - libvirtmod.dll

2007-11-29 Thread Daniel Veillard
On Thu, Nov 29, 2007 at 04:58:42PM +, Richard W.M. Jones wrote: Cygwin likes to name DLLs as cygname.dll. This is very unhelpful for Python loadable modules because the init function name will be wrong and because it requires a change to the 'libvirt.py' file to load the right module

Re: [Libvir] [PATCH 3/3] Python cygvirtmod.dll - libvirtmod.dll

2007-11-29 Thread Richard W.M. Jones
Daniel Veillard wrote: On Thu, Nov 29, 2007 at 04:58:42PM +, Richard W.M. Jones wrote: Cygwin likes to name DLLs as cygname.dll. This is very unhelpful for Python loadable modules because the init function name will be wrong and because it requires a change to the 'libvirt.py' file to

Re: [Libvir] [PATCH 3/3] Python cygvirtmod.dll - libvirtmod.dll

2007-11-29 Thread Daniel P. Berrange
On Thu, Nov 29, 2007 at 05:34:28PM +, Richard W.M. Jones wrote: Daniel Veillard wrote: On Thu, Nov 29, 2007 at 04:58:42PM +, Richard W.M. Jones wrote: Cygwin likes to name DLLs as cygname.dll. #ifdef CYGWIN void initcygvirtmod(void) { initlibvirtmod(); } #endif might be

Re: [Libvir] [PATCH 3/3] Python cygvirtmod.dll - libvirtmod.dll

2007-11-29 Thread Daniel Veillard
On Thu, Nov 29, 2007 at 07:28:32PM +, Daniel P. Berrange wrote: On Thu, Nov 29, 2007 at 05:34:28PM +, Richard W.M. Jones wrote: Daniel Veillard wrote: On Thu, Nov 29, 2007 at 04:58:42PM +, Richard W.M. Jones wrote: Cygwin likes to name DLLs as cygname.dll. #ifdef CYGWIN

Re: [Libvir] [PATCH 3/3] Python cygvirtmod.dll - libvirtmod.dll

2007-11-29 Thread Richard W.M. Jones
Daniel Veillard wrote: On Thu, Nov 29, 2007 at 07:28:32PM +, Daniel P. Berrange wrote: On Thu, Nov 29, 2007 at 05:34:28PM +, Richard W.M. Jones wrote: Daniel Veillard wrote: On Thu, Nov 29, 2007 at 04:58:42PM +, Richard W.M. Jones wrote: Cygwin likes to name DLLs as cygname.dll.

Re: [Libvir] [PATCH 3/3] Python cygvirtmod.dll - libvirtmod.dll

2007-11-29 Thread David Mueller
Daniel Veillard wrote: hum, I think it would also require a change to the python C file to rename the entry point too, otherwise a simple try: import libvirtmod except: import cygvirtmod might have done it. I would use try: import libvirtmod except:

Re: [Libvir] [PATCH 3/3] Python cygvirtmod.dll - libvirtmod.dll

2007-11-29 Thread Daniel Veillard
On Thu, Nov 29, 2007 at 07:41:18PM -0800, David Mueller wrote: Daniel Veillard wrote: hum, I think it would also require a change to the python C file to rename the entry point too, otherwise a simple try: import libvirtmod except: import cygvirtmod might have done