Re: [Libvir] [RFC] 0 of 4 Linux Container support

2008-03-21 Thread Daniel Veillard
On Thu, Mar 20, 2008 at 01:25:05PM -0400, Daniel Veillard wrote: On Thu, Mar 20, 2008 at 10:20:22AM -0700, Dave Leskovec wrote: Daniel Veillard wrote: I would rather keep the type attribute value small, and if possible the same as the one used for the connection URIs, 'lxr' would be

Re: [Libvir] [RFC] 0 of 4 Linux Container support

2008-03-21 Thread Daniel Veillard
On Fri, Mar 21, 2008 at 10:17:35AM -0700, Dave Leskovec wrote: Daniel Veillard wrote: I will look now at cleaning up the parsing code as explained in my review, that I can do easilly, Excellent. Thanks! No problem, BTW I'm having a bit of troubles with lxcLoadConfig() it loads fine

Re: [Libvir] [RFC] 0 of 4 Linux Container support

2008-03-21 Thread Daniel P. Berrange
On Fri, Mar 21, 2008 at 01:29:07PM -0400, Daniel Veillard wrote: On Fri, Mar 21, 2008 at 10:17:35AM -0700, Dave Leskovec wrote: Daniel Veillard wrote: I will look now at cleaning up the parsing code as explained in my review, that I can do easilly, Excellent. Thanks! No

Re: [Libvir] [RFC] 0 of 4 Linux Container support

2008-03-21 Thread Daniel Veillard
On Fri, Mar 21, 2008 at 05:39:51PM +, Daniel P. Berrange wrote: On Fri, Mar 21, 2008 at 01:29:07PM -0400, Daniel Veillard wrote: Another small issue is that I have the clone flags defined in linux/sched.h but not in sched.h so I had to add that include to get the module to compile,

Re: [Libvir] [RFC] 0 of 4 Linux Container support

2008-03-21 Thread Daniel P. Berrange
On Fri, Mar 21, 2008 at 04:35:34PM -0400, Daniel Veillard wrote: On Fri, Mar 21, 2008 at 05:39:51PM +, Daniel P. Berrange wrote: On Fri, Mar 21, 2008 at 01:29:07PM -0400, Daniel Veillard wrote: Another small issue is that I have the clone flags defined in linux/sched.h but not in

[Libvir] [RFC] 0 of 4 Linux Container support

2008-03-20 Thread Dave Leskovec
Greetings, Following are the patches adding linux container support. The first three patches are updated versions of the original three I posted. They've been updated for the feedback I've received so far and to include some other recent libvirt changes. The last patch adds support for

Re: [Libvir] [RFC] 0 of 4 Linux Container support

2008-03-20 Thread Vivek Kashyap
snip... The XML format has been updated to this: domain type='linuxcontainer' I would rather keep the type attribute value small, and if possible the same as the one used for the connection URIs, 'lxr' would be just fine IMHO I suggest 'lxc' since that is what we are using for containers

Re: [Libvir] [RFC] 0 of 4 Linux Container support

2008-03-20 Thread Daniel Veillard
On Thu, Mar 20, 2008 at 09:46:05AM -0700, Vivek Kashyap wrote: snip... The XML format has been updated to this: domain type='linuxcontainer' I would rather keep the type attribute value small, and if possible the same as the one used for the connection URIs, 'lxr' would be just fine