Re: [Libvir] [patch] virsh setvcpus range check for negative value case

2007-08-15 Thread Atsushi SAKAI
Hi, Daniel  Thank you for your reviewing. I agree your fixes. Also I agree this issue should be handled by hypervisor. But for Xen, if # of vcpus are out of range, XEN_DOMCTL_setvcpu_context return the -EINVAL. So the inactive domain cannot boot. For this circumstances, it is better to handle #

Re: [Libvir] [patch] virsh setvcpus range check for negative value case

2007-08-15 Thread Daniel Veillard
On Wed, Aug 15, 2007 at 05:01:04PM +0900, Atsushi SAKAI wrote: > Hi, > > This patch adds virsh setvcpus range check for negative value case. > > for example > to the inactive domain > virsh setvcpus -1 > sets vcpus=4294967295 > And cannot boot the inactive domain. I would rather change the t

[Libvir] [patch] virsh setvcpus range check for negative value case

2007-08-15 Thread Atsushi SAKAI
Hi, This patch adds virsh setvcpus range check for negative value case. for example to the inactive domain virsh setvcpus -1 sets vcpus=4294967295 And cannot boot the inactive domain. Signed-off-by: Atsushi SAKAI <[EMAIL PROTECTED]> Thanks Atsushi SAKAI setvcpu_rangecheck.patch Descriptio