Re: [Libvir] 1/8 remove useless "if (foo)" tests

2008-01-29 Thread Richard W.M. Jones
Jim Meyering wrote: Given code like if (foo) free (foo); remove the useless "if (foo) " part. Likewise, given if (foo != NULL) free (foo); remove the useless "if" test. ACK. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley P

Re: [Libvir] 1/8 remove useless "if (foo)" tests

2008-01-29 Thread Daniel P. Berrange
On Fri, Jan 25, 2008 at 11:17:09PM +0100, Jim Meyering wrote: > Given code like if (foo) free (foo); remove the useless "if (foo) " part. > > Likewise, given if (foo != NULL) free (foo); remove the useless "if" test. ACK - already reviewed the previous version of it. Dan -- |=- Red Hat, Enginee

[Libvir] 1/8 remove useless "if (foo)" tests

2008-01-25 Thread Jim Meyering
Given code like if (foo) free (foo); remove the useless "if (foo) " part. Likewise, given if (foo != NULL) free (foo); remove the useless "if" test. * proxy/libvirt_proxy.c: Remove unnecessary "if" test before free. * python/generator.py: Likewise. * qemud/qemud.c: Likewise. * src/buf.c: Likewise