Re: [Libvir] MinGW patch

2008-04-21 Thread Atsushi SAKAI
Hi, Rich I have 2 questions about MinGW fixes. (It has already committed, sorry for delaying) 1)src/storage_driver.c patch I think storage_driver.c is not compiled on MinGW. So It should remove HAVE_PWD_H in src/storage_driver.c

Re: [Libvir] MinGW patch

2008-04-21 Thread Richard W.M. Jones
On Mon, Apr 21, 2008 at 03:56:39PM +0900, Atsushi SAKAI wrote: Hi, Rich I have 2 questions about MinGW fixes. (It has already committed, sorry for delaying) 1)src/storage_driver.c patch I think storage_driver.c is not compiled on MinGW. So It should remove HAVE_PWD_H in

Re: [Libvir] MinGW patch

2008-04-21 Thread Atsushi SAKAI
Hi, Rich Richard W.M. Jones [EMAIL PROTECTED] wrote: 2)src/util.c patch I think sys/wait.h(waitpid) has not supported on MinGW. So I think it should add check (HAVE_SYS_WAIT_H) on waitpid() to avoid compilation warnings. OK thanks. This compiles for me, but I agree that if a

Re: [Libvir] MinGW patch

2008-04-21 Thread Richard W.M. Jones
On Mon, Apr 21, 2008 at 07:28:29PM +0900, Atsushi SAKAI wrote: I think following patch seems good (but not tested yet by me.) http://cvsweb.xfree86.org/cvsweb/cvs/windows-NT/waitpid.c?rev=HEAD Yes, that looks good. Gnulib actually contains a wait-process module which basically implements that

[Libvir] MinGW patch

2008-04-17 Thread Richard W.M. Jones
I got about 95% of the way towards compiling on MinGW using the MinGW cross-compiler from http://mirzam.it.vu.nl/mingw/. Attached are some fairly non-controversial patches which fix some of the problems I found. Build notes follow below. Rich.

Re: [Libvir] MinGW patch

2008-04-17 Thread Daniel P. Berrange
On Thu, Apr 17, 2008 at 08:04:59PM +0100, Richard W.M. Jones wrote: I got about 95% of the way towards compiling on MinGW using the MinGW cross-compiler from http://mirzam.it.vu.nl/mingw/. Attached are some fairly non-controversial patches which fix some of the problems I found. Build notes

Re: [Libvir] MinGW patch

2008-04-17 Thread Daniel Veillard
On Thu, Apr 17, 2008 at 08:04:59PM +0100, Richard W.M. Jones wrote: I got about 95% of the way towards compiling on MinGW using the MinGW cross-compiler from http://mirzam.it.vu.nl/mingw/. Attached are some fairly non-controversial patches which fix some of the problems I found. Build notes

Re: [Libvir] MinGW patch

2008-04-17 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: I got about 95% of the way towards compiling on MinGW using the MinGW cross-compiler from http://mirzam.it.vu.nl/mingw/. Attached are some fairly non-controversial patches which fix some of the problems I found. Build notes follow below. ...