Re: [Libvir] PATCH: Allow updating of timer & file handle event watches

2007-09-19 Thread Daniel Veillard
On Wed, Sep 19, 2007 at 03:04:12AM +0100, Daniel P. Berrange wrote: > On Tue, Sep 18, 2007 at 03:49:02AM -0400, Daniel Veillard wrote: > > From a stylistic POV I notice the function comment description is in the > > header files, not in the C file like others parts of libvirt, as long as > > one

Re: [Libvir] PATCH: Allow updating of timer & file handle event watches

2007-09-18 Thread Daniel P. Berrange
On Tue, Sep 18, 2007 at 03:49:02AM -0400, Daniel Veillard wrote: > On Tue, Sep 18, 2007 at 02:56:35AM +0100, Daniel P. Berrange wrote: > > The forthcoming patch to add Avahi support requires a couple of enhancements > > to our event loop to support integration with Avahi's event callback needs > >

Re: [Libvir] PATCH: Allow updating of timer & file handle event watches

2007-09-18 Thread Daniel Veillard
On Tue, Sep 18, 2007 at 02:56:35AM +0100, Daniel P. Berrange wrote: > The forthcoming patch to add Avahi support requires a couple of enhancements > to our event loop to support integration with Avahi's event callback needs > > - Ability to update the event mask for a pre-existing file handle wat

[Libvir] PATCH: Allow updating of timer & file handle event watches

2007-09-17 Thread Daniel P. Berrange
The forthcoming patch to add Avahi support requires a couple of enhancements to our event loop to support integration with Avahi's event callback needs - Ability to update the event mask for a pre-existing file handle watch - Ability to change the frequency of a timer watch - Ability to have a