Re: [Libvir] PATCH: Avoid format string abuse (also avoids gcc warnings).

2007-11-07 Thread Richard W.M. Jones
Jim Meyering wrote: "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: On Tue, Nov 06, 2007 at 08:31:06PM +0100, Jim Meyering wrote: This patch was prompted by warnings like this: util.c:56: warning: format not a string literal and no format arguments Hmm, what compiler version are you using ?

Re: [Libvir] PATCH: Avoid format string abuse (also avoids gcc warnings).

2007-11-06 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On Tue, Nov 06, 2007 at 08:31:06PM +0100, Jim Meyering wrote: >> This patch was prompted by warnings like this: >> >> util.c:56: warning: format not a string literal and no format arguments > > Hmm, what compiler version are you using ? I don't se

[Libvir] PATCH: Avoid format string abuse (also avoids gcc warnings).

2007-11-06 Thread Jim Meyering
[resending with the patch in-line, not as an attachment -- mailman removed my attached patch the first time! Bad mailman. Bad. ] This patch was prompted by warnings like this: util.c:56: warning: format not a string literal and no format arguments and they're legitimate. Imagine a format s

Re: [Libvir] PATCH: Avoid format string abuse (also avoids gcc warnings).

2007-11-06 Thread Daniel P. Berrange
On Tue, Nov 06, 2007 at 08:31:06PM +0100, Jim Meyering wrote: > This patch was prompted by warnings like this: > > util.c:56: warning: format not a string literal and no format arguments Hmm, what compiler version are you using ? I don't see those warnings when I build. Or did you add extra com

[Libvir] PATCH: Avoid format string abuse (also avoids gcc warnings).

2007-11-06 Thread Jim Meyering
This patch was prompted by warnings like this: util.c:56: warning: format not a string literal and no format arguments and they're legitimate. Imagine a format string contains "%%..." goes through the vnsprintf call, which reduces it to "%...". If the result string is then passed to __virRais