Re: [Libvir] PATCH: Fix accident close of monitor FD & leak of logfile FD to child

2007-07-19 Thread Daniel Veillard
On Thu, Jul 19, 2007 at 01:52:00AM +0100, Daniel P. Berrange wrote: > After the QEMU monitor filehandle has been successfully initialized, we > then promptly close it ! It seems a 'return' statement accidentally got > removed somewhere during previously refactoring. > > Second, the QEMU logfile do

[Libvir] PATCH: Fix accident close of monitor FD & leak of logfile FD to child

2007-07-18 Thread Daniel P. Berrange
After the QEMU monitor filehandle has been successfully initialized, we then promptly close it ! It seems a 'return' statement accidentally got removed somewhere during previously refactoring. Second, the QEMU logfile does not have the close-on-exec flag set so the logfile is leaked to child proce