Re: [Libvir] PATCH: make debug builds quiet by default

2008-01-19 Thread Daniel Veillard
On Wed, Jan 16, 2008 at 09:56:16AM +, Richard W.M. Jones wrote: Daniel P. Berrange wrote: How about this patch. I define VIR_DEBUG in src/internal.c. Each module which wants to output debug messages adds #define DEBUG(fmt,...) VIR_DEBUG(driver, fmt, __VA_ARGS__) #define DEBUG0(msg)

Re: [Libvir] PATCH: make debug builds quiet by default

2008-01-19 Thread Daniel P. Berrange
On Sat, Jan 19, 2008 at 05:11:26AM -0500, Daniel Veillard wrote: On Wed, Jan 16, 2008 at 09:56:16AM +, Richard W.M. Jones wrote: Daniel P. Berrange wrote: How about this patch. I define VIR_DEBUG in src/internal.c. Each module which wants to output debug messages adds #define

Re: [Libvir] PATCH: make debug builds quiet by default

2008-01-16 Thread Richard W.M. Jones
Daniel P. Berrange wrote: How about this patch. I define VIR_DEBUG in src/internal.c. Each module which wants to output debug messages adds #define DEBUG(fmt,...) VIR_DEBUG(driver, fmt, __VA_ARGS__) #define DEBUG0(msg) VIR_DEBUG(driver, %s, msg) Changing 'driver' to whatever their module

Re: [Libvir] PATCH: make debug builds quiet by default

2008-01-15 Thread Daniel P. Berrange
On Mon, Jan 14, 2008 at 12:21:44PM +, Richard W.M. Jones wrote: Daniel Veillard wrote: On Wed, Jan 09, 2008 at 05:13:47AM +, Daniel P. Berrange wrote: During development I like to have the --enable-debug flag enabled all the time because its very handy at times. I don't want it spewing

Re: [Libvir] PATCH: make debug builds quiet by default

2008-01-15 Thread Daniel P. Berrange
On Tue, Jan 15, 2008 at 03:02:55PM +, Daniel P. Berrange wrote: On Mon, Jan 14, 2008 at 12:21:44PM +, Richard W.M. Jones wrote: Daniel Veillard wrote: On Wed, Jan 09, 2008 at 05:13:47AM +, Daniel P. Berrange wrote: During development I like to have the --enable-debug flag

Re: [Libvir] PATCH: make debug builds quiet by default

2008-01-14 Thread Richard W.M. Jones
Daniel Veillard wrote: On Wed, Jan 09, 2008 at 05:13:47AM +, Daniel P. Berrange wrote: During development I like to have the --enable-debug flag enabled all the time because its very handy at times. I don't want it spewing to stderr all the time though, just because I turned on the compile

[Libvir] PATCH: make debug builds quiet by default

2008-01-08 Thread Daniel P. Berrange
During development I like to have the --enable-debug flag enabled all the time because its very handy at times. I don't want it spewing to stderr all the time though, just because I turned on the compile option. So this patch adds an env variable 'LIBVIRT_DEBUG' which controls whether it is chatty

Re: [Libvir] PATCH: make debug builds quiet by default

2008-01-08 Thread Daniel Veillard
On Wed, Jan 09, 2008 at 05:13:47AM +, Daniel P. Berrange wrote: During development I like to have the --enable-debug flag enabled all the time because its very handy at times. I don't want it spewing to stderr all the time though, just because I turned on the compile option. So this patch