Re: [Libvir] PATCH Fix a couple of mem leaks

2007-07-31 Thread Richard W.M. Jones
Daniel P. Berrange wrote: I ran 'make valgrind' for the first time in too long and found a hanful of memory leaks in code exercised by the test suite. The attached patch fixes them all. +1 I'm sure there are more lurking though - the test suite is mainly focused on exercising & validating cor

Re: [Libvir] PATCH Fix a couple of mem leaks

2007-07-31 Thread Daniel Veillard
On Mon, Jul 30, 2007 at 10:19:17PM +0100, Daniel P. Berrange wrote: > On Mon, Jul 30, 2007 at 10:14:25PM +0100, Daniel P. Berrange wrote: > > I ran 'make valgrind' for the first time in too long and found a hanful of > > memory leaks in code exercised by the test suite. The attached patch fixes > >

Re: [Libvir] PATCH Fix a couple of mem leaks

2007-07-31 Thread Daniel Veillard
On Mon, Jul 30, 2007 at 10:14:25PM +0100, Daniel P. Berrange wrote: > I ran 'make valgrind' for the first time in too long and found a hanful of > memory leaks in code exercised by the test suite. The attached patch fixes > them all. > > I'm sure there are more lurking though - the test suite is m

Re: [Libvir] PATCH Fix a couple of mem leaks

2007-07-30 Thread Daniel P. Berrange
On Mon, Jul 30, 2007 at 10:14:25PM +0100, Daniel P. Berrange wrote: > I ran 'make valgrind' for the first time in too long and found a hanful of > memory leaks in code exercised by the test suite. The attached patch fixes > them all. BTW, someone might have the answer for a question about valgrind

[Libvir] PATCH Fix a couple of mem leaks

2007-07-30 Thread Daniel P. Berrange
I ran 'make valgrind' for the first time in too long and found a hanful of memory leaks in code exercised by the test suite. The attached patch fixes them all. I'm sure there are more lurking though - the test suite is mainly focused on exercising & validating correctness of parsing routines - its