Re: [Libvir] Re: [PATCH] add missing qemudReportError

2008-02-06 Thread Daniel Veillard
On Wed, Feb 06, 2008 at 03:23:50PM +0100, Guido Guenther wrote: > I just noticed that the patch got mangled, sorry: > On Tue, Feb 05, 2008 at 01:09:15PM +0100, Guido Guenther wrote: > > That said it might also be worthwhile to not let libvirtd segfault > > because of a missing call to qemudReportEr

Re: [Libvir] Re: [PATCH] add missing qemudReportError

2008-02-06 Thread Guido Guenther
I just noticed that the patch got mangled, sorry: On Tue, Feb 05, 2008 at 01:09:15PM +0100, Guido Guenther wrote: > That said it might also be worthwhile to not let libvirtd segfault > because of a missing call to qemudReportError - this is debatable > though: diff --git a/src/qemu_conf.c b/src/qe

Re: [Libvir] Re: [PATCH] add missing qemudReportError

2008-02-05 Thread Daniel P. Berrange
On Tue, Feb 05, 2008 at 01:09:15PM +0100, Guido Guenther wrote: > On Tue, Feb 05, 2008 at 01:06:14PM +0100, Guido Guenther wrote: > > without this qemudParseVMDef might return NULL when the boot dev > > configuration is invalid but virGetLastError returns NULL either since > > no error has been set

[Libvir] Re: [PATCH] add missing qemudReportError

2008-02-05 Thread Guido Guenther
On Tue, Feb 05, 2008 at 01:06:14PM +0100, Guido Guenther wrote: > without this qemudParseVMDef might return NULL when the boot dev > configuration is invalid but virGetLastError returns NULL either since > no error has been set, this leads to a segfault in qemudLoadConfig when > trying to print the