[Libvir] Re: [PATCH 2/7] Fix issues with QEMU monitor interface.

2007-08-13 Thread Jim Paris
Daniel Veillard wrote: > > +/* Copy data, skipping 3-byte escape sequences */ > > +for (i = 0; i < got; i++) { > > +if (data[i] == '\033') > > +skip = 3; > > +if (skip) > > +skip--; > > +

[Libvir] Re: [PATCH 2/7] Fix issues with QEMU monitor interface.

2007-08-13 Thread Daniel Veillard
On Mon, Aug 13, 2007 at 12:54:05PM +0100, Daniel P. Berrange wrote: > On Mon, Aug 13, 2007 at 05:59:15AM -0400, Daniel Veillard wrote: > > On Sun, Aug 12, 2007 at 07:11:34PM -0400, Jim Paris wrote: > > > Due to the TTY layer, sending "\n" to the qemu monitor translates > > > into "\r\n" when receiv

[Libvir] Re: [PATCH 2/7] Fix issues with QEMU monitor interface.

2007-08-13 Thread Daniel P. Berrange
On Mon, Aug 13, 2007 at 05:59:15AM -0400, Daniel Veillard wrote: > On Sun, Aug 12, 2007 at 07:11:34PM -0400, Jim Paris wrote: > > Due to the TTY layer, sending "\n" to the qemu monitor translates > > into "\r\n" when received. This triggers a bug in older versions of > > QEMU (KVM <= 33) because t

[Libvir] Re: [PATCH 2/7] Fix issues with QEMU monitor interface.

2007-08-13 Thread Daniel Veillard
On Sun, Aug 12, 2007 at 07:11:34PM -0400, Jim Paris wrote: > Due to the TTY layer, sending "\n" to the qemu monitor translates > into "\r\n" when received. This triggers a bug in older versions of > QEMU (KVM <= 33) because the same command is executed twice, and > still has problems with fixed QE